Re: [netmod] augment and if-feature

worley@ariadne.com (Dale R. Worley) Thu, 16 March 2017 15:06 UTC

Return-Path: <worley@alum.mit.edu>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2613212957A for <netmod@ietfa.amsl.com>; Thu, 16 Mar 2017 08:06:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.934
X-Spam-Level:
X-Spam-Status: No, score=-1.934 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_SOFTFAIL=0.665] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VqVnE8ZQX9W5 for <netmod@ietfa.amsl.com>; Thu, 16 Mar 2017 08:06:23 -0700 (PDT)
Received: from resqmta-ch2-12v.sys.comcast.net (resqmta-ch2-12v.sys.comcast.net [IPv6:2001:558:fe21:29:69:252:207:44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 846621294E7 for <netmod@ietf.org>; Thu, 16 Mar 2017 08:05:51 -0700 (PDT)
Received: from resomta-ch2-07v.sys.comcast.net ([69.252.207.103]) by resqmta-ch2-12v.sys.comcast.net with SMTP id oWvqcb7YBUZfBoWyMcP2Si; Thu, 16 Mar 2017 15:05:50 +0000
Received: from hobgoblin.ariadne.com ([24.60.114.4]) by resomta-ch2-07v.sys.comcast.net with SMTP id oWyJc7hV9IDwKoWyLcy3aw; Thu, 16 Mar 2017 15:05:50 +0000
Received: from hobgoblin.ariadne.com (hobgoblin.ariadne.com [127.0.0.1]) by hobgoblin.ariadne.com (8.14.7/8.14.7) with ESMTP id v2GF5k3M007603; Thu, 16 Mar 2017 11:05:46 -0400
Received: (from worley@localhost) by hobgoblin.ariadne.com (8.14.7/8.14.7/Submit) id v2GF5jFJ007577; Thu, 16 Mar 2017 11:05:45 -0400
X-Authentication-Warning: hobgoblin.ariadne.com: worley set sender to worley@alum.mit.edu using -f
From: worley@ariadne.com
To: Robert Wilton <rwilton@cisco.com>
Cc: joey.boyd@adtran.com, netmod@ietf.org
In-Reply-To: <ef923b5e-8557-c6d3-8b10-e103cf8d38de@cisco.com> (rwilton@cisco.com)
Sender: worley@ariadne.com
Date: Thu, 16 Mar 2017 11:05:45 -0400
Message-ID: <87efxx1cty.fsf@hobgoblin.ariadne.com>
X-CMAE-Envelope: MS4wfEEfkxaUvIYLSLPSrNwwnb00bTERZ9MSA9bZr9UqVHKoGt0jz6sTqfMb3F+h4dE3GaY4usOFgvarHmRC4TJ1zh2v2v7yex/yEcPcp95gnGUBTuDiQ1Tc Bf215kUskBjQ64TkNhR1rS1PXmIJpxiVhNv14AhPCB5oYGZiJheLNEvyJqYL1g+boNhGMSEbGpGmifNfPOMVXicBveFlIOtvS7Ltnc834EkNmxT/kVbKYG3J
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/oFtd45VmNBVMgRIEior9Ew-yR48>
Subject: Re: [netmod] augment and if-feature
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Mar 2017 15:06:24 -0000

Robert Wilton <rwilton@cisco.com> writes:
> It isn't just any if-feature on the container that is being augmented 
> that needs to be considered.  You would have to consider all if-feature 
> statements by walking up the augmented node's ancestors to the top of 
> the tree and combine them, or have multiple if-feature statements.

Yes, I would expect that.

> Further, the 7950 YANG update rules allow for the augmented module to be 
> revised and some of those if-feature statements to be subsequently 
> removed.  If the augmenting module had restated the if-feature 
> conditions then this would probably leave the augmenting module 
> unintentionally out of sync with the module that it is augmenting.

It's an interesting sort of out-of-sync, though, as nothing would be
*incorrect*.  With some combinations of features, the augmented node
would have the agumentation and with some, it would not.  But it seems
to me that is quite OK, since whatever depends on the presence of the
augmentation (e.g., client logic or XPath expressions in the
augmentation) only expects the augmentation to be there if the
additional feature is present.

Dale