Re: [nfsv4] Barry Leiba's Discuss on draft-ietf-nfsv4-rpcrdma-cm-pvt-data-07: (with DISCUSS and COMMENT)

[Barry Leiba <[e-mail]>]

The diff looks good to me; thanks!

Barry

On Thu, Feb 13, 2020 at 10:30 AM Chuck Lever <[e-mail]> wrote:
>
>
>
> > On Feb 13, 2020, at 9:30 AM, Barry Leiba <[e-mail]> wrote:
> >
> > Hi, Chuck, and thanks for the quick response.
> >
> >>> — Section 5.2 —
> >>>
> >>>  A sender computes the encoded
> >>>  value by dividing the buffer size, in octets, by 1024 and subtracting
> >>>  one from the result.
> >>>
> >>> Is the buffer size necessarily a multiple of 1024?  If so, where is that
> >>> specified?  If not, what is the encoded value when the buffer size is, say,
> >>> 2000?  Is it zero?  Or one?
> >>
> >> Good catch! Buffer sizes are not constrained to 1024-byte length alignment.
> >>
> >> Further, if a sender posts, say, a 2032-byte message to a receiver that uses
> >> a 2000-byte buffer, a Receive error occurs that typically results in
> >> connection loss.
> >>
> >> IMO Section 5.2 should instruct the sender to round the actual buffer length
> >> down to the nearest 1024-byte multiple before encoding. Would that clarify
> >> the issue for you?
> >
> > Yes, that would be quite clear.
> >
> > And thanks for addressing my other comments as well.
>
> Please see
>
> https://chucklever.github.io/i-d-rpcrdma-cm-pvt-data/#go.draft-ietf-nfsv4-rpcrdma-cm-pvt-data.diff
>
> for an rfcdiff of changes intended to address your comments.
>
>
> --
> Chuck Lever
>
>
>