[nfsv4] Tsvart early review of draft-ietf-nfsv4-rpcrdma-version-two-06
Jana Iyengar via Datatracker <noreply@ietf.org> Sun, 13 March 2022 23:37 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: nfsv4@ietf.org
Delivered-To: nfsv4@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id BE3743A1809; Sun, 13 Mar 2022 16:37:57 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Jana Iyengar via Datatracker <noreply@ietf.org>
To: tsv-art@ietf.org
Cc: draft-ietf-nfsv4-rpcrdma-version-two.all@ietf.org, nfsv4@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.46.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <164721467764.7724.3033308208308987893@ietfa.amsl.com>
Reply-To: Jana Iyengar <jri.ietf@gmail.com>
Date: Sun, 13 Mar 2022 16:37:57 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/1xxbwuQ926cdS8M6FMApKaYULJU>
Subject: [nfsv4] Tsvart early review of draft-ietf-nfsv4-rpcrdma-version-two-06
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.29
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4/>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Mar 2022 23:37:58 -0000
Reviewer: Jana Iyengar Review result: On the Right Track Chuck, all, Thanks much for the updates to the draft to reflect a working flow control mechanism. I think the spirit is correct, but the description is unclear, my comments below are an attempt to clarify the text. Otherwise, this is almost there! Thanks and apologies for the delay in reviewing. Comments: 1/ “A peer tracks a few critical values for each connection.” —> “A sender tracks a few critical values for each connection.” 2/ For each of the variables described, replace “peer” with “sender” or receiver” as appropriate. Flow control functions require actions at the send side and at the receive side, and articulating which side is maintaining a variable or performing an action is very important to not introduce ambiguity and potential deadlocks. 3/ “Remote credits” —> I would suggest changing this to “Advertised Credits”, to avoid confusion about which endpoint uses this. 4/ “The sender MUST NOT post this message if the sender's "Send message counter" is greater than the current "Remote credits" value.” —> Two issues: (i) What is the “send message counter”? Is this supposed to be “Sent message count”? Or a new variable? (ii) each endpoint has its “Remote credits” value, which one does this sentence refer to? 5/ “A receiver MAY adjust its credit limit” —> “A receiver MAY adjust its advertised credit limit” 6/ “For instance, a peer may” —> “For instance, a receiver may” - jana
- [nfsv4] Tsvart early review of draft-ietf-nfsv4-r… Jana Iyengar via Datatracker
- Re: [nfsv4] Tsvart early review of draft-ietf-nfs… Chuck Lever III