[nfsv4] AD review: draft-ietf-nfsv4-minorversion1-dot-x-07

ext Lars Eggert <lars.eggert@nokia.com> Thu, 14 August 2008 01:40 UTC

Return-Path: <nfsv4-bounces@ietf.org>
X-Original-To: nfsv4-archive@megatron.ietf.org
Delivered-To: ietfarch-nfsv4-archive@core3.amsl.com
Received: from [127.0.0.1] (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id DF33C28C1C5; Wed, 13 Aug 2008 18:40:57 -0700 (PDT)
X-Original-To: nfsv4@core3.amsl.com
Delivered-To: nfsv4@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id C5E1028C1C2 for <nfsv4@core3.amsl.com>; Wed, 13 Aug 2008 18:40:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.425
X-Spam-Level:
X-Spam-Status: No, score=-5.425 tagged_above=-999 required=5 tests=[AWL=-0.893, BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4, RCVD_NUMERIC_HELO=2.067]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Vl1ejfEsz6D0 for <nfsv4@core3.amsl.com>; Wed, 13 Aug 2008 18:40:56 -0700 (PDT)
Received: from mgw-mx06.nokia.com (smtp.nokia.com [192.100.122.233]) by core3.amsl.com (Postfix) with ESMTP id 9328C28C164 for <nfsv4@ietf.org>; Wed, 13 Aug 2008 18:40:55 -0700 (PDT)
Received: from vaebh105.NOE.Nokia.com (vaebh105.europe.nokia.com [10.160.244.31]) by mgw-mx06.nokia.com (Switch-3.2.6/Switch-3.2.6) with ESMTP id m7E1eabu022505 for <nfsv4@ietf.org>; Thu, 14 Aug 2008 04:40:57 +0300
Received: from vaebh102.NOE.Nokia.com ([10.160.244.23]) by vaebh105.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 14 Aug 2008 04:40:22 +0300
Received: from esebh102.NOE.Nokia.com ([172.21.138.183]) by vaebh102.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 14 Aug 2008 04:40:13 +0300
Received: from 189.2.223.10.in-addr.arpa ([10.241.184.208]) by esebh102.NOE.Nokia.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Thu, 14 Aug 2008 04:40:12 +0300
Message-Id: <98B0E5F5-ACBF-416E-BAF5-476B03683794@nokia.com>
From: ext Lars Eggert <lars.eggert@nokia.com>
To: NFSv4 <nfsv4@ietf.org>
Mime-Version: 1.0 (Apple Message framework v926)
Date: Wed, 13 Aug 2008 18:40:11 -0700
X-Mailer: Apple Mail (2.926)
X-OriginalArrivalTime: 14 Aug 2008 01:40:13.0312 (UTC) FILETIME=[B208D800:01C8FDAE]
X-Nokia-AV: Clean
Subject: [nfsv4] AD review: draft-ietf-nfsv4-minorversion1-dot-x-07
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/pipermail/nfsv4>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Sender: nfsv4-bounces@ietf.org
Errors-To: nfsv4-bounces@ietf.org

INTRODUCTION, paragraph 13:
 > The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT",
 > "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this
 > document are to be interpreted as described in RFC 2119 [1].

   Is there any need to use RFC2119 terms in this document at all, given
   that it is raw XDR code? If not, I'd suggest to drop the RFC2119
   language (only present in some source comments) together with this
   paragraph and the corresponding reference.


Section 1., paragraph 3:
 > #!/bin/sh
 > grep "^  *///" | sed 's?^  *///??'

   Nit: IMO document readability would be a bit better if the sentinel
   sequence were followed by a whitespace ("/// ", or even "| ").


Section 2., paragraph 0:
 > 2.  Security Considerations
 > None.

   I'd refer to the security considerations section of [3] here. It's
   almost as short and may prevent a SEC person from complaining.


Section 3., paragraph 0:
 > 3.  IANA Considerations
 > None.

   I'd simply say that all IANA considerations are discussed in the IANA
   Considerations sections of [3].


Section 4.2., paragraph 1:
 > [3]  Shepler, S., Eisler, M., and D. Noveck, "NFS Version 4.1, A Work
 >      In Progress", Internet
 >      Draft draft-ietf-nfsv4-minorversion1-24.txt, December 2007.

   This needs to be a normative reference. (Also, the other document
   doesn't have "a work in progress" in the title :-)


_______________________________________________
nfsv4 mailing list
nfsv4@ietf.org
https://www.ietf.org/mailman/listinfo/nfsv4