Re: [nfsv4] [OPS-DIR] Opsdir telechat review of draft-ietf-nfsv4-umask-03

bfields@fieldses.org (J. Bruce Fields) Thu, 20 July 2017 18:02 UTC

Return-Path: <bfields@fieldses.org>
X-Original-To: nfsv4@ietfa.amsl.com
Delivered-To: nfsv4@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 86BBD131545; Thu, 20 Jul 2017 11:02:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.903
X-Spam-Level:
X-Spam-Status: No, score=-1.903 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X8fR3kjds0br; Thu, 20 Jul 2017 11:02:38 -0700 (PDT)
Received: from fieldses.org (fieldses.org [173.255.197.46]) by ietfa.amsl.com (Postfix) with ESMTP id AB874129B14; Thu, 20 Jul 2017 11:02:35 -0700 (PDT)
Received: by fieldses.org (Postfix, from userid 2815) id 4F2A53AA; Thu, 20 Jul 2017 14:02:35 -0400 (EDT)
Date: Thu, 20 Jul 2017 14:02:35 -0400
To: wangzitao <wangzitao@huawei.com>
Cc: "ops-dir@ietf.org" <ops-dir@ietf.org>, "draft-ietf-nfsv4-umask.all@ietf.org" <draft-ietf-nfsv4-umask.all@ietf.org>, "nfsv4@ietf.org." <nfsv4@ietf.org>
Message-ID: <20170720180235.GC16960@fieldses.org>
References: <E6BC9BBCBCACC246846FC685F9FF41EA2AE0979B@DGGEMM506-MBX.china.huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <E6BC9BBCBCACC246846FC685F9FF41EA2AE0979B@DGGEMM506-MBX.china.huawei.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
From: bfields@fieldses.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/UYhaNEvKsG1Sh0mhGx9zx2KluJ0>
Subject: Re: [nfsv4] [OPS-DIR] Opsdir telechat review of draft-ietf-nfsv4-umask-03
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4/>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Jul 2017 18:02:41 -0000

On Tue, May 23, 2017 at 02:59:03AM +0000, wangzitao wrote:
> I think the document is written very clear, except some small nits:
> Page 2: As a result, inherited ACEs describing ...
>         Suggest expanding the "ACE" or adding a reference since the term first appeared.

Done:

	http://git.linux-nfs.org/?p=bfields/NFSv4-umask.git;a=commitdiff;h=79ed0f4538e29b3e5158ad9cacb8233464a1ce58
	http://git.linux-nfs.org/?p=bfields/NFSv4-umask.git;a=commitdiff;h=4a797528e32766038008f693aa01a1235a9b1cf5

> Page 3: The same solution should work for NFS.
> 
>         Suggest adding a reference here.

The immediately preceding paragraph has a reference, I'm assuming that's
adequate.

>   ** The document seems to lack an Introduction section.

"Problem Statement" seems a better description to me here, and
https://tools.ietf.org/html/rfc7322#section-4.8.1 suggests this is OK,
so I'm sticking with that for now.

>   -- The document date (March 03, 2017) is 80 days in the past.  Is this
> 
>      intentional?

I believe that was correct.  In any case, it will be updated.

>   == Unused Reference:
...

I've removed all the unused references:

	http://git.linux-nfs.org/?p=bfields/NFSv4-umask.git;a=commitdiff;h=d4fe6a2ca472e31cefbca210f044d36fc0e8de86

>   -- Possible downref: Non-RFC (?) normative reference: ref. 'SUSv4'

Googling around lead me to rfc's 3967 and 7322....  I'd actually
overlooked that there were separate normative and informative sections.
I've moved this to the informative section:

	http://git.linux-nfs.org/?p=bfields/NFSv4-umask.git;a=commitdiff;h=c8c4752021f38740e3e958ebb5714a372717dfc5

Thanks!

--b.