[nfsv4] Éric Vyncke's No Objection on draft-ietf-nfsv4-delstid-05: (with COMMENT)

Éric Vyncke via Datatracker <noreply@ietf.org> Mon, 19 August 2024 08:11 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: nfsv4@ietf.org
Delivered-To: nfsv4@ietfa.amsl.com
Received: from [10.244.2.52] (unknown [104.131.183.230]) by ietfa.amsl.com (Postfix) with ESMTP id 9360BC151540; Mon, 19 Aug 2024 01:11:33 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Éric Vyncke via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
X-Test-IDTracker: no
X-IETF-IDTracker: 12.22.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <172405509327.1870311.17212566196246729825@dt-datatracker-6df4c9dcf5-t2x2k>
Date: Mon, 19 Aug 2024 01:11:33 -0700
Message-ID-Hash: 5H76NEO77M5YA322IFP4FGSXDUXBAAIK
X-Message-ID-Hash: 5H76NEO77M5YA322IFP4FGSXDUXBAAIK
X-MailFrom: noreply@ietf.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-nfsv4.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-nfsv4-delstid@ietf.org, nfsv4-chairs@ietf.org, nfsv4@ietf.org
X-Mailman-Version: 3.3.9rc4
Reply-To: Éric Vyncke <evyncke@cisco.com>
Subject: [nfsv4] Éric Vyncke's No Objection on draft-ietf-nfsv4-delstid-05: (with COMMENT)
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/ZYcsAAQlHH6IA6B03wKLncLgy54>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Owner: <mailto:nfsv4-owner@ietf.org>
List-Post: <mailto:nfsv4@ietf.org>
List-Subscribe: <mailto:nfsv4-join@ietf.org>
List-Unsubscribe: <mailto:nfsv4-leave@ietf.org>

Éric Vyncke has entered the following ballot position for
draft-ietf-nfsv4-delstid-05: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-nfsv4-delstid/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------


# Éric Vyncke, INT AD, comments for draft-ietf-nfsv4-delstid-05

Thank you for the work put into this document.

Please find below some non-blocking COMMENT points (but replies would be
appreciated even if only for my own education).

Special thanks to Christopher Inacio for the shepherd's detailed write-up
including the WG consensus and the justification of the intended status.

I hope that this review helps to improve the document,

Regards,

-éric

# COMMENTS (non-blocking)

## Abstract

The text about `Discussion of this draft...` should not be part of the abstract
but be in its own dedicated section.

## Section 1

While the abstract contains `This document extends both NFSv4.1 (see RFC8881)
and NFSv4.2 (see RFC7863)`, this section only has `the revisions in this
document become an extension of NFSv4.2 [RFC7862]`. I.e., there is a
discrepancy at first sight.

Some explanations about `delegation stateids` will be welcome for the reader.

## Section 2

Should there be informative reference (or a warning in section 1.1 to re-use
terms from RFC xyz) for GETATTR, ... ?

## Section 3

What is `bitmap4`, while I am not a NFS expert, I would expect having some
terminology defined (see comment to section 2).

## Section 3.1

I am not familiar with XDR, but I wonder why the specifications are split in
multiple CODE brackets rather than a single one. Also puzzled by the use of
`///` as I read them as comments. Even section 6 does not explain why there is
a need for a sentinel.

## Section 5.1

Suggest to mention NFSv3 in the section title.

## Section 6.1

It does not really hurt repeating the code licensing but it is redundant with
"Copyright notice"

## Section 8

As I am not a NFS expert, I find strange that IANA registries are not used in
this document. But, if this is the authors/WG choice, then let it be.