[nfsv4] draft-haynes-nfsv4-delstid-00 comments

Mike Kupfer <mike.kupfer@oracle.com> Wed, 11 July 2018 22:30 UTC

Return-Path: <mike.kupfer@oracle.com>
X-Original-To: nfsv4@ietfa.amsl.com
Delivered-To: nfsv4@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7259F130E73 for <nfsv4@ietfa.amsl.com>; Wed, 11 Jul 2018 15:30:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.31
X-Spam-Level:
X-Spam-Status: No, score=-4.31 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=oracle.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gsgdLMX_UXsw for <nfsv4@ietfa.amsl.com>; Wed, 11 Jul 2018 15:30:11 -0700 (PDT)
Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5EA69130DE1 for <nfsv4@ietf.org>; Wed, 11 Jul 2018 15:30:11 -0700 (PDT)
Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w6BMT58J087949 for <nfsv4@ietf.org>; Wed, 11 Jul 2018 22:30:10 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : cc : date : message-id : mime-version : content-type; s=corp-2018-07-02; bh=1FFogZDPDULyBHtCsPU+43TgFf2YkzI2kRKjDiFFFRk=; b=Tub9nppEch7OxmW6GCICeOmaOz7ZQ93btVJsDjujyFqwlQ+Nu7nSo4VpQ6EjwuVjnFps kuc8LvHhx1vE8cbRK+p9Subg0aNZlI3ybcDgHTC1NGGMmNyzJ+CZNL3FlOZoNUT33UMa Hgy/QIVVsAV8pxBubzkzRYmQPNjEzsvXSjl35L92XIXbK2N7mMD5GcdHghm8cRqBvdCy K8W1DtuklGpt4PQlQW+964llbzneSpA3I7PQJUd1KxgehZEJiO2FBlDv6yvmGiVGvBsb EepXjO5B17CiWuXhzis2GqwCsxLIdL70a6QlenYwPnU5YlDQDknMaEROptMGUOtNFNDm 3Q==
Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2k2p7vg2yv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <nfsv4@ietf.org>; Wed, 11 Jul 2018 22:30:10 +0000
Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w6BMU9rF009190 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <nfsv4@ietf.org>; Wed, 11 Jul 2018 22:30:10 GMT
Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w6BMU98i015155 for <nfsv4@ietf.org>; Wed, 11 Jul 2018 22:30:09 GMT
Received: from ol (/10.159.232.121) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 11 Jul 2018 15:30:09 -0700
From: Mike Kupfer <mike.kupfer@oracle.com>
To: nfsv4@ietf.org
Date: Wed, 11 Jul 2018 15:30:08 -0700
Message-ID: <864lh54d8v.fsf@oracle.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8951 signatures=668706
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=13 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=410 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807110236
Archived-At: <https://mailarchive.ietf.org/arch/msg/nfsv4/bESRKeUmqGCivx9v_wI1l6CUEwI>
Subject: [nfsv4] draft-haynes-nfsv4-delstid-00 comments
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nfsv4/>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jul 2018 22:30:14 -0000

Here's my feedback on draft-haynes-nfsv4-delstid-00.  I've omitted a
couple comments that were already covered by Dave Noveck.  Apologies
for not getting this written up earlier.

* Comments on delegated timestamps

Another use case for delegated timestamps would be when the client has
a lot of dirty data for the file and an application asks for the
file's mtime.  My understanding is that the Linux client delays the
stat() call until the dirty data is written back.  If the client can
specify the mtime, then there's no need to wait for the writeback to
finish.

The current proposal disallows setting the timestamp to an earlier
time, and it disallows setting the timestamp to a time in the future.
Are those restrictions really necessary?  If yes, then the spec should
discuss how the client can make such changes (e.g., in response to a
user specifying a time via the "touch" command).  (And don't NetApp
and EMC have some scheme where a file can be made immutable and
unremovable by a series of steps that include changing the access
time?)

When the spec talks about the server accepting the time values from
the client, I assume that the server is allowed to lose precision, as
per Section 2.2.1 of RFC 7530.

* Editorial nits

- Page 1
  - serveral -> several
  - opeing -> opening
- Page 2
  - semnatics -> semantics
- Page 5
  - Those references to "microversion" should all be "minor version",
    shouldn't they?
  - documuent -> document
  - Section Section -> Section
- Page 7
  - negiotiate -> negotiate
- Page 8
  - prequisite -> prerequisite
  - Section 4.1: "With a server" -> "When a server"

regards,
mike