[nfsv4] Some minor fixes to the pnfs-object-layout draft

Boaz Harrosh <bharrosh@panasas.com> Wed, 09 December 2009 16:40 UTC

Return-Path: <bharrosh@panasas.com>
X-Original-To: nfsv4@core3.amsl.com
Delivered-To: nfsv4@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 50D283A6B09 for <nfsv4@core3.amsl.com>; Wed, 9 Dec 2009 08:40:32 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.265
X-Spam-Level:
X-Spam-Status: No, score=-2.265 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, IP_NOT_FRIENDLY=0.334]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cjoqJLNVCFos for <nfsv4@core3.amsl.com>; Wed, 9 Dec 2009 08:40:31 -0800 (PST)
Received: from daytona.int.panasas.com (daytona.panasas.com [67.152.220.89]) by core3.amsl.com (Postfix) with ESMTP id 452803A6AF1 for <nfsv4@ietf.org>; Wed, 9 Dec 2009 08:40:30 -0800 (PST)
Received: from [192.168.0.142] ([172.17.33.25]) by daytona.int.panasas.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 9 Dec 2009 11:40:19 -0500
Message-ID: <4B1FD2F1.7090106@panasas.com>
Date: Wed, 09 Dec 2009 18:40:17 +0200
From: Boaz Harrosh <bharrosh@panasas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091203 Fedora/3.0-3.13.rc2.fc12 Thunderbird/3.0
MIME-Version: 1.0
To: Benny Halevy <bhalevy@panasas.com>, "Welch, Brent" <welch@panasas.com>, nfsv4@ietf.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 09 Dec 2009 16:40:19.0746 (UTC) FILETIME=[4B7C3020:01CA78EE]
X-Mailman-Approved-At: Thu, 10 Dec 2009 08:01:21 -0800
Subject: [nfsv4] Some minor fixes to the pnfs-object-layout draft
X-BeenThere: nfsv4@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: NFSv4 Working Group <nfsv4.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/nfsv4>
List-Post: <mailto:nfsv4@ietf.org>
List-Help: <mailto:nfsv4-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nfsv4>, <mailto:nfsv4-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Dec 2009 16:42:17 -0000

I'd suggest two fixes to section 5.3. Data Mapping Schemes

1. Throughout the section there are Formulas with missing parenthesis
   for example:
	N = L / (W-P * stripe_unit)

   it is not nice that W-P is not inside parenthesis as proper in math annotation
   rules, even though the spacing does hint of the author intention in this case.

2. In: 5.4.4. PNFS_OSD_RAID_PQ
  It is made to believe that both a raid_4/fixed-parity-devices and raid5/rotate-parity-devices
  are possible. I think it is only rotate-parity-devices, right?

And if you are opening the draft for editing then we have that accumulated error extension
when out-of-memory condition happens at layout-return.
[ In short, a last error-component can have a NULL-out component descriptor with an error-value
  and an accumulated byte range. The byte range is the union of all failing ranges and the
  error-value is the most sever error-out of the lot, so for example one device had EIO and another
  ERESOURCE the EIO is returned. (with defined error severity)]

Thanks
Boaz