[Ntp] Tsvart last call review of draft-ietf-ntp-port-randomization-06

Brian Trammell via Datatracker <noreply@ietf.org> Tue, 23 February 2021 19:15 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: ntp@ietf.org
Delivered-To: ntp@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 525863A0F48; Tue, 23 Feb 2021 11:15:29 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Brian Trammell via Datatracker <noreply@ietf.org>
To: tsv-art@ietf.org
Cc: draft-ietf-ntp-port-randomization.all@ietf.org, last-call@ietf.org, ntp@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.26.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <161410772927.11488.2925276656781805208@ietfa.amsl.com>
Reply-To: Brian Trammell <ietf@trammell.ch>
Date: Tue, 23 Feb 2021 11:15:29 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/ntp/H8gSoQ_vxY52Ltf8eK4Cc_i1sSA>
Subject: [Ntp] Tsvart last call review of draft-ietf-ntp-port-randomization-06
X-BeenThere: ntp@ietf.org
X-Mailman-Version: 2.1.29
List-Id: <ntp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ntp>, <mailto:ntp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ntp/>
List-Post: <mailto:ntp@ietf.org>
List-Help: <mailto:ntp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ntp>, <mailto:ntp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Feb 2021 19:15:30 -0000

Reviewer: Brian Trammell
Review result: Ready with Nits

This document has been reviewed as part of the transport area review team's
ongoing effort to review key IETF documents. These comments were written
primarily for the transport area directors, but are copied to the document's
authors and WG to allow them to address any issues raised and also to the IETF
discussion list for information.

When done at the time of IETF Last Call, the authors should consider this
review as part of the last-call comments they receive. Please always CC
tsv-art@ietf.org if you reply to or forward this review.

This document is ready from a transport standpoint. It describes an
already-implemented, relatively-straightforward application of an existing BCP
to a well-understood protocol, and is clearly written. I especially appreciated
the complete set of considerations, covering situations in which NTP port
randomization could cause issues with certain deployment scenarios. The effect
of routing on NTP is well studied (one such study is cited in the draft), and
sections 3.3 and 3.4 discuss how this draft could interact with on-path
modification of NTP traffic. Herein lies my only nit with the draft: it would
be nice if 3.3 and 3.4 discussed how an NTP-speaking endpoint could detect and
react to issues caused by misconfigured filtering or NAT.