Re: [Ntp] I-D Action: draft-mlichvar-ntp-over-ptp-03.txt

Miroslav Lichvar <mlichvar@redhat.com> Mon, 27 March 2023 14:37 UTC

Return-Path: <mlichvar@redhat.com>
X-Original-To: ntp@ietfa.amsl.com
Delivered-To: ntp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CA553C151B07 for <ntp@ietfa.amsl.com>; Mon, 27 Mar 2023 07:37:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iNwgj_-Je47c for <ntp@ietfa.amsl.com>; Mon, 27 Mar 2023 07:37:57 -0700 (PDT)
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 40240C14CE42 for <ntp@ietf.org>; Mon, 27 Mar 2023 07:37:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679927875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZVUHSHA2nY2EdCdNdDPmKBAmvJ6zuvIoJQ007ivN7u8=; b=KL7Ls5lwwxh2ZcSwin4LKzYI19fst1PKlnfg7vPmqfT+EKrC3POk33tS+o4M1hjMUt/dTk kRn+ZARyZbvYDLHzlvD0k7scM8+0TbuJ5EChKlZV0gcIDCYXVniXjbVK/6xZp5YmTQdwdU 31tmhZuSITciqoSePA0CKPOYw/L2Cuc=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-68-Wpo6LMP2NAu-CskG2O0Rxg-1; Mon, 27 Mar 2023 10:37:54 -0400
X-MC-Unique: Wpo6LMP2NAu-CskG2O0Rxg-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1286E884EC3 for <ntp@ietf.org>; Mon, 27 Mar 2023 14:37:54 +0000 (UTC)
Received: from localhost (unknown [10.43.135.229]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ABA4A202701E for <ntp@ietf.org>; Mon, 27 Mar 2023 14:37:53 +0000 (UTC)
Date: Mon, 27 Mar 2023 16:37:51 +0200
From: Miroslav Lichvar <mlichvar@redhat.com>
To: ntp@ietf.org
Message-ID: <ZCGqPxe6fCle4E7o@localhost>
References: <167819348731.61111.17805820073382061341@ietfa.amsl.com> <5a503d60208a4605a94df5e37097cfc2@ostfalia.de>
MIME-Version: 1.0
In-Reply-To: <5a503d60208a4605a94df5e37097cfc2@ostfalia.de>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Archived-At: <https://mailarchive.ietf.org/arch/msg/ntp/U1zwscwuSvCTw-2fmtePuzc_myg>
Subject: Re: [Ntp] I-D Action: draft-mlichvar-ntp-over-ptp-03.txt
X-BeenThere: ntp@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Network Time Protocol <ntp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ntp>, <mailto:ntp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ntp/>
List-Post: <mailto:ntp@ietf.org>
List-Help: <mailto:ntp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ntp>, <mailto:ntp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Mar 2023 14:37:57 -0000

On Mon, Mar 27, 2023 at 01:49:12PM +0000, Langer, Martin wrote:
> I read your draft and added a few comments. I hope it helps you a bit.

That's great. Thank you.

> I still have one general question about it. Are the hardware timestamps written
> directly to the NTP TLV? I didn't find anything about this in the draft.

The draft is about enabling hardware receive timestamps on hardware
which can timestamp only PTP messages. The hardware is not expected to
modify the message. The timestamps have to be fetched by the
networking driver from some specific registers of the NIC. This limits
the maximum rate of timestamping and is the reason why PTP uses two
UDP ports. The event port is used only for messages that needs to be
timestamped.

To answer some of the questions you added to the pdf:

One-step mode doesn't matter here as that is for transmit timestamps,
not receive timestamps.

The lack of on-path support was mentioned as an advantage of
NTP-over-PTP, because it still processes measurements as NTP and
doesn't assume a constant network delay (changing only on network
reconfiguration or server reselection).

Symmetric mode works in NTP-over-PTP and still cannot be secured by
NTS.

There doesn't have to be an actual PTP clock with ports in some
specific PTP state operating on the NTP server or client. There could
be a PTP clock in other domain or transport, but doesn't have to be.

I'm not sure how exactly it works with specifying new TLVs for PTP.
Does IETF have an organization Id we could use?

NTP request and NTP response are both included in a PTP delay request.

Modifying the PTP sequenceId (not protected by NTP authentication)
doesn't matter for NTP. We just need the hardware+driver to not
deduplicate the messages in case they actually look at the value. A
MITM attacker can always cause a denial of service.

-- 
Miroslav Lichvar