Re: [Ntp] WG Call for Adoption: draft-stenn-ntp-extension-fields

Hal Murray <hmurray@megapathdsl.net> Sat, 29 September 2018 03:41 UTC

Return-Path: <hmurray@megapathdsl.net>
X-Original-To: ntp@ietfa.amsl.com
Delivered-To: ntp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C2140130DC4 for <ntp@ietfa.amsl.com>; Fri, 28 Sep 2018 20:41:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 1.034
X-Spam-Level: *
X-Spam-Status: No, score=1.034 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HELO_DYNAMIC_IPADDR=1.951, RDNS_DYNAMIC=0.982, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OoG7a81D1lko for <ntp@ietfa.amsl.com>; Fri, 28 Sep 2018 20:41:29 -0700 (PDT)
Received: from ip-64-139-1-69.sjc.megapath.net (ip-64-139-1-69.sjc.megapath.net [64.139.1.69]) by ietfa.amsl.com (Postfix) with ESMTP id 0ED4D128B14 for <ntp@ietf.org>; Fri, 28 Sep 2018 20:41:28 -0700 (PDT)
Received: from shuksan (localhost [127.0.0.1]) by ip-64-139-1-69.sjc.megapath.net (Postfix) with ESMTP id 537EA40605C; Fri, 28 Sep 2018 20:41:26 -0700 (PDT)
X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.3
To: Harlan Stenn <stenn@nwtime.org>
cc: ntp@ietf.org, hmurray@megapathdsl.net
From: Hal Murray <hmurray@megapathdsl.net>
In-Reply-To: Message from Harlan Stenn <stenn@nwtime.org> of "Fri, 28 Sep 2018 17:40:39 PDT." <662d9916-9e1f-cdae-9941-d1c186bf7e00@nwtime.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Date: Fri, 28 Sep 2018 20:41:26 -0700
Message-Id: <20180929034126.537EA40605C@ip-64-139-1-69.sjc.megapath.net>
Archived-At: <https://mailarchive.ietf.org/arch/msg/ntp/buhJ9wGKSQ90FPmsKniqWgSxGJo>
Subject: Re: [Ntp] WG Call for Adoption: draft-stenn-ntp-extension-fields
X-BeenThere: ntp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <ntp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ntp>, <mailto:ntp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ntp/>
List-Post: <mailto:ntp@ietf.org>
List-Help: <mailto:ntp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ntp>, <mailto:ntp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Sep 2018 03:41:31 -0000

stenn@nwtime.org said:
> In an operational setting, how is external information about what is or is
> not supported useful? 

It helps an admin decide if they want to use that server or not.


> The whole point of I-DO is that it provides a way for a newer instance of the
> code to operationally detect what the other side can handle.

It doesn't (yet) handle the I-DONT case.

There is still the problem of old servers that do/don't do leap smearing, so 
the idea of checking a web page or similar shouldn't be strange.


> Have you actually implemented your idea?

No.  Miroslav Lichvar's comment about updating a Correction EF complicates 
things.

> What does it get you?  What does it *not* get you?

What it gets me, is simplification of the EF/MAC handling.  I don't have to 
worry about all the kludgery to dance around MACs that might get confused with 
EFs.

More importantly, I don't have to think about it.




> Where do you see that the minimum length is 8?  Section 4.2 (the new section
> 7.5) says: 

I was reading quickly.
>    While the minimum field length of an EF that contains no value or
>    padding fields is one word (four octets), and the minimum field
>    length of an EF that contains required fields is two words (8
>    octets), ...
I saw the second half which says "required fields".  If they are required, 
then they must be there so the min length is 8.


> The text of the old and new stuff is pretty small, and it's pretty easy to
> see what changed.  Are you saying you have tried to implement this and you
> had difficulty? 
I was trying to find what it said about the minimum length.  That could be a 
simple sentence.  Instead, I have to do a manual diff.  The old section 7.5 is 
a half page.  The new is a page and a half.  Somebody could easily focus on 
the new stuff without noticing the length change.


> As for your second, would you be happier with:
>  R: 0 for "Information/Query", 1 for a "Response" 
I think what's missing is the idea that the Request/Response bit only applies 
to some uses.  As written, it doesn't allow for unsolicited information.


> https://www.ietf.org/archive/id/draft-stenn-ntp-mac-last-ef-02.txt

Thanks.  That seems overly complicated, but I admit I haven't thought about 
this area a lot.

Your last EF adds 4 bytes, but leaves a bare MAC.  I've been trying to think 
of ways to get rid of bare MACs.  Your MAC-EF takes 8 more bytes for a single 
MAC.

I think I'd prefer a single MAC-EF - same layout as your LAST-EF except the 
length includes the MAC.

>> The link behind "NEW: 'RFC5905 Section 7.5.1 - Extension Fields and MACs'" 
in
>> the Table of Contents doesn't work.  (It's a new section.  There is no 
place
>> to link to.  I think the link should be removed.)
> There is a place to link to - it's on the top of page 8.

Your "top of page 8" is in the new document.

Here is the link I was referring to:
  https://tools.ietf.org/html/rfc5905#section-7.5.1
It goes to the old RFC.  There is no section 7.5.1 in the old RFC.
There are actually 2 occurrences of that link.  One in the Table of Contents 
and a second  at the top of page 8, the header for section 4.3


-- 
These are my opinions.  I hate spam.