[ntpwg] Comments about draft-wu-ntp-ntp-cfg

Tal Mizrahi <talmi@marvell.com> Mon, 02 November 2015 09:51 UTC

Return-Path: <ntpwg-bounces+ntp-archives-ahfae6za=lists.ietf.org@lists.ntp.org>
X-Original-To: ietfarch-ntp-archives-ahFae6za@ietfa.amsl.com
Delivered-To: ietfarch-ntp-archives-ahFae6za@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 87AA21A0371 for <ietfarch-ntp-archives-ahFae6za@ietfa.amsl.com>; Mon, 2 Nov 2015 01:51:38 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.909
X-Spam-Level:
X-Spam-Status: No, score=-1.909 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xAIyxufAx1si for <ietfarch-ntp-archives-ahFae6za@ietfa.amsl.com>; Mon, 2 Nov 2015 01:51:37 -0800 (PST)
Received: from lists.ntp.org (lists.ntp.org [IPv6:2001:4f8:fff7:1::7]) by ietfa.amsl.com (Postfix) with ESMTP id ED61B1A0370 for <ntp-archives-ahFae6za@lists.ietf.org>; Mon, 2 Nov 2015 01:51:36 -0800 (PST)
Received: from lists.ntp.org (lists.ntp.org [149.20.68.7]) by lists.ntp.org (Postfix) with ESMTP id E26F486DB07 for <ntp-archives-ahFae6za@lists.ietf.org>; Mon, 2 Nov 2015 09:51:36 +0000 (UTC)
X-Original-To: ntpwg@lists.ntp.org
Delivered-To: ntpwg@lists.ntp.org
Received: from mail1.ntp.org (mail1.ntp.org [IPv6:2001:4f8:fff7:1::5]) by lists.ntp.org (Postfix) with ESMTP id 98A5C86D4A6 for <ntpwg@lists.ntp.org>; Mon, 2 Nov 2015 09:24:32 +0000 (UTC)
Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]) by mail1.ntp.org with esmtps (TLSv1:AES256-SHA:256) (Exim 4.77 (FreeBSD)) (envelope-from <talmi@marvell.com>) id 1ZtBLg-000AZo-24 for ntpwg@lists.ntp.org; Mon, 02 Nov 2015 09:24:32 +0000
Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.15.0.59/8.15.0.59) with SMTP id tA29KKc2027771; Mon, 2 Nov 2015 01:24:15 -0800
Received: from il-exch02.marvell.com ([199.203.130.102]) by mx0a-0016f401.pphosted.com with ESMTP id 1xwh0hhyge-1 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 02 Nov 2015 01:24:15 -0800
Received: from IL-EXCH01.marvell.com (10.4.102.220) by IL-EXCH02.marvell.com (10.4.102.221) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Mon, 2 Nov 2015 11:24:12 +0200
Received: from IL-EXCH01.marvell.com ([fe80::41:1c9f:8611:3a4a]) by IL-EXCH01.marvell.com ([fe80::41:1c9f:8611:3a4a%20]) with mapi id 15.00.1044.021; Mon, 2 Nov 2015 11:24:12 +0200
From: Tal Mizrahi <talmi@marvell.com>
To: "'ntpwg@lists.ntp.org'" <ntpwg@lists.ntp.org>, "draft-wu-ntp-ntp-cfg@ietf.org" <draft-wu-ntp-ntp-cfg@ietf.org>
Thread-Topic: Comments about draft-wu-ntp-ntp-cfg
Thread-Index: AdEVT0DLLGSkC9qlRgm0lp32n++zrQ==
Date: Mon, 02 Nov 2015 09:24:11 +0000
Message-ID: <e5f3d81893b243fd85cc536e72758ac7@IL-EXCH01.marvell.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [199.203.130.14]
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2015-11-02_05:, , signatures=0
X-Proofpoint-Spam-Details: rule=inbound_notspam policy=inbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1511020169
X-SA-Exim-Connect-IP: 67.231.148.174
X-SA-Exim-Rcpt-To: ntpwg@lists.ntp.org
X-SA-Exim-Mail-From: talmi@marvell.com
X-SA-Exim-Version: 4.2
X-SA-Exim-Scanned: Yes (on mail1.ntp.org)
Subject: [ntpwg] Comments about draft-wu-ntp-ntp-cfg
X-BeenThere: ntpwg@lists.ntp.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: IETF Working Group for Network Time Protocol <ntpwg.lists.ntp.org>
List-Unsubscribe: <http://lists.ntp.org/options/ntpwg>, <mailto:ntpwg-request@lists.ntp.org?subject=unsubscribe>
List-Archive: <http://lists.ntp.org/pipermail/ntpwg/>
List-Post: <mailto:ntpwg@lists.ntp.org>
List-Help: <mailto:ntpwg-request@lists.ntp.org?subject=help>
List-Subscribe: <http://lists.ntp.org/listinfo/ntpwg>, <mailto:ntpwg-request@lists.ntp.org?subject=subscribe>
Content-Type: multipart/mixed; boundary="===============9069260558160003845=="
Errors-To: ntpwg-bounces+ntp-archives-ahfae6za=lists.ietf.org@lists.ntp.org
Sender: ntpwg <ntpwg-bounces+ntp-archives-ahfae6za=lists.ietf.org@lists.ntp.org>

Hi,

A couple of minor comments:


1.       Please delete the "; on the following line:
<mailto:eric.wu@huawei.com>";

2.       The current YANG model seems to include two data nodes: ntp-cfg and ntp-state. According to Section 4.9 of RFC 6087, there should be at most one top-level data node in a YANG data model.

3.       The indentation throughout the YANG model (Section 4) is not accurately consistent with the hierarchies.
Examples:
See 3 lines above "container ntp-state"
See 2 lines above "container multicast-server"

Thanks,
Tal.


_______________________________________________
ntpwg mailing list
ntpwg@lists.ntp.org
http://lists.ntp.org/listinfo/ntpwg