[nvo3] Comments on draft-hy-nvo3-gue-4-nvo-04

"Murray S. Kucherawy" <superuser@gmail.com> Tue, 28 March 2017 22:39 UTC

Return-Path: <superuser@gmail.com>
X-Original-To: nvo3@ietfa.amsl.com
Delivered-To: nvo3@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9A2A112708C for <nvo3@ietfa.amsl.com>; Tue, 28 Mar 2017 15:39:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id soxY-SY-jzHl for <nvo3@ietfa.amsl.com>; Tue, 28 Mar 2017 15:39:03 -0700 (PDT)
Received: from mail-vk0-x232.google.com (mail-vk0-x232.google.com [IPv6:2607:f8b0:400c:c05::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 80ED7126BF0 for <nvo3@ietf.org>; Tue, 28 Mar 2017 15:39:03 -0700 (PDT)
Received: by mail-vk0-x232.google.com with SMTP id d188so105461398vka.0 for <nvo3@ietf.org>; Tue, 28 Mar 2017 15:39:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=/yINYQ6CzZLuZbpNhEc5mdk6lke3NySWsph2bfqt2ks=; b=BwnFuYGd+SS8IOmUlt1LaLrFNByS7tZTRu4jVeWoebsawtt3106h6vutyZn8D60pX3 stqelVnOVp5VJsgFDeQjCQtKIac+aQmbeF8ww8av7TWC7Psga8ZlN1av8IRRR5wgQFru QJ4tNF1obxkwaGFLhs3fs2GKGerx2y+1cl7qrxJIJNT+mG9w/8vTjZkC2uJM7oa9icCl zY71cV/BhVW66jDLxpHlo8t5rXtm3N6GFX0Cf70hdscAQ5egkPYP9IW7kWAhjzdtIFev JBSHZ7Y3LNuGRDv7EttasGIUoDICxe7T+X2lTRS5okpa8Qw2Jy80tSK+DphXxZwFupJv gLbA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=/yINYQ6CzZLuZbpNhEc5mdk6lke3NySWsph2bfqt2ks=; b=ejKczZ4BwjuqMI0ybJKoQeHv47klQmj3D14p1zWJJA9uKwBFVG6XfdRm/Kyl/jtnSh vRWbew7LbV1Rh3923UeemA5sn4+e12wHDFq1fVsvQuDBVmnjfonujEgUfkFQXnAQ3oJE e//9kNqfsUiyQlh/Nxvhoh6GaVje4G7ibjK60rlsRazOWVUUpUi+JDCM+tUKXc22HxfR N363TFW56ZSr60R2fxPjOwpQsxO7FpFg5WObbOLmaJmylEspJkinrwY9NKq/6wDDbzVE TADEZ/Ki3aw71ShjfmsmBECmVEw0dOldnjeCpMqKkbv+pT8Jj1rifthzHlMfpQel+PdJ wO/A==
X-Gm-Message-State: AFeK/H0PQRHLqUWAAnYEFREvkEsCoqBoN6KFy4pcKsWOyjZy6Rr+dcHRH4YU3454SL4sEWYGOoTHCt+FkVa/cQ==
X-Received: by 10.31.61.194 with SMTP id k185mr14155971vka.141.1490740742244; Tue, 28 Mar 2017 15:39:02 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.103.130.70 with HTTP; Tue, 28 Mar 2017 15:39:01 -0700 (PDT)
From: "Murray S. Kucherawy" <superuser@gmail.com>
Date: Tue, 28 Mar 2017 17:39:01 -0500
Message-ID: <CAL0qLwY36+yi-hWE7+jq22uJcs9ThRdYF80isSOhGoOHgunnjw@mail.gmail.com>
To: nvo3@ietf.org
Content-Type: multipart/alternative; boundary="001a114dbd7064d018054bd22086"
Archived-At: <https://mailarchive.ietf.org/arch/msg/nvo3/6t6ZIu-vlO_GdfT-uEgzmE1XZNg>
Subject: [nvo3] Comments on draft-hy-nvo3-gue-4-nvo-04
X-BeenThere: nvo3@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Network Virtualization Overlays \(NVO3\) Working Group" <nvo3.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/nvo3>, <mailto:nvo3-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/nvo3/>
List-Post: <mailto:nvo3@ietf.org>
List-Help: <mailto:nvo3-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/nvo3>, <mailto:nvo3-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Mar 2017 22:39:06 -0000

I've been asked to review various NVO and GUE documents, and this is my
next target.  Hopefully these are helpful.

Section 1:

1) The [GUE] reference is stale.  The referenced document is now an intarea
work item.

2) "same was" should probably be "same way"

3) "applications, that" should be either "applications that" or
"applications, which"

Section 3:

4) "after UDP header" should be "after the UDP header".

5) Some of the field names aren't capitalized when they should be.

6) The last two paragraphs are repetitive and probably not needed.  They
all seem to say that the package MUST comply with GUE and NVO3.  I think
it's enough to say that once, but I also think you don't need to say it at
all given that it's clear from the document already that these are done in
the GUE and NVO3 context.

7) There are instances of "may" scattered around in this section and below
that need to become MAY or some other word (RFC2119).

Section 4:

8) Is that first "MUST be" necessary?  Could you just say "are"?

9) The next two MUSTs are possibly not needed, for the same reason as in
(6) above.

10) The subsections of Section 4 are indented.  Was this prepared with some
non-standard mechanism?

Section 4.1:

11) Could "MUST set" just be "sets"?  Could "MUST use" just be "uses"?

Section 4.3:

12) Given that SHOULD (see its definition in RFC2119), what's a situation
where one might legitimately not do what the SHOULD says?  If there is no
such case, make it a MUST; if there is such a case, please describe it.  If
you make it a "MUST", you can't use "avoid", because "avoid" leaves wiggle
room.

Section 5:

13) I think this has to be done more clearly.  There are two actions to be
taken here, and they should be described individually, preferably in their
own subsections, and referencing by name the two registries that are being
accessed.  You might include a normative reference to the document where
the registries are created, which I think is [GUE].  See RFC5226.

-MSK