Re: [OAUTH-WG] Rename callback => callback_uri

Evan Gilbert <uidude@google.com> Fri, 16 April 2010 20:57 UTC

Return-Path: <uidude@google.com>
X-Original-To: oauth@core3.amsl.com
Delivered-To: oauth@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 74C063A6AD5 for <oauth@core3.amsl.com>; Fri, 16 Apr 2010 13:57:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -101.848
X-Spam-Level:
X-Spam-Status: No, score=-101.848 tagged_above=-999 required=5 tests=[AWL=0.128, BAYES_00=-2.599, FM_FORGED_GMAIL=0.622, HTML_MESSAGE=0.001, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qjjju8ILaRM9 for <oauth@core3.amsl.com>; Fri, 16 Apr 2010 13:57:42 -0700 (PDT)
Received: from smtp-out.google.com (smtp-out.google.com [74.125.121.35]) by core3.amsl.com (Postfix) with ESMTP id 240AC3A6774 for <oauth@ietf.org>; Fri, 16 Apr 2010 13:57:39 -0700 (PDT)
Received: from kpbe20.cbf.corp.google.com (kpbe20.cbf.corp.google.com [172.25.105.84]) by smtp-out.google.com with ESMTP id o3GKvUbf021491 for <oauth@ietf.org>; Fri, 16 Apr 2010 22:57:30 +0200
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1271451451; bh=qsc776rr6bqlXceuybcJDnLp5dU=; h=MIME-Version:In-Reply-To:References:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Cggz6Kivoi8z8Gl8g7eqyah2PjY2jykjo4tqSZDJv+rGaaaGFiSVn0HRKZESdcFMO S+S0W6Me2GCVNSCmj3GHQ==
DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=mime-version:in-reply-to:references:from:date:message-id: subject:to:cc:content-type:x-system-of-record; b=tIarK+Ezjzps0+m2lLVegpV9Ngp8CI/M5hZpOjoYYg2RIy/hnNLTD9tYtTnHzq7os xxbbfquA4PvlZvKf40eGw==
Received: from qw-out-2122.google.com (qwb9.prod.google.com [10.241.193.73]) by kpbe20.cbf.corp.google.com with ESMTP id o3GKv282005405 for <oauth@ietf.org>; Fri, 16 Apr 2010 13:57:29 -0700
Received: by qw-out-2122.google.com with SMTP id 9so933394qwb.49 for <oauth@ietf.org>; Fri, 16 Apr 2010 13:57:29 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.229.78.131 with HTTP; Fri, 16 Apr 2010 13:57:08 -0700 (PDT)
In-Reply-To: <C7EE1A7E.3242C%eran@hueniverse.com>
References: <5A37E56E-3F6B-437E-89DF-D2FD8F2EF8E7@facebook.com> <C7EE1A7E.3242C%eran@hueniverse.com>
From: Evan Gilbert <uidude@google.com>
Date: Fri, 16 Apr 2010 13:57:08 -0700
Received: by 10.229.186.211 with SMTP id ct19mr3039268qcb.16.1271451448353; Fri, 16 Apr 2010 13:57:28 -0700 (PDT)
Message-ID: <y2sc8689b661004161357v88c08c80oee6c33339f2493a1@mail.gmail.com>
To: Eran Hammer-Lahav <eran@hueniverse.com>
Content-Type: multipart/alternative; boundary="0016364edb1cedaed9048460db6f"
X-System-Of-Record: true
Cc: Naitik Shah <naitik@facebook.com>, OAuth WG <oauth@ietf.org>
Subject: Re: [OAUTH-WG] Rename callback => callback_uri
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/oauth>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Apr 2010 20:57:44 -0000

On Fri, Apr 16, 2010 at 1:45 PM, Eran Hammer-Lahav <eran@hueniverse.com>wrote:

>  We should use the right term, not just the less conflicting term.
>
> The Web Callback flow uses a callback from the server to the client – this
> is not a redirection. The User-Agent flow uses a redirection which is
> fundamentally different from a callback.
>


   callback
         An absolute URI to which the authorization server will redirect
         the end user back when the end user authorization step is
         completed.  The authorization server MAY require the client to
         pre-register their callback URI.


   redirection
         An absolute URI to which the authorization server will redirect
         the user-agent to when the end user authorization step is
         completed.  The authorization server SHOULD require the client
         to pre-register their redirection URI.

These look the same to me, and "redirect_uri/url" works. Open to other
terms.



> If you don’t want to use callback and want to use the same name for both,
> it needs to be something more generic like client_uri.
>
> EHL
>
>
> On 4/16/10 12:11 PM, "Naitik Shah" <naitik@facebook.com> wrote:
>
> +1 for redirect_uri -- highest semantic value imho.
>
>
> -Naitik
>
>
>
> On Apr 16, 2010, at 12:05 PM, Evan Gilbert wrote:
>
> > We should use the same name in the User-Agent and Web Callback flows.
> Also, although the authorization server won't be allowing JSONP requests,
> "callback" has become a bit of a defacto standard for JSONP and it would be
> nice to use a term that isn't overloaded?
> >
> > Can we make them both "redirection"? Even better, maybe "redirect_uri"?
> >
> > On Fri, Apr 16, 2010 at 9:50 AM, Luke Shepard <lshepard@facebook.com>
> wrote:
> > Facebook API requests are protected resources. They can be called either
> in a browser or in a server-to-server environment.
> >
> > For example, a JSONP call for my name looks like this:
> >
> >
> https://api.facebook.com/restserver.php?api_key=361900759629&call_id=1271436355034&callback=FB.RestServer._callback&format=json&method=fql.query&query=SELECT%20name%20FROM%20user%20WHERE%20uid%3D2901279&v=1.0
> >
> > The output (you can play with it here:
> http://fbrell.com/fb.api/everyone-data ):
> >
> >        FB.RestServer._callback([{"name":"Luke Shepard"}]);
> >
> > If we want that protected resource to take an access token as well, then
> it would look like:
> >
> >
> https://api.facebook.com/restserver.php?....&callback=FB.RestServer._callback&access_token=ACCESS_TOKEN
> >
> > The "callback" parameter is used pretty universally for JSONP requests.
> For instance, see the Jquery docs: http://api.jquery.com/jQuery.getJSON/
> >
> > -----Original Message-----
> > From: Richard Barnes [mailto:rbarnes@bbn.com <rbarnes@bbn.com>]
> > Sent: Friday, April 16, 2010 9:10 AM
> > To: Luke Shepard
> > Cc: Eran Hammer-Lahav; Naitik Shah; OAuth WG
> > Subject: Re: [OAUTH-WG] Rename callback => callback_uri
> >
> > Could you clarify a little more the environment in which this
> > confusion arose?  What do you mean when you say "The protected
> > resource typically accepts 'callback' as a parameter to support
> > JSONP."?  What sort of software are you including in this?
> >
> > --Richard
> >
> >
> > On Apr 15, 2010, at 5:41 PM, Luke Shepard wrote:
> >
> > > We already had one developer try it out and get confused because the
> > > server tried to treat the callback URL as a JSONP callback.
> > >
> > > The protected resource typically accepts "callback" as a parameter
> > > to support JSONP. If a developer accidentally passes in callback
> > > there (maybe they got confused) then the server can't give a normal
> > > error message - instead it needs to either detect that it looks like
> > > a URL or otherwise reject it.
> > >
> > > On a related note, I think it's more confusing calling it something
> > > different in the user-agent flow (redirector) when it's essentially
> > > doing the same thing.
> > >
> > >
> > > From: oauth-bounces@ietf.org [mailto:oauth-bounces@ietf.org<oauth-bounces@ietf.org>]
> On
> > > Behalf Of Eran Hammer-Lahav
> > > Sent: Thursday, April 15, 2010 5:37 AM
> > > To: Naitik Shah; OAuth WG
> > > Subject: Re: [OAUTH-WG] Rename callback => callback_uri
> > >
> > > I don't think it is that confusing. Its a completely different
> > > context from where JSON-P is used (note that in the User-Agent flow
> > > it is called something else).
> > >
> > > EHL
> > >
> > >
> > > On 4/10/10 12:35 PM, "Naitik Shah" <naitik@facebook.com> wrote:
> > >
> > > With the simplified params, the callback url parameter is now just
> > > "callback". Since most major API providers already use "callback" to
> > > signify JSON-P callback, can we rename this to "callback_uri"? This
> > > will help avoid collisions and confusion.
> > >
> > >
> > > -Naitik
> > > _______________________________________________
> > > OAuth mailing list
> > > OAuth@ietf.org
> > > https://www.ietf.org/mailman/listinfo/oauth
> > >
> > > _______________________________________________
> > > OAuth mailing list
> > > OAuth@ietf.org
> > > https://www.ietf.org/mailman/listinfo/oauth
> >
> > _______________________________________________
> > OAuth mailing list
> > OAuth@ietf.org
> > https://www.ietf.org/mailman/listinfo/oauth
> >
>
> _______________________________________________
> OAuth mailing list
> OAuth@ietf.org
> https://www.ietf.org/mailman/listinfo/oauth
>
>