Re: [OAUTH-WG] Fwd: Several typos in -20 and a possible security consideration
Torsten Lodderstedt <torsten@lodderstedt.net> Mon, 25 July 2011 23:10 UTC
Return-Path: <torsten@lodderstedt.net>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6E07521F86D8 for <oauth@ietfa.amsl.com>; Mon, 25 Jul 2011 16:10:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.248
X-Spam-Level:
X-Spam-Status: No, score=-2.248 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, HELO_EQ_DE=0.35, HTML_MESSAGE=0.001]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P7BBNNIQndBD for <oauth@ietfa.amsl.com>; Mon, 25 Jul 2011 16:10:20 -0700 (PDT)
Received: from smtprelay01.ispgateway.de (smtprelay01.ispgateway.de [80.67.18.13]) by ietfa.amsl.com (Postfix) with ESMTP id 06A4721F86D7 for <oauth@ietf.org>; Mon, 25 Jul 2011 16:10:19 -0700 (PDT)
Received: from [70.25.120.2] (helo=[10.255.254.219]) by smtprelay01.ispgateway.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from <torsten@lodderstedt.net>) id 1QlUHw-0003vo-Gv; Tue, 26 Jul 2011 01:10:17 +0200
Message-ID: <4E2DF7D5.8090701@lodderstedt.net>
Date: Mon, 25 Jul 2011 19:10:13 -0400
From: Torsten Lodderstedt <torsten@lodderstedt.net>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; de; rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11
MIME-Version: 1.0
To: Niv Steingarten <nivstein@gmail.com>
References: <CACEVmuoodRGS45zHmnTWX04uGhgTCLgSddLbPPd2qgoudrq31A@mail.gmail.com> <90C41DD21FB7C64BB94121FBBC2E723450245F58E6@P3PW5EX1MB01.EX1.SECURESERVER.NET> <CACEVmurNP=G9c06bS4ftk+bKgNuFw+VVna132numsyPSBjVP+A@mail.gmail.com>
In-Reply-To: <CACEVmurNP=G9c06bS4ftk+bKgNuFw+VVna132numsyPSBjVP+A@mail.gmail.com>
Content-Type: multipart/alternative; boundary="------------010603080006090904080807"
X-Df-Sender: torsten@lodderstedt-online.de
Cc: oauth@ietf.org
Subject: Re: [OAUTH-WG] Fwd: Several typos in -20 and a possible security consideration
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/oauth>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Jul 2011 23:10:21 -0000
Hi Niv, thank you for posting this to the list. I think you are right with your threat description. One question: shouldn't the browser already prevent the request to the authorization endpoint because of the same origin policy (or CORS restrictions)? Apart from that, a similar attack can be performed by a native applicication (using an embedded browser). This kind of attack could not be prevented using HTTP features but by enforcing a real user interaction (password input, CAPTCHA). regards, Torsten. Am 25.07.2011 18:27, schrieb Niv Steingarten: > Forwarded as per Eran's request. > > A couple of corrections to my original email: > > 1. By AJAX, I mean, AJAX like techniques (if the user agent does not > enforce same origin policy). > 2. When saying POST to '/authorize_callback' -- it may well be GET, if > the authorization server mishandles the request. > > Thank you, > > Niv > > > > ---------- Forwarded message ---------- > From: *Eran Hammer-Lahav* <eran@hueniverse.com > <mailto:eran@hueniverse.com>> > Date: Tue, Jul 26, 2011 at 01:21 > Subject: RE: Several typos in -20 and a possible security consideration > To: Niv Steingarten <nivstein@gmail.com <mailto:nivstein@gmail.com>> > > > Please forward this message to the oauth list at oauth@ieft.org > <mailto:oauth@ieft.org>. > > Thanks, > > EHL > > *From:*Niv Steingarten [mailto:nivstein@gmail.com > <mailto:nivstein@gmail.com>] > *Sent:* Monday, July 25, 2011 2:52 PM > *To:* draft-ietf-oauth-v2@tools.ietf.org > <mailto:draft-ietf-oauth-v2@tools.ietf.org> > *Subject:* Several typos in -20 and a possible security consideration > > Hello, > > I've noticed a couple of typos in -20: > > Section 6 (page 41): Under 'The authorization server MUST', the second > bullet should end with the word "and", and the third bullet should end > with a full-stop. > > Section 10.2 (first paragraph): "...keep is client credentials > confidential" should be "...keep *its* client credentials confidential". > > Regarding the security consideration -- > > I might be missing something, but I saw there are references to > clickjacking and to client impersonation, but I haven't seen any > reference to possible resource owner impersonation. > > For example, in the implicit grant flow, a malicious client could send > a request to the authorization endpoint via, say, AJAX, and receive > the markup of the page asking the resource owner to authorize the > client (assuming the resource owner is signed in and no resource owner > authentication is required). Then, in a poorly designed authorization > endpoint, the 'Allow' button might be the submission button of a form > whose target is '/authorize_callback' on the authz server. Then, it > may possible for the malicious client to simply POST to > '/authorize_callback' and authorize itself without any resource owner > intervention or knowledge that the process has even taken place. This, > of course, can be mitigated in most modern browsers if the > authorization server verifies the source of the request using the HTTP > referrer header. > > Thanks for your time and for the fantastic work on OAuth, > > > -- > > *Niv Steingarten* > > T: > > E: nivstein@gmail.com <mailto:nivstein@gmail.com> > > W:http://nivstein.com > > > > > -- > *Niv Steingarten* > * > * > T: > E: nivstein@gmail.com <mailto:nivstein@gmail.com> > W:http://nivstein.com > > > _______________________________________________ > OAuth mailing list > OAuth@ietf.org > https://www.ietf.org/mailman/listinfo/oauth
- [OAUTH-WG] Fwd: Several typos in -20 and a possib… Niv Steingarten
- Re: [OAUTH-WG] Fwd: Several typos in -20 and a po… Torsten Lodderstedt
- Re: [OAUTH-WG] Fwd: Several typos in -20 and a po… Niv Steingarten
- Re: [OAUTH-WG] Fwd: Several typos in -20 and a po… Niv Steingarten
- Re: [OAUTH-WG] Fwd: Several typos in -20 and a po… Torsten Lodderstedt
- Re: [OAUTH-WG] Fwd: Several typos in -20 and a po… Niv Steingarten