Re: [OAUTH-WG] draft-hammer-oauth-v2-mac-token-02

William Mills <wmills@yahoo-inc.com> Sat, 05 February 2011 16:38 UTC

Return-Path: <wmills@yahoo-inc.com>
X-Original-To: oauth@core3.amsl.com
Delivered-To: oauth@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 276133A69B7 for <oauth@core3.amsl.com>; Sat, 5 Feb 2011 08:38:58 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -17.369
X-Spam-Level:
X-Spam-Status: No, score=-17.369 tagged_above=-999 required=5 tests=[AWL=-0.106, BAYES_00=-2.599, HTML_MESSAGE=0.001, IP_NOT_FRIENDLY=0.334, NO_RDNS_DOTCOM_HELO=0.001, USER_IN_DEF_WHITELIST=-15]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z1r66v7ROHRl for <oauth@core3.amsl.com>; Sat, 5 Feb 2011 08:38:54 -0800 (PST)
Received: from mrout2-b.corp.re1.yahoo.com (mrout2-b.corp.re1.yahoo.com [69.147.107.21]) by core3.amsl.com (Postfix) with ESMTP id 9CC333A6902 for <oauth@ietf.org>; Sat, 5 Feb 2011 08:38:54 -0800 (PST)
Received: from SP2-EX07CAS01.ds.corp.yahoo.com (sp2-ex07cas01.corp.sp2.yahoo.com [98.137.59.37]) by mrout2-b.corp.re1.yahoo.com (8.14.4/8.14.4/y.out) with ESMTP id p15GfhBg008209; Sat, 5 Feb 2011 08:41:43 -0800 (PST)
Received: from SP2-EX07VS06.ds.corp.yahoo.com ([98.137.59.24]) by SP2-EX07CAS01.ds.corp.yahoo.com ([98.137.59.37]) with mapi; Sat, 5 Feb 2011 08:41:43 -0800
From: William Mills <wmills@yahoo-inc.com>
To: Eran Hammer-Lahav <eran@hueniverse.com>, OAuth WG <oauth@ietf.org>
Date: Sat, 05 Feb 2011 08:41:41 -0800
Thread-Topic: draft-hammer-oauth-v2-mac-token-02
Thread-Index: Acu50HMZE3ElIG/6SjSQTXJNzEiUCwLgpcKA
Message-ID: <FFDFD7371D517847AD71FBB08F9A31563849221B1C@SP2-EX07VS06.ds.corp.yahoo.com>
References: <90C41DD21FB7C64BB94121FBBC2E723445A8D61EBF@P3PW5EX1MB01.EX1.SECURESERVER.NET>
In-Reply-To: <90C41DD21FB7C64BB94121FBBC2E723445A8D61EBF@P3PW5EX1MB01.EX1.SECURESERVER.NET>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US
Content-Type: multipart/alternative; boundary="_000_FFDFD7371D517847AD71FBB08F9A31563849221B1CSP2EX07VS06ds_"
MIME-Version: 1.0
Subject: Re: [OAUTH-WG] draft-hammer-oauth-v2-mac-token-02
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/oauth>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Feb 2011 16:38:58 -0000

Reading through and looking at your example in 1.1 I think you don't have enough lines.  Your text specified 9 elements to be signed, but you only have 7 lines in the text to be signed.  The way I read the text you should have 9 elements followed by newlines, which can be empty, but the newlines should be there.

-bill

From: oauth-bounces@ietf.org [mailto:oauth-bounces@ietf.org] On Behalf Of Eran Hammer-Lahav
Sent: Friday, January 21, 2011 5:10 PM
To: OAuth WG
Subject: [OAUTH-WG] draft-hammer-oauth-v2-mac-token-02

http://tools.ietf.org/html/draft-hammer-oauth-v2-mac-token-02

New version includes the following changes:

   o  Added body-hash support.
   o  Updated OAuth 2.0 reference to -12 and added token type registration template.
   o  Removed error and error URI attributes (codes were just a duplication of the HTTP status codes).

Feedback would be greatly appreciated.

EHL