[OAUTH-WG] Re: [Last-Call] Re: draft-ietf-oauth-rfc8725bis-06 ietf last call Artart review
Valery Smyslov <smyslov.ietf@gmail.com> Thu, 30 July 2026 14:41 UTC
Return-Path: <smyslov.ietf@gmail.com>
X-Original-To: oauth@mail2.ietf.org
Delivered-To: oauth@mail2.ietf.org
Received: from localhost (localhost [127.0.0.1]) by mail2.ietf.org (Postfix) with ESMTP id 3367212118F0A for <oauth@mail2.ietf.org>; Thu, 30 Jul 2026 07:41:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ietf.org; s=ietf1; t=1785422483; bh=Zaq6pHJ06Awl0xWWUENBwBgIJsO3GIZ1p/AsVbQFJ9M=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=gEG3NDxlvNCeu8dabAkSvSTiqvE4kske5gVfbsQVafQbKQQ/EJ+rz0o7BpS8uRoGa dEYCLZj4Y3yUyAlEoQYFzS+oheFAecGYrH71rGse58P0iRMIu0fXPpvi+bI6ZeYRWF FTlWldlJRT/mpk6GwzhXZsiXmwUz73ZlOua8Ew4M=
X-Virus-Scanned: amavisd-new at ietf.org
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: mail2.ietf.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail2.ietf.org ([166.84.6.31]) by localhost (mail2.ietf.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id djdA5FLkd4Zk for <oauth@mail2.ietf.org>; Thu, 30 Jul 2026 07:41:22 -0700 (PDT)
Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail2.ietf.org (Postfix) with ESMTPS id 979D212118EB1 for <oauth@ietf.org>; Thu, 30 Jul 2026 07:41:21 -0700 (PDT)
Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-39c7ef2b1e2so19425741fa.1 for <oauth@ietf.org>; Thu, 30 Jul 2026 07:41:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785422474; x=1786027274; darn=ietf.org; h=content-language:thread-index:content-type:mime-version:message-id :date:subject:in-reply-to:references:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=3Jhr6V01UTh9dgzRu2Yf7sApEW/BIRecXE71SMD20EA=; b=Bngbw5OGXYzKOI/Pxv08aZ7IspHFj0blCR1bJ31IKF2wgX+PQCD5hHLrArXT0Z8G75 qp7iYOuMMHe66ys4VBqA+OBzRPHsNHI7VE5qPyou2TvyQCU/Kug3aXkF4hV6m5q7Qmwc nTr3nQVUqfwpnBirbw4Nr4Xh5VRlh0iuSuxahFuScu54RVVzZvrlEwjnyinn6+Rl8otQ PgtZ0vAdGCR5vxdHtl2YLplL25nJ6u0+a1FML4kCRrlImNbQpbW8j64AvWYloNoUZT0m vDGUiWLAwbqm+Vx3q09EFRHYj8fSvDZCcXaN0v6EqIt5FJnEvcI88UKdchQMGgCkfn9u ahbg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785422474; x=1786027274; h=content-language:thread-index:content-type:mime-version:message-id :date:subject:in-reply-to:references:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3Jhr6V01UTh9dgzRu2Yf7sApEW/BIRecXE71SMD20EA=; b=B3KOTIJ9KPEa6/evZgr26lG2+zgWg2SOUw2g1C1ljfAleWZjhYDI4GhcsqvqvI/XKQ 7+xy1yXHIZwq9PFyFKuurcZ4yYVG22egs68mWrBxgLwTmomMPdW5MNk6gNgJ2kb4bY7N rm71JqKlTYOYbMftPsBdr6vYB8D+SG6rUWyFe5h/0HiVowQ9d4s2QqaEUdEx0gsHHMwK YymM/B4ow9lYAqOrjfPzPR60XkFNG8qM3a/lUcSv6bKdIPPYYN8DQ7ECgg7raSEtZPwJ dWWqmhP5f3fXRReWGjLs1/Hh3zf+JvKhwaKyV4pxi4zZke3X2C6ZmfipqAmmkB9zPTKz TQ/Q==
X-Forwarded-Encrypted: i=1; AHgh+RpKeSFXKHIt94qhlmBpWelIirVJkqD1bCMCvCbbZYAuOeVd6wi/NNPr+y5nI2dnwdWfhuD6Hg==@ietf.org
X-Gm-Message-State: AOJu0YzHUwHpEDIFrDueTl22wWFNjbhYXabbaAN85y0wWgFb5vZypgXz aT4yJkm2bWtkjoV5xCvPg/RtSMN/vlpNp9/vp/57GcG9B2nAFnomssns
X-Gm-Gg: AR+sD11dOTFmYbJMjUJQ9RULMNoloNraKBgBcOJDSimTAQD/WZVz1TQn+IJGiOwILVJ pNjzqGqCReg6qOH0ArZGggPfeXeCl1M9lFe9l73dIOevsmBi0optevHrr/x02gco0gyDfq4Dd9F vSTpfpGe1McAks6Uw0IYH57S3wedhyfF/62sx30VpJcc8QIZUvZzVCA0QOZ0vuerOPmkVv7Ejlz +GW8QAJzkKQFMXI8drceCOGflGIt2ohVUASntGaoNCl7AjP6XtFc7Edp1bAE4fHTOaAeH/Q7nvG 9YYkUM0i+KugnwR/rNosGgVAjlO7YltTuN0+cDVxOR5ytAPL6iyCaCAiwqGh/8moCaQ7tZj+Xkz nBtuoUkKu1y92t4EiDkJTP9XHAGXutoBLU/fLr93utusoFHDtYONAUWU0wi87yCqLuLb6uv3aqZ B8j6X7Jvw33rEQP/5tdgEOo1E2dYvtCcJujVLGAvcsyCHkFFq/J1ygS/k0mK+Ch0ituR3Azdsmc CtFhRc=
X-Received: by 2002:a05:651c:1b84:b0:39f:65f4:ebab with SMTP id 38308e7fff4ca-39f6d1925e7mr4881051fa.34.1785422473578; Thu, 30 Jul 2026 07:41:13 -0700 (PDT)
Received: from BuildPC ([93.188.44.204]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39f6ac9b9f4sm3550221fa.32.2026.07.30.07.41.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jul 2026 07:41:13 -0700 (PDT)
From: Valery Smyslov <smyslov.ietf@gmail.com>
To: 'Yaron Sheffer' <yaronf.ietf@gmail.com>, 'Valery Smyslov' <valery@smyslov.net>, art@ietf.org
References: <178367030161.1178.219881871660251080@dt-datatracker-d4d6ff9d9-kg6bf> <13b01f6d-1309-4deb-bdf4-d8fd6910146d@gmail.com>
In-Reply-To: <13b01f6d-1309-4deb-bdf4-d8fd6910146d@gmail.com>
Date: Thu, 30 Jul 2026 17:41:12 +0300
Message-ID: <0c3601dd2031$77f76050$67e620f0$@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_NextPart_000_0C37_01DD204A.9D492C30"
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQHcxcx3roznAwr2OSH+XoXdgHuSFwFr3/TUtnt4CsA=
Content-Language: ru
Message-ID-Hash: FDKXFXEY2QI2ER7KM46356HHXX55XW3M
X-Message-ID-Hash: FDKXFXEY2QI2ER7KM46356HHXX55XW3M
X-MailFrom: smyslov.ietf@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-oauth.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-oauth-rfc8725bis.all@ietf.org, last-call@ietf.org, oauth@ietf.org
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [OAUTH-WG] Re: [Last-Call] Re: draft-ietf-oauth-rfc8725bis-06 ietf last call Artart review
List-Id: OAUTH WG <oauth.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/oauth/hr7-YfE4OYOFXHQyQJjAIoQk0dc>
List-Archive: <https://mailarchive.ietf.org/arch/browse/oauth>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Owner: <mailto:oauth-owner@ietf.org>
List-Post: <mailto:oauth@ietf.org>
List-Subscribe: <mailto:oauth-join@ietf.org>
List-Unsubscribe: <mailto:oauth-leave@ietf.org>
Hi Yaron,
my concerns were addressed, thanks.
Regards,
Valery.
Hi Valery,
Thank you for the detailed review. Your comments should be all addressed in -07 of the draft. Specifically, we have essentially rewritten sec. 3.11 and 3.13, and went through the SHOULD statements across the document. It would be great if you could verify that you're good with these changes.
Thanks,
Yaron
[1] https://datatracker.ietf.org/doc/draft-ietf-oauth-rfc8725bis/
On 10/07/2026 9:58, Valery Smyslov via Datatracker wrote:
Document: draft-ietf-oauth-rfc8725bis
Title: JSON Web Token Best Current Practices
Reviewer: Valery Smyslov
Review result: Ready with Issues
I am the assigned ART directorate reviewer for this document. These comments
were written primarily for the benefit of the ART area directors. Document
editors and WG chairs should treat these comments just like any other last call
comments.
The document describes Best Current Practices leading to secure implementation
and deployment of JSON Web Tokens (JWTs). The document lists known treats
and vulnerabilities for JWTs and for each provides possible mitigation.
I have some minor issues with this document.
1. Sections 3.1, 3.2, 3.6, 3.10, 3.11 contain SHOULDs without clarifying under which conditions
they can be ignored. While I personally think that in some cases such clarifications
are redundant, it seems that the IESG treats their absence more seriously these days,
so I let the AD deside whether they are needed in this document.
2. Section 3.11
The sentence
When
explicit typing is employed, implementations SHOULD register and use
the full media type name "application/example+jwt", where "example"
identifies the specific kind of JWT, and SHOULD set the corresponding
"typ" value to "example+jwt", because distinct types make cross-JWT
substitution harder when validators check "typ", and because
misapplying the Section 4.1.9 prefix rule can cause validators to
reject otherwise valid tokens or accept the wrong type.
is hard to parse due to its length and multiple mentioned conditions.
I suggest to split it into several smaller recommendations.
In addition, it is not defined under what conditions these SHOUDs
can be ignored.
3. Section 3.11
In the sentence
This pairing
SHOULD be omitted only when the JWT cannot be confused with other
kinds of JWTs in its application context.
shouldn't this SHOULD be MAY? At least it is my feeling from reading
this text. And if I'm wrong, then I think the text should be
re-written (and also include conditions when this SHOULD cab be ignored).
4. Section 3.13
I'm a bit confused reading recommendations given in this section.
I believe that the two RECOMMENDED clauses are not consisting:
Implementations are RECOMMENDED to set a reasonable upper limit on
the number of hash iterations...
and
Rejecting inputs with a p2c (PBES2 Count) value larger than twice that figure is RECOMMENDED...
So, what values are recommended to reject - larger the limit or larger than twice the limit?
Am I missing something?
5. Section 3.11
In the sentence
For example, for Security
Event Tokens (SETs) [RFC8417], the media type is "application/
secevent+jwt" and the "typ" value SHOULD be "secevent+jwt", because...
why uppercase SHOULD is used? I believe, this is just an example, thus must be "should". No?
- [OAUTH-WG] draft-ietf-oauth-rfc8725bis-06 ietf la… Valery Smyslov via Datatracker
- [OAUTH-WG] Re: draft-ietf-oauth-rfc8725bis-06 iet… Yaron Sheffer
- [OAUTH-WG] Re: [Last-Call] Re: draft-ietf-oauth-r… Valery Smyslov