Re: [OAUTH-WG] AD review of draft-ietf-oauth-iss-auth-resp-02

Karsten Meyer zu Selhausen <karsten.meyerzuselhausen@hackmanit.de> Thu, 28 October 2021 08:42 UTC

Return-Path: <karsten.meyerzuselhausen@hackmanit.de>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AEBF53A084B for <oauth@ietfa.amsl.com>; Thu, 28 Oct 2021 01:42:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.418
X-Spam-Level:
X-Spam-Status: No, score=-5.418 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, NICE_REPLY_A=-3.33, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=hackmanit.de
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AQ5xr4QshPta for <oauth@ietfa.amsl.com>; Thu, 28 Oct 2021 01:41:58 -0700 (PDT)
Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C8C5A3A0844 for <oauth@ietf.org>; Thu, 28 Oct 2021 01:41:56 -0700 (PDT)
Received: by mail-wr1-x42d.google.com with SMTP id u18so8781869wrg.5 for <oauth@ietf.org>; Thu, 28 Oct 2021 01:41:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hackmanit.de; s=google; h=message-id:date:mime-version:user-agent:content-language:to:cc :references:from:subject:in-reply-to; bh=Cu0iY5dfY9dzQ4c2OTsXL/6qipwGIhGqNJaSvAUkWuU=; b=juQcx+HtUpV+imPzkDSlM1BJJiOKJOU/33fru9oy/pgvCX1OW53Ro6fjBB4z4JfSzy q0p37BsjbxLVV6pvdE4ucXULoZfzbUCBmm8rzRsB8LCazGAFrfc378XI1WC/AY4TVrgI F/jNkB1AM3Ak9pAvtiA5Syt37R3SFWbq3JAjI=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to; bh=Cu0iY5dfY9dzQ4c2OTsXL/6qipwGIhGqNJaSvAUkWuU=; b=6lVHSryOMx/lKGpPAgQAOPycK7a+eYgPoCjyzJsip4wLSSJODGDxLTNFvCZLRlXBa+ E5w8aurI1lQr2oy/J0OXy4m0ccQvT8sg2905+5h4HRJfu0vg/Ysucv7i1t8+IYfJVU+l wWG/OOj96ttLzFHF33e93RHT1I/EypWB5RZ5TXf0pbIJQr/GwiHZF2xi2ZwA8aTDZDbo 2bK1cPzSM5N5fukhvVS8uMkmaW8FC68z3w4fxujtxmOH/slRgaXjJ7xAyjYU7QIO9Xbo 8vWHWs9L119jjgkUdDFZIHGS8jezR6BtD/xfD36NHW6+uVsPkEH0BVU1AcZzXKQeij7o ANzQ==
X-Gm-Message-State: AOAM530UEk1XPxHOd/qMy3Co0uXD4OHzrpsZnk5apqVOMUkMfUQsevdg Z0kEs/iDLvx+abRbFnI0ocIaZcsZtbtSmQ==
X-Google-Smtp-Source: ABdhPJywaTf+5Y9E0K48Gf3YtaNlFhD1OTf/jzBzQ6jyZH5QNk4l/zfOxfJNn7ItCjMeiiUq1ERz7g==
X-Received: by 2002:a5d:64c8:: with SMTP id f8mr3955516wri.398.1635410514285; Thu, 28 Oct 2021 01:41:54 -0700 (PDT)
Received: from [192.168.137.26] (b2b-37-24-87-133.unitymedia.biz. [37.24.87.133]) by smtp.gmail.com with ESMTPSA id o11sm3526080wry.0.2021.10.28.01.41.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Oct 2021 01:41:53 -0700 (PDT)
Message-ID: <d6a4d975-e2d2-f72f-de6c-b538b48be7fb@hackmanit.de>
Date: Thu, 28 Oct 2021 10:41:52 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1
Content-Language: en-US
To: Warren Parad <wparad=40rhosys.ch@dmarc.ietf.org>, Roman Danyliw <rdd@cert.org>
Cc: "oauth@ietf.org" <oauth@ietf.org>
References: <BN1P110MB0939DFB7DCA3DBBE3CCA7B53DC859@BN1P110MB0939.NAMP110.PROD.OUTLOOK.COM> <CAJot-L26xWtTpu=zyBYyRYLoxO2jW5PDt5oQG8JdzxEcsYMHDg@mail.gmail.com>
From: Karsten Meyer zu Selhausen <karsten.meyerzuselhausen@hackmanit.de>
In-Reply-To: <CAJot-L26xWtTpu=zyBYyRYLoxO2jW5PDt5oQG8JdzxEcsYMHDg@mail.gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="------------NBX7f6x0J0nV3QR9UW3JOlml"
Archived-At: <https://mailarchive.ietf.org/arch/msg/oauth/jH2RkGCC4BnnL_k-PcbLFpc36Tc>
Subject: Re: [OAUTH-WG] AD review of draft-ietf-oauth-iss-auth-resp-02
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/oauth/>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Oct 2021 08:42:05 -0000

Thank you for the comments, Roman.

Thank you for your suggestion, Warren.

I prefer Roman's solution because I'd like to keep the 
policy/configuration/scenario part. I think it helps to explain _why_ 
these decisions are out of the scope for this specification.

Best regards,
Karsten

On 27.10.2021 22:10, Warren Parad wrote:
> Would making it even simpler also work? (and is more consistent with 
> the 6749 language)
>
>     The decision of whether to accept such responses is beyond the
>     scope of this specification.
>
>
> 	
>
> Warren Parad
>
> Founder, CTO
>
> Secure your user data with IAM authorization as a service. Implement 
> Authress <https://authress.io/>.
>
>
> On Wed, Oct 27, 2021 at 9:41 PM Roman Danyliw <rdd@cert.org> wrote:
>
>     Hi!
>
>     I performed an AD review of draft-ietf-oauth-iss-auth-resp-02. 
>     Thanks for documenting this mitigation.
>
>     The document is in good shape so I am advancing it to IETF LC. 
>     Please treat these minor comments as part of that feedback:
>
>     ** Section 2.4.  Editorial.
>
>        The decision of whether to accept such
>        responses is individual for every scenario and it is not in the
>     scope
>        of this specification.
>
>     Would it be more clear to say:
>
>     "Local policy or configuration can determine whether to accept
>     such responses and specific guidance is out of scope for this
>     specification."
>
>     There is also similar language in the next paragraph.
>
>     ** Section 5.1 and 5.2.  Per the "Change Control" field, please
>     s/IESG/IETF/
>
>     Thanks,
>     Roman
>
>     _______________________________________________
>     OAuth mailing list
>     OAuth@ietf.org
>     https://www.ietf.org/mailman/listinfo/oauth
>
>
> _______________________________________________
> OAuth mailing list
> OAuth@ietf.org
> https://www.ietf.org/mailman/listinfo/oauth

-- 
Karsten Meyer zu Selhausen
Senior IT Security Consultant
Phone:	+49 (0)234 / 54456499
Web:	https://hackmanit.de  | IT Security Consulting, Penetration Testing, Security Training

Is your OAuth or OpenID Connect application vulnerable to mix-up attacks? Find out more on our blog:
https://www.hackmanit.de/en/blog-en/132-how-to-protect-your-oauth-client-against-mix-up-attacks

Hackmanit GmbH
Universitätsstraße 60 (Exzenterhaus)
44789 Bochum

Registergericht: Amtsgericht Bochum, HRB 14896
Geschäftsführer: Prof. Dr. Jörg Schwenk, Prof. Dr. Juraj Somorovsky, Dr. Christian Mainka, Prof. Dr. Marcus Niemietz