Re: [OAUTH-WG] OAuth Redirection Attacks

Warren Parad <wparad@rhosys.ch> Fri, 17 December 2021 13:00 UTC

Return-Path: <wparad@rhosys.ch>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 793363A0E41 for <oauth@ietfa.amsl.com>; Fri, 17 Dec 2021 05:00:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.088
X-Spam-Level:
X-Spam-Status: No, score=-2.088 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=rhosys.ch
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lEMoK9tnXWjE for <oauth@ietfa.amsl.com>; Fri, 17 Dec 2021 05:00:11 -0800 (PST)
Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 98F833A0E3C for <oauth@ietf.org>; Fri, 17 Dec 2021 05:00:11 -0800 (PST)
Received: by mail-yb1-xb36.google.com with SMTP id d10so6216169ybe.3 for <oauth@ietf.org>; Fri, 17 Dec 2021 05:00:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhosys.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5nW4f0At8oP1PFG7Zc6wCx6D4bLQ1blfDXhvoAaRpEg=; b=WCzx3NxckRoaysS5ZIwgcZ6W2zm+OQQsMTuciC9OzRJA3s3bynRAb/akM9tqKOFo2E vwQHKVHqZZQONPektRI+Yv98pDB43b5syByXIrUZkX44JrgS0TMpU9Jtbxd2GV6xD+KJ ZoqVln12zszEzMQErQTBJwtOdB8ctpl3WOkAdaHbIRyVXHkKdI7jbq6jOi3P9EASBWLG 6Z1aHzAzFfN8jEwpnwe9xr2Ni6rTtCZLjHiGArbIoD/xgG4SqKz/fWwWnzgg0kqRAYVh YIRDDwoxmdKsOkcs9uCrxouCGweRMxRrJFFl9ZmJlOLkzAD1hJLgh166aVR0eZYanyY1 UWuA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5nW4f0At8oP1PFG7Zc6wCx6D4bLQ1blfDXhvoAaRpEg=; b=S5CmGZIbZi4+I0PWRBZ34rKb09Q2/KkYTDQ6oAcbHr9G3YRQe/Wc9rYJDXWGma8FmC vGvRgHx4vjLvpgdfbMKjB5QUkn2REc296zvE31ww9X4ac7Jk82HTHo2co1AjI5Ji1brJ Wk23t7GIcBWDASQbHItGC9rAw1Yh0QsrzwpGemJOcRnpdNDs0kZIFgSJ6hFDygq6+5Cr vk8pZvDnGb1/xFblGtUXfyuPqbUBukIsj9cJCeqnUtUpglFexjlZQF/Tvg1LIYedAmIw h6Ic5zhnr8P7f2NjTXyc76Aj5QiZQrD8GrSk6T9agMCdutkvA5Gj/dy7wYYcRuj/xxKt 3ytQ==
X-Gm-Message-State: AOAM530/SCZxGDTQR8+3nyj8vZE42g1OJ65tXTlsXJWArfMMfTNCv1al qJlgWx7dS2978I99TDx41S2omjXC+gy4CDeg+Dch8sAVq4QE
X-Google-Smtp-Source: ABdhPJzbUH0WiOquSYdgQH9pDL3ZBVaFu2S5siazRlpSiyLfoN2WQB90OvvCpTLR7r04ZB0LjfKl8HeyE6GYGFyMh+8=
X-Received: by 2002:a25:6744:: with SMTP id b65mr3995651ybc.57.1639746007417; Fri, 17 Dec 2021 05:00:07 -0800 (PST)
MIME-Version: 1.0
References: <CADNypP_AJFBc+HzKfFZ8d0hk7BZc=fYTDLNP6MroHUg-=r7FvQ@mail.gmail.com>
In-Reply-To: <CADNypP_AJFBc+HzKfFZ8d0hk7BZc=fYTDLNP6MroHUg-=r7FvQ@mail.gmail.com>
From: Warren Parad <wparad@rhosys.ch>
Date: Fri, 17 Dec 2021 13:59:56 +0100
Message-ID: <CAJot-L2X+Ma5BnXJ6Ys3UPJgHc_WnYtU33ast-myT2PN6rU5OQ@mail.gmail.com>
To: Rifaat Shekh-Yusef <rifaat.s.ietf@gmail.com>
Cc: oauth <oauth@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000004b643805d3571eff"
Archived-At: <https://mailarchive.ietf.org/arch/msg/oauth/mW43K88rSoiY9q9AqSX2utANC1M>
Subject: Re: [OAUTH-WG] OAuth Redirection Attacks
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/oauth/>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Dec 2021 13:00:17 -0000

I think this just falls into the category of never redirect the user to a
url that doesn't match one of the preregistered redirect urls (or logout
urls for that matter). Any application that has redirects anywhere provides
an opportunity for this attack vector, OAuth isn't unique in that way, it
just is consistent and documented. And the 2.1 draft is pretty clear on
this front:

https://datatracker.ietf.org/doc/html/draft-ietf-oauth-v2-1-04#section-4.1.2.1

>    If the request fails due to a missing, invalid, or mismatching
>    redirect URI, or if the client identifier is missing or invalid, the
>    authorization server SHOULD inform the resource owner of the error
>    and
> *MUST NOT automatically redirect the user agent to the invalid   redirect
> URI*.


I want to call this attack vector "*illegitimate* phishing applications"
which is easily blocked by preregistration and/or PARs. And is only a very
small subset of phishing attacks with OAuth, of which the larger group is "
*legitimate* phishing applications". An app can be registered correctly,
and still issue a phishing attack as phishing attacks through OAuth are
actually indistinguishable from standard user delegation. There is no way
to prevent these without an application review before registration is
completed, here's an example that cloned Google apps y creating a fake app
called *google defender*:
https://www.trendmicro.com/en_us/research/17/d/pawn-storm-abuses-open-authentication-advanced-social-engineering-attacks.html

If we can't protect against these latter ones, I hardly think protecting
against the former is useful/interesting/valuable.

Warren Parad

Founder, CTO
Secure your user data with IAM authorization as a service. Implement
Authress <https://authress.io/>.


On Thu, Dec 16, 2021 at 9:05 PM Rifaat Shekh-Yusef <rifaat.s.ietf@gmail.com>
wrote:

> All,
>
>
> An article was recently published discussing some OAuth Redirection
> Attacks to try to bypass phishing detection solutions. See the details of
> these attacks in the following link:
>
>
>
> https://www.proofpoint.com/us/blog/cloud-security/microsoft-and-github-oauth-implementation-vulnerabilities-lead-redirection
>
>
> The article discusses attacks on Microsoft and GitHub, but these attacks
> are not unique to these companies.
>
> The attacks take advantage of how OAuth handles error responses, which
> sends responses to the application’s redirect URL.
>
> I would like to get the thoughts of the working group on these types of
> attacks.
>
> What is the best way to mitigate these attacks?
>
> Do we need a new approach for handling errors with OAuth?
>
> Regards,
>
>  Rifaat
>
> _______________________________________________
> OAuth mailing list
> OAuth@ietf.org
> https://www.ietf.org/mailman/listinfo/oauth
>