Re: [OAUTH-WG] defining new response types

Eran Hammer-Lahav <eran@hueniverse.com> Tue, 12 July 2011 18:11 UTC

Return-Path: <eran@hueniverse.com>
X-Original-To: oauth@ietfa.amsl.com
Delivered-To: oauth@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D795921F8E3A for <oauth@ietfa.amsl.com>; Tue, 12 Jul 2011 11:11:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.318
X-Spam-Level:
X-Spam-Status: No, score=-2.318 tagged_above=-999 required=5 tests=[AWL=-0.319, BAYES_00=-2.599, J_CHICKENPOX_45=0.6]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qoyJX5iBvhm8 for <oauth@ietfa.amsl.com>; Tue, 12 Jul 2011 11:11:18 -0700 (PDT)
Received: from p3plex1out01.prod.phx3.secureserver.net (p3plex1out01.prod.phx3.secureserver.net [72.167.180.17]) by ietfa.amsl.com (Postfix) with SMTP id 5AFA521F8E34 for <oauth@ietf.org>; Tue, 12 Jul 2011 11:11:18 -0700 (PDT)
Received: (qmail 31994 invoked from network); 12 Jul 2011 18:11:18 -0000
Received: from unknown (HELO smtp.ex1.secureserver.net) (72.167.180.19) by p3plex1out01.prod.phx3.secureserver.net with SMTP; 12 Jul 2011 18:11:18 -0000
Received: from P3PW5EX1MB01.EX1.SECURESERVER.NET ([10.6.135.19]) by P3PW5EX1HT001.EX1.SECURESERVER.NET ([72.167.180.19]) with mapi; Tue, 12 Jul 2011 11:10:58 -0700
From: Eran Hammer-Lahav <eran@hueniverse.com>
To: Breno de Medeiros <breno@google.com>
Date: Tue, 12 Jul 2011 11:10:47 -0700
Thread-Topic: [OAUTH-WG] defining new response types
Thread-Index: AcxAvXKWKCSqgNqxSuGTgkyelf++KQAAIDMA
Message-ID: <90C41DD21FB7C64BB94121FBBC2E7234501D4A058C@P3PW5EX1MB01.EX1.SECURESERVER.NET>
References: <CAGdjJpKq=90QhSt68sYbtW9TtW+OR5nxYxTSC1A1jYRA=369tg@mail.gmail.com> <85A6E014-25A0-4970-8741-2F174B20688E@hueniverse.com> <CAAJ++qHek0v=cPcRgWBhku5mftjMEDQzekvjABqynMGBo_p7GQ@mail.gmail.com>
In-Reply-To: <CAAJ++qHek0v=cPcRgWBhku5mftjMEDQzekvjABqynMGBo_p7GQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: OAuth WG <oauth@ietf.org>
Subject: Re: [OAUTH-WG] defining new response types
X-BeenThere: oauth@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: OAUTH WG <oauth.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/oauth>, <mailto:oauth-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/oauth>
List-Post: <mailto:oauth@ietf.org>
List-Help: <mailto:oauth-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/oauth>, <mailto:oauth-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jul 2011 18:11:19 -0000

Requiring parsing of the response type parameter is a big change at this point. Even if it is a decent idea, I'm against it for the sole reason that I don't want to introduce such a change - we're done.

The + character makes reading values easier because it give composites of existing, individually defined values, a special meaning to *people*, but it does not change any existing code or adds any work. Servers will still perform simple string comparison. Parsing a list of values is unnecessary complexity. Developers can learn to put values in their expected order (since they are all going to cut-n-paste anyway).

I rather drop the special character then add parsing, but I think it is a useful *convention*.

Do people want to keep it or drop it?

EHL


> -----Original Message-----
> From: Breno de Medeiros [mailto:breno@google.com]
> Sent: Tuesday, July 12, 2011 10:59 AM
> To: Eran Hammer-Lahav
> Cc: Marius Scurtescu; OAuth WG
> Subject: Re: [OAUTH-WG] defining new response types
> 
> Imposing order and exact string matching on response_type's while
> simultaneously supporting a special character '+' and introducing the concept
> of composite response_type is a poor compromise, IMNSHO. What is the
> rationale to fear allowing multiple-valued response_type as we have for
> other parameters in the spec?
> 
> On Mon, Jul 11, 2011 at 18:51, Eran Hammer-Lahav <eran@hueniverse.com>
> wrote:
> > As for the plus encoding we can choose another char or give an example.
> >
> > On Jul 11, 2011, at 18:07, "Marius Scurtescu" <mscurtescu@google.com>
> wrote:
> >
> >> If I read section 8.4 correctly it seems that new response types can
> >> be defined but composite values must be registered explicitly.
> >>
> >> I don't think this approach scales too well. OpenID Connect for
> >> example is adding a new response type: id_token.
> >>
> >> id_token can be combined with either code or token and potentially
> >> with both of them, the following combinations must be registered as a
> >> result:
> >> code+id_token
> >> token+id_token
> >> code+token+id_token
> >>
> >> and this assumes that code+token is already registered.
> >>
> >> I think it makes more sense to define response_type as a space
> >> separated list of items, where each item can be individually
> >> registered. I do realize that this complicates things quite a bit
> >> (not we have to define and deal with both composite response_type and
> >> the individual items).
> >>
> >> As a side note, using + as separator could cause lots of problems. If
> >> people naively type "code+toke" it will be decoded as "code token".
> >> No one will remember the hex code for +.
> >>
> >> Marius
> >> _______________________________________________
> >> OAuth mailing list
> >> OAuth@ietf.org
> >> https://www.ietf.org/mailman/listinfo/oauth
> >
> 
> 
> 
> --
> --Breno