Re: typo?
hal@rain.org Fri, 23 April 1999 00:19 UTC
Received: from mail.proper.com (mail.proper.com [206.86.127.224]) by ietf.org (8.9.1a/8.9.1a) with ESMTP id UAA00804 for <openpgp-archive@odin.ietf.org>; Thu, 22 Apr 1999 20:19:19 -0400 (EDT)
Received: (from majordomo@localhost) by mail.proper.com (8.8.8/8.8.5) id QAA04051 for ietf-open-pgp-bks; Thu, 22 Apr 1999 16:44:48 -0700 (PDT)
Received: from 226-132.adsl2.avtel.net (226-132.adsl2.avtel.net [207.71.226.132]) by mail.proper.com (8.8.8/8.8.5) with ESMTP id QAA04047 for <ietf-open-pgp@imc.org>; Thu, 22 Apr 1999 16:44:47 -0700 (PDT)
Received: (from hal@localhost) by 226-132.adsl2.avtel.net (8.8.7/8.8.7) id QAA04511; Thu, 22 Apr 1999 16:45:25 -0700
Date: Thu, 22 Apr 1999 16:45:25 -0700
From: hal@rain.org
Message-Id: <199904222345.QAA04511@226-132.adsl2.avtel.net>
To: ietf-open-pgp@imc.org, Noah_Salzman@NAI.com
Subject: Re: typo?
Sender: owner-ietf-open-pgp@imc.org
Precedence: bulk
List-Archive: <http://www.imc.org/ietf-open-pgp/mail-archive/>
List-Unsubscribe: <mailto:ietf-open-pgp-request@imc.org?body=unsubscribe>
Noah - I think that is OK. CRC24_POLY is used in the sample code as:
if (crc & 0x1000000)
crc ^= CRC24_POLY;
So the extra "1" in CRC24_POLY is actually there to clear the "1" in the
crc variable. It might have been clearer to define CRC24_POLY without the
"1" and then to do
if (crc & 0x1000000)
crc ^= CRC24_POLY | 0x1000000;
or even
if (crc & 0x1000000) {
crc &= 0xffffff;
crc ^= CRC24_POLY;
}
but it works out the same.
Hal