Re: [OSPF] draft-ietf-ospf-yang-03 questions and doubts

"Derek Man-Kit Yeung (myeung)" <myeung@cisco.com> Thu, 03 March 2016 21:55 UTC

Return-Path: <myeung@cisco.com>
X-Original-To: ospf@ietfa.amsl.com
Delivered-To: ospf@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5C4581B2C95; Thu, 3 Mar 2016 13:55:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.506
X-Spam-Level:
X-Spam-Status: No, score=-14.506 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RP_MATCHES_RCVD=-0.006, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8DKDCg7MKgsp; Thu, 3 Mar 2016 13:55:06 -0800 (PST)
Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BD93F1B2CA3; Thu, 3 Mar 2016 13:55:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=47974; q=dns/txt; s=iport; t=1457042105; x=1458251705; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=CCEMuuy8fSsNjF0aQONsMy3iJDopkcg+0cEbCrhfzQE=; b=VqaBbB9hkJELMmIutr8AHmZxdUKgDpwVbydY4mTmTRds4ld8YEvXUStb 7td+6vgThoVG7Lea4C26ODk2I7PuR8BJIEZO1YYm2HMK/I8CubPG/BOb8 dlQuY9EDhfAjpsvp0ObThxj4cL1YYo0RhdJH2St9zMwn+hiaq4k7VcU5E k=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0ALAgCFsdhW/5pdJa1TCoJuTFJtBrosAQ2BaoYPAoEyOBQBAQEBAQEBZCeEQQEBAQQtTBACAQgRAwEBASEBBgcyFAkIAQEEAQ0FiCG7DQEBAQEBAQEBAQEBAQEBAQEBAQEBARWGGIQ8hA43ExYChAIFkneEJQGNYoFghESIU4V2iFYBHgEBQoNkaogkfgEBAQ
X-IronPort-AV: E=Sophos; i="5.22,533,1449532800"; d="scan'208,217"; a="79254586"
Received: from rcdn-core-3.cisco.com ([173.37.93.154]) by rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Mar 2016 21:55:04 +0000
Received: from XCH-RCD-009.cisco.com (xch-rcd-009.cisco.com [173.37.102.19]) by rcdn-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id u23Lt4I5013874 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 3 Mar 2016 21:55:04 GMT
Received: from xch-aln-006.cisco.com (173.36.7.16) by XCH-RCD-009.cisco.com (173.37.102.19) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Thu, 3 Mar 2016 15:55:03 -0600
Received: from xch-aln-006.cisco.com ([173.36.7.16]) by XCH-ALN-006.cisco.com ([173.36.7.16]) with mapi id 15.00.1104.009; Thu, 3 Mar 2016 15:55:03 -0600
From: "Derek Man-Kit Yeung (myeung)" <myeung@cisco.com>
To: Alan Davey <Alan.Davey@metaswitch.com>, "draft-ietf-ospf-yang@ietf.org" <draft-ietf-ospf-yang@ietf.org>
Thread-Topic: draft-ietf-ospf-yang-03 questions and doubts
Thread-Index: AdE3NLGjjtMGuql0QfiSt+s9ulh9zgoPjYmAAiVQNuADX5obgA==
Date: Thu, 03 Mar 2016 21:55:03 +0000
Message-ID: <D2FDEE96.7531D%myeung@cisco.com>
References: <C2EE31C852049D499842B19FC01C0804012A72782A@ENFICSMBX1.datcon.co.uk> <D2D8C451.73937%myeung@cisco.com> <CY1PR0201MB1066110895F4C141E7779015F9AF0@CY1PR0201MB1066.namprd02.prod.outlook.com>
In-Reply-To: <CY1PR0201MB1066110895F4C141E7779015F9AF0@CY1PR0201MB1066.namprd02.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/14.6.1.160122
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.154.57.123]
Content-Type: multipart/alternative; boundary="_000_D2FDEE967531Dmyeungciscocom_"
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/ospf/bNyPgjuJ3pEIVl1CP2OSyA-4F90>
Cc: OSPF WG List <ospf@ietf.org>
Subject: Re: [OSPF] draft-ietf-ospf-yang-03 questions and doubts
X-BeenThere: ospf@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: The Official IETF OSPG WG Mailing List <ospf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ospf>, <mailto:ospf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ospf/>
List-Post: <mailto:ospf@ietf.org>
List-Help: <mailto:ospf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ospf>, <mailto:ospf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Mar 2016 21:55:10 -0000

Hi Alan,

Please see DY> below.

From: Alan Davey <Alan.Davey@metaswitch.com<mailto:Alan.Davey@metaswitch.com>>
Date: Thursday, February 18, 2016 at 3:28 AM
To: myeung <myeung@cisco.com<mailto:myeung@cisco.com>>, "draft-ietf-ospf-yang@ietf.org<mailto:draft-ietf-ospf-yang@ietf.org>" <draft-ietf-ospf-yang@ietf.org<mailto:draft-ietf-ospf-yang@ietf.org>>
Cc: OSPF WG List <ospf@ietf.org<mailto:ospf@ietf.org>>
Subject: RE: draft-ietf-ospf-yang-03 questions and doubts

Hi Derek

Thank you for your response, and apologies for the delay in getting back to you.  Have you considered distinct ospfv3-interface-operation and ospfv2-interface-operation?  Or even distinct “container ospfv2” and “container ospfv3”?

DY> No, we do not plan to have explicit ospfv2 and ospfv3 container. We used when statement or if-feature to take care of OSPFv2 vs OSPFv3 specific fields in general.

There are a number of differences between the Interface Data Structure defined in RFC2328 and in RFC5340.  In particular, the following.  Do you plan to add all of these differences to the interface-operation grouping?


-          DR and BDR identification.

o   As you wrote, section 9 of RFC2328 specifies that the Interface Data Structure includes the Router ID and IP address for the DR and BDR.

o   Section 4.1.2 of RFC5340 does not specify how to identify the DR and BDR, but given the OSPFv3 protocol, it seems reasonable that the router ID and interface ID would be stored.

DY> In OSPFv3, the DR/BDR is still identified by a router ID. The interface ID of the DR is used when generating LSA and by itself do not identify the DR/BDR.
DY> Given the DR/BDR router ID/ip address, one can locate the corresponding neighbor information and find the interface ID there.
DY> So we are not going the duplicate the interface ID of the DR in the interface container again.


-          Section 4.1.2 of RFC5340 specifies a number of objects that do not appear in the RFC2328 version of the Interface Data Structure, as follows.

o   Interface ID.

o   Instance ID.

DY> The two above will be added. It is missing now. To be clear. It is the interface ID of the local router, not the one of the DR,  for the interface.


o   List of LSAs with link-local scope.

DY> The model already have link-local LSA database.


o   List of IPv6 prefixes configured for the attached link.


DY> Understood that it is mentioned in the OSPFv3 RFC.
DY> However, looking at a few implementations there is no explicit display of such information with the interface related OSPF show command.
DY> The IPv6 prefixes (or IPv4 prefix in OSPFv2) advertised by the router could be found already either from the interface module (IPv4/IPv6 augment) or from the LSA database itself.
DY> Extracting it again in OSPF model interface operation data seems redundant.
DY> We don’t think we need it in the base model, but vendors could augment it if they find it useful.

Thanks,
- Derek

Regards
Alan

From: Derek Man-Kit Yeung (myeung) [mailto:myeung@cisco.com]
Sent: 04 February 2016 19:39
To: Alan Davey <Alan.Davey@metaswitch.com<mailto:Alan.Davey@metaswitch.com>>; draft-ietf-ospf-yang@ietf.org<mailto:draft-ietf-ospf-yang@ietf.org>
Cc: ospf@ietf.org<mailto:ospf@ietf.org>
Subject: Re: draft-ietf-ospf-yang-03 questions and doubts

Hi Alan,

Thanks for the comments.
As you have pointed out, there are OSPFv3 specific fields missing in the model now. For example, instance ID and interface ID. We will add them in the next update.

As for the DR, DR is conceptually one of the neighbor.
In OSPFv2, the DR's router ID and IP address are used in protocol operation.
While in OSPFv3, the DR's router ID and interface ID are used in protocol operation.
According to OSPFv2 and OSPFv3 RFC, the interface structure should keep both the DR's router ID and IP address.

We have the following in the current model.

  grouping interface-operation {
    leaf dr {
      type inet:ipv4-address;
      description "Designated Router (DR) IP address.";
    }
  }
  grouping neighbor-operation {
    leaf dr {
      type yang:dotted-quad;
      description
        "Designated Router.";
    }
  }

To better match the RFC and accommodate both OSPFv2 and OSPFv3 in a cleaner way, we plan to make the following changes.

  grouping interface-operation {
    leaf dr-router-id {
      type yang:dotted-quad;
      description
        "Designated Router (DR) router ID.";
    }
    leaf dr-ip-address {
      type inet:ip-address;
      description "Designated Router (DR) IP address.";
    }
  }
  grouping neighbor-operation {
    leaf dr-router-id {
      type yang:dotted-quad;
      description
        "Neighbor's Designated Router (DR) router ID.";
    }
    leaf dr-ip-address {
      type inet:ip-address;
      description "Neighbor's Designated Router (DR) IP address.";
    }
  }

If one need the DR's interface ID in the OSPFv3 case, it could be found by locating the neighbor entry for the DR and get the interface ID (To be added) field there.

Comments welcome.

Thanks,
- Derek

From: Alan Davey <Alan.Davey@metaswitch.com<mailto:Alan.Davey@metaswitch.com>>
Date: Tuesday, December 15, 2015 8:23 AM
To: "draft-ietf-ospf-yang@ietf.org<mailto:draft-ietf-ospf-yang@ietf.org>" <draft-ietf-ospf-yang@ietf.org<mailto:draft-ietf-ospf-yang@ietf.org>>
Cc: "ospf@ietf.org<mailto:ospf@ietf.org>" <ospf@ietf.org<mailto:ospf@ietf.org>>
Subject: draft-ietf-ospf-yang-03 questions and doubts

Folks

I have a doubt about draft-ietf-ospf-yang-03.  Please let me know your thoughts on the following.

The text is OSPFv2-specific in places.  I think that it would be better to define separate top-level groupings and containers for OSPFv2 and OSPFv3 and define common groupings and containers, where possible, that are used by both.

For example, grouping interface-operation contains the following, which is incorrect for OSPFv3.


-          leaf dr with type ipv4-address

-          leaf bdr with type ipv4-address.

I think that it would be better to define something along the following lines.


-          ospfv3-interface-operation {

o   uses interface-config

o   uses ospf-common-interface-operation

o   leaf dr {

§  type if:interface-ref

§  description:

·                   "The remote interface ID used by the Designated Router on

·                   this link.  This is the interface index of the interface local to the DR.";

o   etc

-          ospfv2-interface-operation {

o   uses interface-config

o   uses ospf-common-interface-operation

o   leaf dr {

§           type inet:ipv4-address;

§           description "Designated Router (DR) IP address.";

o   etc.

Regards
Alan Davey