Re: [Pals] Benoit Claise's No Objection on draft-ietf-pals-status-reduction-04: (with COMMENT)
Luca Martini <lmartini@monoski.com> Thu, 11 May 2017 01:05 UTC
Return-Path: <lmartini@monoski.com>
X-Original-To: pals@ietfa.amsl.com
Delivered-To: pals@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 079EA12949A; Wed, 10 May 2017 18:05:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.891
X-Spam-Level:
X-Spam-Status: No, score=-1.891 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-0.001, T_SPF_PERMERROR=0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k3pKi4aoOPVj; Wed, 10 May 2017 18:05:29 -0700 (PDT)
Received: from napoleon.monoski.com (napoleon.monoski.com [70.90.113.113]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F12A512EAE2; Wed, 10 May 2017 18:05:22 -0700 (PDT)
Received: from confusion.monoski.com (confusion.monoski.com [209.245.27.2]) (authenticated bits=0) by napoleon.monoski.com (8.14.7/8.14.7) with ESMTP id v4B15K3t021025 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 10 May 2017 19:05:20 -0600 (MDT)
To: Benoit Claise <bclaise@cisco.com>, The IESG <iesg@ietf.org>
References: <149183417336.3169.4090650965570837178.idtracker@ietfa.amsl.com>
Cc: draft-ietf-pals-status-reduction@ietf.org, Stewart Bryant <stewart.bryant@gmail.com>, pals-chairs@ietf.org, pals@ietf.org, j.schoenwaelder@jacobs-university.de
From: Luca Martini <lmartini@monoski.com>
Organization: Monoski
Message-ID: <5913B8CA.1090601@monoski.com>
Date: Wed, 10 May 2017 19:05:14 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <149183417336.3169.4090650965570837178.idtracker@ietfa.amsl.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/pals/21osczkuNLEldCMj01n8V9B6uSE>
Subject: Re: [Pals] Benoit Claise's No Objection on draft-ietf-pals-status-reduction-04: (with COMMENT)
X-BeenThere: pals@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Pseudowire And LDP-enabled Services dicussion list." <pals.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pals>, <mailto:pals-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pals/>
List-Post: <mailto:pals@ietf.org>
List-Help: <mailto:pals-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pals>, <mailto:pals-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 May 2017 01:05:31 -0000
Benoit, Comments inline Thanks. Luca On 04/10/17 08:22, Benoit Claise wrote: > Benoit Claise has entered the following ballot position for > draft-ietf-pals-status-reduction-04: No Objection > > When responding, please keep the subject line intact and reply to all > email addresses included in the To and CC lines. (Feel free to cut this > introductory paragraph, however.) > > > Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html > for more information about IESG DISCUSS and COMMENT positions. > > > The document, along with other ballot positions, can be found here: > https://datatracker.ietf.org/doc/draft-ietf-pals-status-reduction/ > > > > ---------------------------------------------------------------------- > COMMENT: > ---------------------------------------------------------------------- > > As mentioned by Jürgen in his OPS-DIR review: > > Section 1.2 is not really about terminology but instead it basically > expands acronyms. The section does not define any terms or does it > make it clear where terms are defined. A reader who does not know > T-PE > will not be pointed to a document that defines 'Terminating Provider > Edge Node of MS-PW'. I usally find terminology sections more useful > if > they say where definitions of terms get be found. > > Section 3: s/the the/the/ > > Section 4: What is the 'Version' field in the message format? as the text says : explained in [RFC5586] > Section 4: There is an 8-bit field marked U C Flags and I _assume_ > the > U and C bits are the 'first' two bits and the 'remaining bits are the > flags managed by IANA. Perhaps make this clearer, e.g.: > > +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > | Last Received Seq Number | Message Type |U|C| Flags | > +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ yes - the ascii art was incorrect. > Or alternatively simply name the entire 8-bit flags field like you do > in the text where you refer to Message Flags and then explain in the > text under the 'Message Flags' that the first two bits have a fixed > meaning. > > +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > | Last Received Seq Number | Message Type | Message Flags | > +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > > This option carries less information but then you use 'Message Flags' > in several places and you also request an IANA registry for Message > Flags where the U and C bit are allocated. Looking at the IANA text, > it says 'bit position' 0 and 1. Not sure this is clear enough, you > seem to number bits in the order 0, 1, 2, ... > > It turns out we have several slightly different labels further down > in > the document for this flags field throughout the document - this > makes > searching in the text difficult, please use a single consistent name > for this message field. > Yes! thanks for catching this. We suffer from multiple editor syndrome ;-) > Section 8.2 says values 1 and 2 are defined in this document but then > it seems value 3 is also allocated, no? yes - fixed. > Subsections of section 8 switches several times between decimal and > hexadecimal numbers. Perhaps things get clearer if a single number > system (e.g., hexadecimal) is used when talking about a specific > registry. Numbers like 134,217,728 look somewhat confusing, 0x8000000 > seems simpler. > > I would have kept it all in hexadecimal format , but somehow I think someone asked for the text to be decimal. IANA already processed this , so I would like to leave it as is. Thanks. Luca
- [Pals] Benoit Claise's No Objection on draft-ietf… Benoit Claise
- Re: [Pals] Benoit Claise's No Objection on draft-… Luca Martini