[payload] Review of draft-ietf-payload-melpe-04

Carlos Pignataro <cpignata@gmail.com> Mon, 26 December 2016 02:12 UTC

Return-Path: <cpignata@gmail.com>
X-Original-To: payload@ietf.org
Delivered-To: payload@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 7149F129521; Sun, 25 Dec 2016 18:12:31 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Carlos Pignataro <cpignata@gmail.com>
To: ops-dir@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.40.3
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <148271835146.28347.7596373310873834703.idtracker@ietfa.amsl.com>
Date: Sun, 25 Dec 2016 18:12:31 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/payload/MQ9tBRzpZkI7BA2DlCVYJA62zfo>
Cc: draft-ietf-payload-melpe.all@ietf.org, iesg@ietf.org, payload@ietf.org
Subject: [payload] Review of draft-ietf-payload-melpe-04
X-BeenThere: payload@ietf.org
X-Mailman-Version: 2.1.17
List-Id: Audio/Video Transport Payloads working group discussion list <payload.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/payload>, <mailto:payload-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/payload/>
List-Post: <mailto:payload@ietf.org>
List-Help: <mailto:payload-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/payload>, <mailto:payload-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Dec 2016 02:12:31 -0000

Reviewer: Carlos Pignataro
Review result: Has Nits

Hi,

This document is mostly ready but has some potential issues:

1. Normative statements -- there are a number of "recommended" and
"shall" among "RECOMMENDED" and "SHALL". It would not hurt to revise
and confirm the normative level of each of these.

Specifically, a couple of these relate to one operational aspect of
Default values:
E.g.:
          Note: The default value shall be the respective parameters
          from the vocoder frame.  It is recommended that msvq[0] and
          gain[1] values be derived by averaging the respective
          parameter from some number of previous vocoder frames.

Should thouse be normative / uppercase as per its operational
implications?

2. References

It is not entirely clear to me that the references are adequately
split in Normative vs. Informative.

I understand these three for example are not produced by the IETF; but
are they necessary to understand the spec?

   [MELP] Department of Defense Telecommunications Standard,
"Analog-to-
   Digital Conversion of Voice by 2,400 Bit/Second Mixed Excitation
   Linear Prediction (MELP)", MIL-STD-3005, December 1999.

   [MELPE] North Atlantic Treaty Organization (NATO), "The 600 Bit/S,
   1200 Bit/S and 2400 Bit/S NATO Interoperable Narrow Band Voice
   Coder", STANAG No. 4591, January 2006.

   [SCIP210] National Security Agency, "SCIP Signaling Plan",
SCIP-210,
   December 2007.

Also, sure, a google search can find them (I believe), but is there an
authoritative pointer (URI) where these can be normatively found?

Thanks,

-- Carlos.