Re: [payload] TSVART telechat review of draft-ietf-payload-flexible-fec-scheme-16

Bernard Aboba <bernard.aboba@gmail.com> Mon, 11 February 2019 21:39 UTC

Return-Path: <bernard.aboba@gmail.com>
X-Original-To: payload@ietfa.amsl.com
Delivered-To: payload@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5D869126C15; Mon, 11 Feb 2019 13:39:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NA1c_QUkFeIn; Mon, 11 Feb 2019 13:39:29 -0800 (PST)
Received: from mail-vs1-xe2e.google.com (mail-vs1-xe2e.google.com [IPv6:2607:f8b0:4864:20::e2e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4925F126C01; Mon, 11 Feb 2019 13:39:29 -0800 (PST)
Received: by mail-vs1-xe2e.google.com with SMTP id z18so281312vso.7; Mon, 11 Feb 2019 13:39:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KJeJNqPSYAhL6P4LQ7BrKrLiG4SVY5bxHcGWTsfyXfk=; b=lsySUUtpZwyLjgoPWQTFPSd75aAFyXtF2XVa+lLNAn7YO2Jjb5SnSkTQCaI4Jj+6kI ooTK0B6+YNRItMh8V7m8PjvwpEuHNmWACoIc1aMiZEd07qIJwjNXPmYqN0ewlrd5VUoz XH6pFRvRf7UZ6ylGVVtNioARjSLsABMDrKt6MHX5+jPi5Rz3QTDaNOIZKG/TfK5iY5Zu 90Roc2dvlQdt8laucVOqlIryKFj9/+t4bvedRfbbHCRhorWP6V03VC+GXmPaEFLUnj/Y DQyouyyDerptyg/IZ51MxCHXdgqE39CJ6frrRCXUSZafAwjoyaiAMsayo/plGSwS6kCM Zeww==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KJeJNqPSYAhL6P4LQ7BrKrLiG4SVY5bxHcGWTsfyXfk=; b=bqUzzxMnTSLHZBF2lErOoEozrt0rcFPevHY6X5MNM71lV02TFSAOEdLzaGYEzQ6RZH B05YRQ14Vf0R57myhSx4U/VHl/GniyQVmBiaTrkaOPMPV2F6dvmYPwPYrveHEVdPxlzf M0ZNuJ3dEN5LySbO069YAtT+pRQIiJfMieJRMsmqYLCSJ41zD0ltfacwtJnPJgvGtmG4 AUEo0Dgs4aKLiM0rek6nvn3c2XjFY4TF5eH7G/caedfvBOKxL8zM3794ZHIXNZw9Dsyf kV5mC0X2fHA/MjNGEkR0MloOdcVr/fsraP+I3hxaEAQJCITg2qkwXy1xGQCFw/Zn5O+x yxSg==
X-Gm-Message-State: AHQUAuaZAgGDuGAzX8b5XNW7GghRcUw5J93YC4EXq1c5srMcZoItboCE J/3dlMk8ZT/o5vSMo6z6/7V6ijhfMeWEtbaC9uA=
X-Google-Smtp-Source: AHgI3IYkHva5qhWAseymXeNOq5mKog0Gy35N1eGoZLGAtHa2Q9F/K6ChqTDxkS05Ux2fM70Q+Usq+IjcqgRD9X668jo=
X-Received: by 2002:a67:fd8b:: with SMTP id k11mr157351vsq.226.1549921167533; Mon, 11 Feb 2019 13:39:27 -0800 (PST)
MIME-Version: 1.0
References: <ad4d8e52739045149b72c882732801f5@NASANEXM01C.na.qualcomm.com>
In-Reply-To: <ad4d8e52739045149b72c882732801f5@NASANEXM01C.na.qualcomm.com>
From: Bernard Aboba <bernard.aboba@gmail.com>
Date: Mon, 11 Feb 2019 13:39:16 -0800
Message-ID: <CAOW+2dvNfVyMiR7=GBQzHFVzz9LcNt6DdL_yBH543rLhHRSxLg@mail.gmail.com>
To: Giridhar Mandyam <mandyam@qti.qualcomm.com>
Cc: "payload@ietf.org" <payload@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-payload-flexible-fec-scheme@ietf.org" <draft-ietf-payload-flexible-fec-scheme@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000009eed630581a524e6"
Archived-At: <https://mailarchive.ietf.org/arch/msg/payload/n9H1VG3f2uMI3lfpOVHq6pApb5M>
Subject: Re: [payload] TSVART telechat review of draft-ietf-payload-flexible-fec-scheme-16
X-BeenThere: payload@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Audio/Video Transport Payloads working group discussion list <payload.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/payload>, <mailto:payload-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/payload/>
List-Post: <mailto:payload@ietf.org>
List-Help: <mailto:payload-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/payload>, <mailto:payload-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Feb 2019 21:39:34 -0000

1. " Suggested additional section (new 1.1.5):"

[BA] Thank you.  This looks good.

"It is not possible to configure a ToP value that allows the sender to send
both FEC and rtx, and all valid values for ToP are listed in the spec.
This is what is meant by the current text under ToP for each type
registration:   “There can only be one value listed for ToP.”  An offer
that attempts to list multiple ToP values must be rejected. We can add the
clarifying sentence:  “An offer that lists more than one ToP value MUST be
rejected.”

[BA] The "MUST be rejected" clarification seems helpful.  If ToP is not
contained in the Offer (as shown in the Example in Section 7.1.1), Section
5.1.4 says:

      The absence of the ToP field means that all protection types are
      allowed.


So by not including a ToP value in the Offer, it would be possible to
use flexfec for both FEC and retransmission, correct?


BTW, if no ToP value is provided in the Offer, does the ToP value in
the Answer determine what is used?  And if there is no ToP value in
the Answer, then anything is ok?


2. RTX and flexfec retransmission.

"If by RTX you mean the use of RTP RTX for retransmission of repair
packets, then this is not prohibited by the spec but is not a configuration
that the editors anticipate will be widely-used."

[BA] Agree that it makes little sense to negotiate both conventional RTX
and flexfec retransmission, but I wanted to understand how the negotiation
would work in a scenario where the Offerer did not know whether the
Answerer supported flexfec and therefore offered both RTX and flexfec (with
no ToP value).

Can the Answerer assume that not including ToP means that the Offerer
supports flexfec retransmission and well as forward error correction?

Assuming that the Answerer would prefer to use flexfec retransmission
instead of conventional RTX and that it didn't want FEC, would the Answerer
then respond with ToP indicating a desire for flexfec retransmission (and
no RTX, so that conventional retransmission is turned off)?

3. Flexible mode.

"If L and D are not specified in the SDP, then the sender will utilize a
flexible mask (assuming rtx is not selected)."

[BA] If neither Offer nor Answer contain ToP for retransmission, does that
count as "rtx is not selected"?  Or is it necessary to explicitly select
ToP for forward error correction so as to rule out retransmission?

"Implementations are not required to support all F/R combinations as there
may be implementations limitations depending on the repair window offered
(e.g. insufficient buffer space).  The answerer can indicate lack of
support through rejection using the methodology described in
https://tools.ietf.org/html/rfc3264#section-6."

[BA] If L and D are not specified in the SDP offer, is that considered an
indication that the Offerer can both send and receive flexible mask?  Is
the presence of L and D an indication that it does not support flexible
mask?



On Mon, Feb 11, 2019 at 11:02 AM Giridhar Mandyam <mandyam@qti.qualcomm.com>
wrote:

>
>
>
>
> Thank you for the careful review.  Enclosed are proposed responses.
>
>
>
> > For example, the sender could use flexible mode to only protect base
> layer packets by using a flexible mask to select only packets sent with TID
> = 0 and SID = 0.  Since with flexible mode the mask is not negotiated and
> thus can be varied on the fly, it would appear to me that differential
> protection can be provided even in situations where the number of layers
> encoded (and even the temporal/spatial encoding mode) vary on the fly.
>
>
>
> > If this interpretation is correct, I would suggest adding a section
> after 1.1.4 covering the flexible mask mode and a differential protection
> use case for it.  It also would appear to me that flexible mode could be
> used to implement dynamic FEC, but I'll leave it to the authors to decide
> whether to mention that use case.
>
>
>
> Suggested additional section (new 1.1.5):
>
>
>
> 1.1.5 FEC Protection with Flexible Mask
>
>
>
> It is possible to define FEC protection for selected packets in the source
> stream.  This would enable differential protection, i.e. application of FEC
> selectively to packets that require a higher level of reliability then the
> other packets in the source stream.  The sender will be required to send a
> bitmap indicating the packets to be protected, i.e. a “mask”, to the
> receiver.  Since the mask can be modified during an RTP session (“flexible
> mask”), this kind of FEC protection can also be used to implement FEC
> dynamically (e.g. for adaptation to different types of traffic during the
> RTP session).
>
>
>
> >With respect to SDP parameters (L, D, ToP) defined in Section 5.1.1, I
> was unclear on several points:
>
> >1. Is it possible to configure a ToP value to indicate that the sender
> desires to utilize both FEC and retransmission?  Or must the sender choose
> to utilize this payload for one or the other but not both?
>
>
>
> It is not possible to configure a ToP value that allows the sender to send both FEC and rtx, and all valid values for ToP are listed in the spec.  This is what is meant by the current text under ToP for each type registration:   “There can only be one value listed for ToP.”  An offer that attempts to list multiple ToP values must be rejected. We can add the clarifying sentence:  “An offer that lists more than one ToP value MUST be rejected.”
>
>
>
> >2. What happens if both RTX and flexible FEC with retransmission are
> Offered in SDP?  Could this result in the sender being allowed to send both
> types of retransmission (though presumably only one at a time)?  Are the
> type(s) of retransmission used determined by which retransmission schemes
> are provided in the Answer?
>
>
>
> We assume by RTX you mean the RTP RTX option, but specifically for source packets.  It is possible to offer RTP RTX and FLEX FEC in an offer.  An example of when such an offer is appropriate is if the FLEX FEC RTX fails to recover the packet, and RTP RTX is required to recover the packet for a given application that requires a corresponding level of reliability.  If by RTX you mean the use of RTP RTX for retransmission of repair packets, then this is not prohibited by the spec but is not a configuration that the editors anticipate will be widely-used.
>
>
>
> >3. If L and D are not specified, does this imply that the sender will
> operate in flexible mode?  Are implementations of the specification
> required to support all of the modes except for the F=1, R=1 mode that is
> forbidden?  If not, how does an Answerer indicate that it doesn't support
> the mode that is Offered?
>
>
>
> If L and D are not specified in the SDP, then the sender will utilize a flexible mask (assuming rtx is not selected).  Implementations are not required to support all F/R combinations as there may be implementations limitations depending on the repair window offered (e.g. insufficient buffer space).  The answerer can indicate lack of support through rejection using the methodology described in https://tools.ietf.org/html/rfc3264#section-6.
>
>
>
> >4. Does the negotiation of L, D and ToP in SDP imply that the sender
> cannot switch to use of another configuration without renegotiation?  Since
> the flexible FEC format is self-describing, it would appear to me that
> switching should be possible as long as the implementation requirements are
> clear.  For example, do all implementations needs to support all mask
> sizes?
>
>
>
> Switching without re-negotiation may not be possible unless the sender is aware of the capabilities of the receiver e.g. through out-of-band information.  If the sender does not have full information on receiver capabilities, then re-negotiation may be necessary as per the procedures of  https://tools.ietf.org/html/rfc3264#section-8.
>
>
>
> *From:* Bernard Aboba <bernard.aboba@gmail.com>
> *Sent:* Sunday, February 3, 2019 7:30 PM
> *To:* tsv-art@ietf.org
> *Cc:* payload@ietf.org; IETF discussion list <ietf@ietf.org>;
> draft-ietf-payload-flexible-fec-scheme@ietf.org
> *Subject:* TSVART telechat review of
> draft-ietf-payload-flexible-fec-scheme-16
>
>
>
> Reviewer:  Bernard Aboba
>
> Review result:  Needs clarifications
>
>
>
> This document has been reviewed as part of the transport area review team's
> ongoing effort to review key IETF documents. These comments were written
> primarily for the transport area directors, but are copied to the
> document's
> authors and WG to allow them to address any issues raised and also to the
> IETF discussion list for information.
>
> When done at the time of IETF Last Call, the authors should consider this
> review as part of the last-call comments they receive. Please always CC
> tsv-art@ietf.org if you reply to or forward this review.
>
> Document: draft-ietf-payload-flexible-fec-scheme-16
>
>
>
> My reading of the document raised questions relating to implementation
> requirements as well as the configuration and use of the Flexible Mask mode
> (R=0, F=0).  Presumably, this mode can be used to choose arbitrary packets
> to protect. There is not much discussion of flexible mode early in the
> document, and no use cases are presented relating to this mode.  However,
> it would appear to me that flexible mode can be used to implement scenarios
> such as differential protection for Scalable Video Coding.
>
>
>
> For example, the sender could use flexible mode to only protect base layer
> packets by using a flexible mask to select only packets sent with TID = 0
> and SID = 0.  Since with flexible mode the mask is not negotiated and thus
> can be varied on the fly, it would appear to me that differential
> protection can be provided even in situations where the number of layers
> encoded (and even the temporal/spatial encoding mode) vary on the fly.
>
>
>
> If this interpretation is correct, I would suggest adding a section after
> 1.1.4 covering the flexible mask mode and a differential protection use
> case for it.
>
> It also would appear to me that flexible mode could be used to implement
> dynamic FEC, but I'll leave it to the authors to decide whether to mention
> that use case.
>
>
>
> With respect to SDP parameters (L, D, ToP) defined in Section 5.1.1, I was
> unclear on several points:
>
>
>
> 1. Is it possible to configure a ToP value to indicate that the sender
> desires to utilize both FEC and retransmission?  Or must the sender choose
> to utilize this payload for one or the other but not both?
>
>
>
> 2. What happens if both RTX and flexible FEC with retransmission are
> Offered in SDP?  Could this result in the sender being allowed to send both
> types of retransmission (though presumably only one at a time)?  Are the
> type(s) of retransmission used determined by which retransmission schemes
> are provided in the Answer?
>
>
>
> 3. If L and D are not specified, does this imply that the sender will
> operate in flexible mode?  Are implementations of the specification
> required to support all of the modes except for the F=1, R=1 mode that is
> forbidden?  If not, how does an Answerer indicate that it doesn't support
> the mode that is Offered?
>
>
>
> 4. Does the negotiation of L, D and ToP in SDP imply that the sender
> cannot switch to use of another configuration without renegotiation?  Since
> the flexible FEC format is self-describing, it would appear to me that
> switching should be possible as long as the implementation requirements are
> clear.  For example, do all implementations needs to support all mask
> sizes?
>
>
>
>
>
>