Re: [Pce] RtgDir review: draft-ietf-pce-stateful-hpce

Dhruv Dhody <dhruv.ietf@gmail.com> Mon, 08 July 2019 03:56 UTC

Return-Path: <dhruv.ietf@gmail.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3C3691200D6; Sun, 7 Jul 2019 20:56:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.703
X-Spam-Level:
X-Spam-Status: No, score=-0.703 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, PDS_NO_HELO_DNS=1.295, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sPZT1fdYdGLt; Sun, 7 Jul 2019 20:56:12 -0700 (PDT)
Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7DC1F1200F7; Sun, 7 Jul 2019 20:56:12 -0700 (PDT)
Received: by mail-io1-xd34.google.com with SMTP id u19so31957376ior.9; Sun, 07 Jul 2019 20:56:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=aUMDbXtOn1GCLZbh9xESV/MCTrRJt1EzC+k547/Ca24=; b=D8mkxgOpe8bxw9uLJ1DxpINxuwlbRi80v6MAvEclDz143uiVQs3gxorqwiNo4sdai5 S7sn8t4bLd5gnuoE9E5Ujq/KoNnrh5qSJaBlEzyEvyHZ9+nS2HtQHdiRDSz0ENC96wC5 grkoqtsJsMfBPddSRPm0zXdFd9VZh1gIMP460aNBH6z4DUNpkwzVLAiYV/rAjka0yo+Z EP0HilAw9jMZv2bOj+Nf3U/iaZx45TGW6uiMHIB4/NGcmEAdmSkb6lr5eGnI+1XO+S9m uoqIESJs38ckqKYhwP/TPT7yCC8c/ocofNjKlayP8jTqKrZvul7gQ6pL3lFuRwxdoWDb YPgg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=aUMDbXtOn1GCLZbh9xESV/MCTrRJt1EzC+k547/Ca24=; b=OFxqbBP3Pu1OnM0ejKt8jBSyPcaXeyx2EEHr2+xPUVl5MH/ElMvvo7k7UJmd2+PU/P 3JQ2i0enIosi78iyI1Es7+fjaaERIpFlCd1pE7IE5aIVFqS69OWWPZM7wvpkk9NTkiH/ 5nDmLbUAj3H3LeGfGBmbxYcoXAE9BSYD5ofmYmBDo3iiOsqSbJEjOcsbLK2Wul2tk0qi CGbtQMQacBCVkxq2N1zxFhyh9iquXciqnPdJNVoK//O+ZsjvpVuP5gsY7Yctf6KZvg8u UbgnPG+bWCqrVHqnHJNfIOzo5AAifuWgA+IgILtky+hZV5q+XyLtqCfRyBP+pN/n8wax MCug==
X-Gm-Message-State: APjAAAXMmftFdSsgdkH+o3F8L30PZi09A/ZEG3LKZSxhNJMptMk1sfbo e+1/89K7PWSEwzi60092KO5Au2YK1o32a21kT5U=
X-Google-Smtp-Source: APXvYqwX/3GeG4gdtNOvOGFb1PM5Xd4cH0P2Fpq2bz+qTs+WvcQQHNx4AaCEP4c1lzH2i/mtejNLYX1XU3N0hXbi3U8=
X-Received: by 2002:a6b:c98c:: with SMTP id z134mr12054498iof.276.1562558171499; Sun, 07 Jul 2019 20:56:11 -0700 (PDT)
MIME-Version: 1.0
References: <CABUE3X=1PZHnVvm=Xm4wwi8B72aCa5wu+E4T-2Xc9P66U9FFgQ@mail.gmail.com>
In-Reply-To: <CABUE3X=1PZHnVvm=Xm4wwi8B72aCa5wu+E4T-2Xc9P66U9FFgQ@mail.gmail.com>
From: Dhruv Dhody <dhruv.ietf@gmail.com>
Date: Mon, 08 Jul 2019 09:25:35 +0530
Message-ID: <CAB75xn4jaD726U+CimQiYLyr8U73doU0RadWDZ1ts-np2x6fbQ@mail.gmail.com>
To: Tal Mizrahi <tal.mizrahi.phd@gmail.com>
Cc: draft-ietf-pce-stateful-hpce@ietf.org, "<rtg-ads@ietf.org>" <rtg-ads@ietf.org>, rtg-dir@ietf.org, pce@ietf.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/0MowPEHex2-cSpe4ix9JG6XGZUo>
Subject: Re: [Pce] RtgDir review: draft-ietf-pce-stateful-hpce
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jul 2019 03:56:14 -0000

Hi Tal,

Thanks for your review.

I have made an update handling the nits.

A diff from the previous version is available at:
https://www.ietf.org/rfcdiff?url2=draft-ietf-pce-stateful-hpce-11

Thanks!
Dhruv

On Sun, Jul 7, 2019 at 1:05 PM Tal Mizrahi <tal.mizrahi.phd@gmail.com> wrote:
>
> Hello,
>
> I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir
>
> Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.
>
> Document: draft-ietf-pce-stateful-hpce
> Reviewer: Tal Mizrahi
> Review Date: July, 2019
> Intended Status: Informational
>
> Summary:
> No issues found. This document is ready for publication.
>
> Nits:
> -Section 1.1. is the only subsection of Section 1. Please consider adding a subsection "Background" that will consist of the text before the current 1.1.
> -"(previously computed paths" - there is no matching ")"
> -Section 6.3 - please consider if this should be moved to the security considerations section, or add a reference from the security considerations section to this one.
>
> Best regards,
> Tal.