[Pce] Shepherd review of draft-ietf-pce-lsp-extended-flags-02

Dhruv Dhody <dd@dhruvdhody.com> Tue, 07 June 2022 07:32 UTC

Return-Path: <dd@dhruvdhody.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 660E0C15AAE5 for <pce@ietfa.amsl.com>; Tue, 7 Jun 2022 00:32:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.907
X-Spam-Level:
X-Spam-Status: No, score=-6.907 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=dhruvdhody-com.20210112.gappssmtp.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Kg1pFBCFkTbu for <pce@ietfa.amsl.com>; Tue, 7 Jun 2022 00:31:55 -0700 (PDT)
Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D5008C15AAE1 for <pce@ietf.org>; Tue, 7 Jun 2022 00:31:55 -0700 (PDT)
Received: by mail-pl1-x630.google.com with SMTP id b5so14105604plx.10 for <pce@ietf.org>; Tue, 07 Jun 2022 00:31:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dhruvdhody-com.20210112.gappssmtp.com; s=20210112; h=mime-version:from:date:message-id:subject:to:cc; bh=6Ihd0Eh12vL4+KUMatsK28Xx4JSQdrYI+oXmsXTTyFM=; b=CW5A3tZN5ptys9JJfHaRcCUl8hyhw2j6vLzOTuSNBqVd4M7N2jgEp1AB55eCHB2Mqz 6lQXmVFhCy3RkxozszTRX5UmQEIqp8sanCoqXV9V8Zl2hogD5orBld3uIrovzx/Q5u6S Wud0uutJv1SdyXAiAz1iVWDlh3S4H+AYcLgs3TPAdRimwRsdopoIqi01/0IsJooHTjtA OP7OmTs0Mmdb3wKx0KvZizWJZCChfwaKCQMivL8Ff09GYYEyOhWZxT+uXp2pvhHbPf0m ARDf0AfAW6TJ3Fot42bV83lbTyW1d1+f9tNFcupDeC0mPNypPQ2AAy086l7+7hx+qMXU SeSw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=6Ihd0Eh12vL4+KUMatsK28Xx4JSQdrYI+oXmsXTTyFM=; b=ksJLL9o5O3IysrZayS5g86rcZN5L10h48NetC/bVN+r/8/6yOx7EMxYWGzCG8TovK+ LOqF02tR4EK1uT6QD2qdYfzL2sz0ZIu6plctzWIe9J+WvCZg6/+VUmoyabjjDG0DN27l sns1yWTo8kZcURrCDYOcPJXynPuHya+lZAgTAS4bS0n5HqtaCG7mV6+i/SstroRpFF1o MlF6Dljir44bib52J11IEMsHJCyHgzFtxbXch1EIBJSosgg1I8my/MqVrRMKxaNSF4Dp hU2Z8ZW02Ri7qU3r+UtTyTn6Lb3g1y2S2FCXDqA/5hTu9ZJAJQa2OxJHrPVHiycoDV1I visQ==
X-Gm-Message-State: AOAM53251dupcahCVOHxMsDBp1rCsBSQasQ5k+VlQ6rOg0dnBvjIoOUr yYpppH3ESXdWeC+f4OqR3heydylOMX/14zTHZC4DGFZ0UnfwkSel
X-Google-Smtp-Source: ABdhPJyq4iXMUevpoueEEGt1jJ6kDPNKJVJrX9paKj4QfbuoljARaf0xjgG70Kwa6XCmnKEANA+feeKZKh+5XEs4zus=
X-Received: by 2002:a17:90b:3e85:b0:1e8:8f2f:bd2f with SMTP id rj5-20020a17090b3e8500b001e88f2fbd2fmr7424175pjb.120.1654587114696; Tue, 07 Jun 2022 00:31:54 -0700 (PDT)
MIME-Version: 1.0
From: Dhruv Dhody <dd@dhruvdhody.com>
Date: Tue, 07 Jun 2022 13:01:18 +0530
Message-ID: <CAP7zK5ZHfQzsroLLvhE17YBZfhX2iFRBE8ZHdMznL2MKakRg3g@mail.gmail.com>
To: pce@ietf.org
Cc: Quan Xiong <xiong.quan@zte.com.cn>
Content-Type: multipart/alternative; boundary="00000000000038c83f05e0d6956a"
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/58t8YsTDs_gHiJhbKlrd1QSfZvI>
Subject: [Pce] Shepherd review of draft-ietf-pce-lsp-extended-flags-02
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Jun 2022 07:32:00 -0000

Hi WG,

I have finished the Shepherd review of
draft-ietf-pce-lsp-extended-flags-02. Please find my comments. Once these
are resolved we will be sending the I-D to IESG for publication.

* Date: 7 June 2022
* Reviewer: Dhruv Dhody

## Minor
* Abstract should not have references. Replace all [RFCNNNN] with RFC NNNN.
Also for the I-D add a note to RFC Editor "Replace
I-D.ietf-pce-binding-label-sid to RFC XXXX, once the RFC number is
assigned."

* Add a Management Considerations Section
````
Management Considerations

   Implementations receiving set LSP Extended Flags that they do not
   recognize MAY log this.  That could be helpful for diagnosing
   backward compatibility issues with future features that utilize those
   flags.

````

* Small update to Security Consideration Section
````
OLD:
   For LSP Object procssing security considerations, see [RFC8231].

   No additional security issues are raised in this document beyond
   those that exist in the referenced documents.
NEW:
   [RFC8231] sets out security considerations for PCEP when used for
   communication with a stateful PCE.  This document does not change
   those considerations.  For LSP Object processing, see [RFC8231].

   This document provides for future extension of PCEP.  No additional
   security issues are raised in this document beyond those that exist
   in the referenced documents.
````

* Please add this to the appendix to capture the WG LC discussion
````
Appendix A.  WG Discussion

   The WG discussed the idea of a fixed length (with 32 bits) for LSP-
   EXTENDED-FLAG TLV.  Though 32 bits would be sufficient for quite a
   while, the use of variable length with a multiple of 32-bits allows
   for future extensibility where we would never run out of flags and
   there would not be a need to define yet another TLV in the future.
   Further, note that [RFC5088] and [RFC5089] use the same approach for
   the PCE-CAP-FLAGS Sub-TLV and are found to be useful.
````

## Nits
* Title: s/LSP/Label Switched Path (LSP)/
* s/syncronization/synchronization/
* s/procssing/processing/

Thanks!
Dhruv