[Pce] RtgDir Early review: draft-ietf-pce-pceps-tls13-02

Tal Mizrahi <tal.mizrahi.phd@gmail.com> Mon, 13 November 2023 09:07 UTC

Return-Path: <tal.mizrahi.phd@gmail.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D4AB8C14CE2E; Mon, 13 Nov 2023 01:07:33 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.106
X-Spam-Level:
X-Spam-Status: No, score=-7.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FZKbLbLRlJwh; Mon, 13 Nov 2023 01:07:31 -0800 (PST)
Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B1C99C14CE27; Mon, 13 Nov 2023 01:07:28 -0800 (PST)
Received: by mail-io1-xd36.google.com with SMTP id ca18e2360f4ac-7aff7bf7dafso24856539f.0; Mon, 13 Nov 2023 01:07:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699866447; x=1700471247; darn=ietf.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cyEIXMdQisZetn4PH1f6D4WJ1wMm/GOfqreE7ZwXb2E=; b=cu5i3HO5nMROwhfO6HhzP1zDYHxL7T28Fqf4oKVp866pDV+H3xCQMSYYhxwJs0fIbo LHNKs2HOnNLwzcVDAyCyaGWsnR9Xiv9Ovt12ScA1bSlY4F1JZmvcpLgF5mnEEaB9Cst9 d279Cw0USureT9iRjaHhvN6qNSLX7xOuQb1fYZLSkyzsenj3/J05XTXlq/YtVDN/VOR1 4AAp3esfvNyXlNQwiYRv5AZW4bU+H+L1TVnH9j3rVylBgFn/onb/oX/0q+bmSxC+8/ge 7BUWqLpM2IkaAL2DimmSCMf11+0Gjz+dksP0e3xga4dU+dnSkBXDZw08khUh6bLiFtQj bLmw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699866447; x=1700471247; h=content-transfer-encoding:cc:to:subject:message-id:date:from :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cyEIXMdQisZetn4PH1f6D4WJ1wMm/GOfqreE7ZwXb2E=; b=R3wWz5qRqGpfxVFavYtzbyn48+SilNbNstYmmMIDGyZtPS0KWmHxWOvnUjHevzZy+N g14KtPsWCuUjuuRZj5jDiq509IJCVXhNiskskhNeE8Tbphm07D0rNG7M2Mw4zwGvE3PF bkZh3sblLnpfgmXvZtl+WAQB6ZUc2Ii6Sn7jrxWxlSU06Xy6SKDeaKbnGYsmbmsyGm0D WBosBNA6QZIa8rDPe17Y6fvQdU2dwsea46fU09adXyje4y/QozNDrM/BK2WaJkHiNx5c ei4vhjKbL6pEEzHXm8f7qiIHalPaTi+mHg72ksQtFe/dvGROrNOV+8ruPUGx1lW2Z+jj NBPg==
X-Gm-Message-State: AOJu0YxJnN5FiFg8wBn3SHkTP354tuAZ3wfFUZnwiJl6ydP4r8/Kz69J 0RagT77o093tss2hI4HT59coNYEu+wZeqOavNj37F1v2A7/Ttw==
X-Google-Smtp-Source: AGHT+IGXKx4aulDhDP1+Y1zIvF1srSJVSWYxq61cAcwQs+Qsm5cFv4L9JzPqUO71zc52H68z4eMjayXV15dElvFyFns=
X-Received: by 2002:a05:6602:164a:b0:7a6:a005:4984 with SMTP id y10-20020a056602164a00b007a6a0054984mr5760006iow.1.1699866447490; Mon, 13 Nov 2023 01:07:27 -0800 (PST)
MIME-Version: 1.0
From: Tal Mizrahi <tal.mizrahi.phd@gmail.com>
Date: Mon, 13 Nov 2023 11:07:05 +0200
Message-ID: <CABUE3X=_nKNrfFsmdjB=9VAgODyubWZU58NVQSc8HxY=QBJmDA@mail.gmail.com>
To: draft-ietf-pce-pceps-tls13@ietf.org, pce@ietf.org, pce-chairs@ietf.org
Cc: rtg-dir@ietf.org, pce-ads@ietf.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/89wFXA3Uf-VZ0GpW7G-Ggr3pmZM>
Subject: [Pce] RtgDir Early review: draft-ietf-pce-pceps-tls13-02
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Nov 2023 09:07:33 -0000

Hello

I have been selected to do a routing directorate “early” review of this draft.
https://datatracker.ietf.org/doc/draft-ietf-pce-pceps-tls13/

The routing directorate will, on request from the working group chair,
perform an “early” review of a draft before it is submitted for
publication to the IESG. The early review can be performed at any time
during the draft’s lifetime as a working group document.

For more information about the Routing Directorate, please see
https://wiki.ietf.org/en/group/rtg/RtgDir

Document: draft-ietf-pce-pceps-tls13-02
Reviewer: Tal Mizrahi
Review Date: Nov 13, 2023
Intended Status: Standards Track

Summary:
I have some concerns about this document that I think should be
resolved before it is submitted to the IESG.

Comments:
The draft is clear and straightforward. There is one main comment that
needs to be addressed.

Major comment:
The "Security Considerations" section needs to describe the security
considerations that are specific to the current document. For example,
the second note of Section 3, and perhaps some more text that explains
why this is important. The existing text in this section is not
helpful to the reader. The section cites 9 references with a brief
description of each reference, but without the description of the
security considerations of each reference. The last paragraph of the
section - is it relevant to the current document? It would be best to
stick with security considerations that are strictly relevant to the
current document, and not to PCE in general.

Nits:
- "if a PCEPS supports more than one version" - the sentence is not
clear. Perhaps "if a PCEPS implementation supports more than one
version"?
- Section 4 - second paragraph - there is a missing period at the end
of the paragraph.