Re: [Pce] RtgDir review: draft-ietf-pce-stateful-pce-p2mp-10.txt
Dhruv Dhody <dhruv.ietf@gmail.com> Tue, 19 February 2019 15:05 UTC
Return-Path: <dhruv.ietf@gmail.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6421712870E; Tue, 19 Feb 2019 07:05:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lhHO405X5k3f; Tue, 19 Feb 2019 07:05:26 -0800 (PST)
Received: from mail-it1-x12e.google.com (mail-it1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 94D651295EC; Tue, 19 Feb 2019 07:05:25 -0800 (PST)
Received: by mail-it1-x12e.google.com with SMTP id d125so3171081ith.1; Tue, 19 Feb 2019 07:05:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0Jjv9NkUWS3I7+uPtsbAkC74hdL+aQT95SZjXPDex0E=; b=IgLtZZeK6B+m+M+T7SCdmDOu0SC+HuBIfEX/Ii7zILvzGkKyn3Xqje6aI9G9U1KDdR FOtKMTo7fwokfwDYADG00bDjDrs0k7IQzdCvQ3/XJ2cWJfaOgLVELVBfUpFGW8wUIqA3 Z26eTp6722+n1DFr33jgpfLn9VddAstIPQB1qNw3qty5d0f0HEbHfnyq6tx+Zr36MejC B1Lad47BNYSEmothbQ9vU9sWK2RL/VSvGSqgpDufzKNQuxdioEYUT4IbRTuYClQGSkKf nef5Os950wEE0OrRCGkNFCnxDTvLRtwFZKhpeqfGgTYWvrZk1inVoIMTtlPCuChGH9BS j2hg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0Jjv9NkUWS3I7+uPtsbAkC74hdL+aQT95SZjXPDex0E=; b=KB4JS9i6d8QJI1Rt9Piu73OWSDANLkPc+2udX2GnLQcMHiRBCSnoruuiACDVoV8OQd 8t/pirrM1tjAmIaKjur9EIOjieYj0CKNf7VotCjkzAIlQzRiR53pgPkkeLiW8EmAWT1b MM8x5IVlmbn5OSchAosiU2IpnIUrpN0o3TDMDA0y80yulM0VSvp39Ri2W76jeqjJlYKT MKlDFND6HK+zRKm51tW5dhf8IhQwOvQ4CATAB7bXnFUWQbbvnXUwEn9pTP6/AOHlv8Qa PsgNd038XNbs13NFR/RXbTvRUgQ/bq7YpypbxKLARAwo856aoYMZYgqnIkEHErSbG2S/ 0mMg==
X-Gm-Message-State: AHQUAuZ3zio5HZAcpYG0kuwIChXZ6seEwydDVNo0xZ1qGJ0adEHuwH4U Q4vqyl7ZG9EmTuYSozsrpY2Wt+8eU/HEpK8kZq4=
X-Google-Smtp-Source: AHgI3IbrolJOjao4DRlpxZyZ8/mraIjH5DLfhfk4OH5eU+l4G9FWWFd+dEVkA92M9vcWHphSwYiD9CmTa4Ii6ed5USU=
X-Received: by 2002:a24:74d1:: with SMTP id o200mr2419041itc.95.1550588724595; Tue, 19 Feb 2019 07:05:24 -0800 (PST)
MIME-Version: 1.0
References: <CAA=duU0tv-q5BRg3nudfnao-DYwf2YVLcERGZBvjp+X2tBv38A@mail.gmail.com> <23CE718903A838468A8B325B80962F9B8D9532D7@BLREML503-MBX.china.huawei.com> <CAA=duU0_mbAbx=yjAJJ-BWtgyAqqhNC=fX7=ik_noAu8KKxkNQ@mail.gmail.com>
In-Reply-To: <CAA=duU0_mbAbx=yjAJJ-BWtgyAqqhNC=fX7=ik_noAu8KKxkNQ@mail.gmail.com>
From: Dhruv Dhody <dhruv.ietf@gmail.com>
Date: Tue, 19 Feb 2019 20:34:47 +0530
Message-ID: <CAB75xn5oQeafPhGUUL4Lgrff3ACLfRywoy_k0PN1HSX8Qeq0yQ@mail.gmail.com>
To: "Andrew G. Malis" <agmalis@gmail.com>
Cc: Dhruv Dhody <dhruv.dhody@huawei.com>, "<rtg-ads@ietf.org>" <rtg-ads@ietf.org>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "pce@ietf.org" <pce@ietf.org>, "draft-ietf-pce-stateful-pce-p2mp.all@ietf.org" <draft-ietf-pce-stateful-pce-p2mp.all@ietf.org>
Content-Type: multipart/related; boundary="0000000000001fe51105824092f5"
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/BKYhfiTepxiGAQ5jq5WGa5nEvYg>
Subject: Re: [Pce] RtgDir review: draft-ietf-pce-stateful-pce-p2mp-10.txt
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Feb 2019 15:05:29 -0000
Oops, I did overlook those two comments. Must be because of identical 7 & 9; making me thing as I was at 9 while i was working on 7. Apologies, will post an update SOON. Thanks! Dhruv On Tue, Feb 19, 2019 at 6:27 PM Andrew G. Malis <agmalis@gmail.com> wrote: > Dhruv, > > That was quick! :-) All looks good except you missed two comments: > > 8. Section 6.5, first paragraph: In the second line, replace the comma > with a period and capitalize the following "this". > > 9. Section 6.5, last paragraph: A right ")" is missing at the end of the > paragraph. > > Thanks, > Andy > > > On Tue, Feb 19, 2019 at 12:15 AM Dhruv Dhody <dhruv.dhody@huawei.com> > wrote: > >> Hi Andy, >> >> >> >> Thanks for your review. Your comments are incorporated in the -11 >> version. >> >> >> >> The IETF datatracker status page for this draft is: >> >> https://datatracker.ietf.org/doc/draft-ietf-pce-stateful-pce-p2mp/ >> >> >> >> A diff from the previous version is available at: >> >> https://www.ietf.org/rfcdiff?url2=draft-ietf-pce-stateful-pce-p2mp-11 >> >> >> >> Regards, >> >> Dhruv >> >> >> >> >> >> >> >> Dhruv Dhody >> >> Lead Architect >> >> Network Business Line >> >> Huawei Technologies India Pvt. Ltd. >> >> Survey No. 37, Next to EPIP Area, Kundalahalli, Whitefield >> >> Bengaluru, Karnataka - 560066 >> >> Tel: + 91-80-49160700 Ext 71583 II Email: dhruv.dhody@huawei.com >> >> [image: Huawei-small] >> >> This e-mail and its attachments contain confidential information from >> HUAWEI, which >> is intended only for the person or entity whose address is listed above. >> Any use of the >> information contained herein in any way (including, but not limited to, >> total or partial >> disclosure, reproduction, or dissemination) by persons other than the >> intended >> recipient(s) is prohibited. If you receive this e-mail in error, please >> notify the sender by >> phone or email immediately and delete it! >> >> >> >> *From:* Pce [mailto:pce-bounces@ietf.org] *On Behalf Of *Andrew G. Malis >> *Sent:* 19 February 2019 02:34 >> *To:* <rtg-ads@ietf.org> <rtg-ads@ietf.org> >> *Cc:* rtg-dir@ietf.org; pce@ietf.org; >> draft-ietf-pce-stateful-pce-p2mp.all@ietf.org >> *Subject:* [Pce] RtgDir review: draft-ietf-pce-stateful-pce-p2mp-10.txt >> >> >> >> Hello, >> >> I have been selected as the Routing Directorate reviewer for this draft. >> The Routing Directorate seeks to review all routing or routing-related >> drafts as they pass through IETF last call and IESG review, and sometimes >> on special request. The purpose of the review is to provide assistance to >> the Routing ADs. For more information about the Routing Directorate, please >> see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir >> >> Although these comments are primarily for the use of the Routing ADs, it >> would be helpful if you could consider them along with any other IETF Last >> Call comments that you receive, and strive to resolve them through >> discussion or by updating the draft. >> >> Document: draft-ietf-pce-stateful-pce-p2mp-10.txt >> Reviewer: Andy Malis >> Review Date: 18 February 2019 >> IETF LC End Date: N/A (in preparation for IETF LC) >> Intended Status: Standards Track >> >> Summary: >> >> This document is basically ready for publication, but has nits that >> should be considered prior to publication. >> >> Comments: >> >> It was very easy to follow the draft. Excellent work by all involved. >> >> Major issues: >> >> No major issues found. >> >> Minor Issues: >> >> No minor issues found. >> >> Nits: >> >> 1. Section 3..1, second paragraph: >> >> Replace: >> For P2MP this is an added advantage, where the size of message is much >> larger. >> >> With: >> For P2MP, where the size of message is much larger, this is an added >> advantage. >> >> 2. Section 5.1, fifth paragraph: >> >> Replace: >> Path Computation LSP Initiate Message (PCInitiate): is a PCEP >> >> With: >> Path Computation LSP Initiate Message (PCInitiate): PCInitiate is a PCEP >> >> 3. Section 5.2, first paragraph: >> >> Replace: >> PCEP speakers advertise Stateful capability via STATEFUL-PCE-CAPABILITY >> TLV in open message. >> >> With: >> PCEP speakers advertise Stateful capability via the >> STATEFUL-PCE-CAPABILITY TLV in the OPEN object. >> >> 4. Section 5.2, third paragraph (N Flag): In two places, replace >> "changes" with "change". >> >> 5.. Section 5.3, first paragraph: Expand "LSR" (Label Switching Router) >> on first use. It's not on the RFC Editor's list of well-known acronyms. >> >> 6. Section 5.3, second paragraph: Expand "PCED" (PCE Discovery TLV) on >> first use. >> >> 7. Section 6.2, last paragraph: A right ")" is missing at the end of the >> paragraph. >> >> 8. Section 6.5, first paragraph: In the second line, replace the comma >> with a period and capitalize the following "this". >> >> 9. Section 6.5, last paragraph: A right ")" is missing at the end of the >> paragraph. >> >> 10. Section 8, second paragraph: Add the word "The" to the start of the >> paragraph. >> >> 11. Section 11.2, first paragraph. Change "and a registry was created" to >> "and the STATEFUL-PCE-CAPABILITY TLV Flag Field subregistry was created" >> >> 12. Section 11.3, first paragraph: Change "and a registry was created" to >> "and the LSP Object Flag Field subregistry was created" >> >> Regards, >> Andy >> >> >> >
- [Pce] RtgDir review: draft-ietf-pce-stateful-pce-… Andrew G. Malis
- Re: [Pce] RtgDir review: draft-ietf-pce-stateful-… Adrian Farrel
- Re: [Pce] RtgDir review: draft-ietf-pce-stateful-… Dhruv Dhody
- Re: [Pce] RtgDir review: draft-ietf-pce-stateful-… Andrew G. Malis
- Re: [Pce] RtgDir review: draft-ietf-pce-stateful-… Dhruv Dhody