Re: [Pce] PCE WG Last Call on draft-ietf-pce-pcep-domain-sequence-07

"Adrian Farrel" <adrian@olddog.co.uk> Sat, 25 April 2015 16:48 UTC

Return-Path: <adrian@olddog.co.uk>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 189E91AC3E9 for <pce@ietfa.amsl.com>; Sat, 25 Apr 2015 09:48:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.6
X-Spam-Level:
X-Spam-Status: No, score=-102.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, USER_IN_WHITELIST=-100] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w-5B10WyyTOr for <pce@ietfa.amsl.com>; Sat, 25 Apr 2015 09:48:15 -0700 (PDT)
Received: from asmtp2.iomartmail.com (asmtp2.iomartmail.com [62.128.201.249]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1D6C61AC3E2 for <pce@ietf.org>; Sat, 25 Apr 2015 09:48:14 -0700 (PDT)
Received: from asmtp2.iomartmail.com (localhost.localdomain [127.0.0.1]) by asmtp2.iomartmail.com (8.13.8/8.13.8) with ESMTP id t3PGm9Ga002741; Sat, 25 Apr 2015 17:48:09 +0100
Received: from 950129200 (dsl-sp-81-140-15-32.in-addr.broadbandscope.com [81.140.15.32]) (authenticated bits=0) by asmtp2.iomartmail.com (8.13.8/8.13.8) with ESMTP id t3PGm7Rw002726 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Sat, 25 Apr 2015 17:48:08 +0100
From: Adrian Farrel <adrian@olddog.co.uk>
To: 'Dhruv Dhody' <dhruv.dhody@huawei.com>
References: <19334_1429116183_552E9517_19334_4447_1_552E950C.10801@orange.com> <01e401d07dfd$80411090$80c331b0$@olddog.co.uk> <23CE718903A838468A8B325B80962F9B870A3044@BLREML509-MBX.china.huawei.com>
In-Reply-To: <23CE718903A838468A8B325B80962F9B870A3044@BLREML509-MBX.china.huawei.com>
Date: Sat, 25 Apr 2015 17:48:06 +0100
Message-ID: <009401d07f77$9b822da0$d28688e0$@olddog.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQGGXJvzVbNd21k+ZQ9QbRmvineAHAFkEyl+AbEY2z+d2YP3cA==
Content-Language: en-gb
X-TM-AS-MML: disable
X-TM-AS-Product-Ver: IMSS-7.1.0.1576-7.5.0.1018-21504.001
X-TM-AS-Result: No--30.102-10.0-31-10
X-imss-scan-details: No--30.102-10.0-31-10
X-TMASE-MatchedRID: qsaWi0FWcYunykMun0J1wlu4M/xm4KZeZijLrBI/sgXCPXSO232P7/eJ lqUEMxA/TRWki2jxCEvCR4lJDv6fyAp2iRVeF6F2uIwLnB3Aqp0iActr2yXJYqq9wgXVNwtgCcz agDATtZ5XBUaDtOU5+JugENX8lwpLJol1F8fRTeVwUSK4/EeOxTHrq78zLkBXVCdU5v5PcvEsh+ oVaienEKycqv33pJgwabz+e+nJh8WB3AuymGAHRLFPpfdetAtTI6PHNDZGGCIY0A95tjAn+60aB JoMRQ7sNXpurRK+uFgLG/i7auLRSYN1fMRjFu73Q1OcCEvT+begD0t7xcmluqPajWJ+xWRuQl3n yP3v0/aKamAvJOmj3Vr5vjYTGkaIsznIV04I19EOrlBkQa9qFtSqEluSYtV7vUH685+Sr6Qk60p W1WU0CkMfeadxmJnP5uxxxxIslOUM0+A2uk9QHRdL2A0SA/nKCmo4ilaIoak2JxgqT664EpAobk v+z74SFUjp56BQ3BkbMDAfm7T5qHWVmJhxqhmIIyvp1AQXH8sjEiRIc8RrvcXt25YNeIUSJIPWj 7k/UvXuQKHBgDjETxJvH5W8oqSx0OkqhlyOBwOhUwhgQVjpv1+PJNkR/r/XmyiLZetSf8nJ4y0w P1A6AKTygpcqFEs8jaPj0W1qn0SQZS2ujCtcuA==
Archived-At: <http://mailarchive.ietf.org/arch/msg/pce/EuJEF7lwRyiIpiq-Lw41HQtiBWY>
Cc: pce@ietf.org
Subject: Re: [Pce] PCE WG Last Call on draft-ietf-pce-pcep-domain-sequence-07
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: adrian@olddog.co.uk
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Apr 2015 16:48:17 -0000

Thanks for the work, Dhruv,

Many snips...

> > It seems to me that the text here treats the domain sequence as a separate
> > thing rather than just some new IRO subobjects that can be included in a
> > PCReq. This shows in some of my comments below. Perhaps you need some
> > more words to explain how to interleave the normal subobjects with the new
> > ones.
> 
> I see, once the I-D was suggesting a new IRO type but that is not the case
now. I
> have added some text to clarify this.
> Please check and let me know if further changes are needed.

I skimmed the new text in 3.4 and elsewhere in the document. You seem to have
addressed my concern, but I haven't checked the details of the ordering and
interpretation of the subobjects.

> > It is fine that this is an experimental document, but I do wonder: what the
> > experiment is

[snip]

> I have added a section -
> 
> 1.1.  Scope
> 
>    The procedures described in this document are experimental.  The
>    experiment is intended to enable research for the usage of Domain-
>    Sequence at the PCEs for inter-domain paths.  For this purpose this
>    document specify new domain subobjects as well as how they
>    incorporate with existing subobjects to represent a Domain-Sequence.
> 
>    This document does not change the procedures for handling existing
>    subobjects in PCEP.
> 
>    When the result of implementation and deployment are available, this
>    document will be updated and refined, and then be moved from
>    Experimental to Standard Track.

I like this.

Maybe also...

The new subobjects introduced by this document will not be understood by legacy
implementations. If one of the subobjects is received in a PCEP object that does
not understand it, it will behave as described in Section 3.4.3. Therefore, it
is assumed that this experiment will be conducted only when both the PCE and PCC
form part of the experiment. It is possible that a PCC or PCE can operate with
peers some of which form part of the experiment and some that do not. In this
case, since no capabilities exchange is used to identify which nodes can use
these extensions, manual configuration should be used to determine which
peerings form part of the experiment.

> > I question the inclusion of the word "shortest" in the Abstract, and I don't
> > find it repeated in the Introduction where I looked to find a citation that
> > indicated that it is a "key requirement".

[snip]
 
> I hear you, but RFC5441 does use the term "shortest constrained path".
> I can either -
> - leave as it is, as there is precedence.
> - add text in Introduction, with reference to RFC5441.
> - remove "shortest" as suggested above.

I don't feel strongly enough to guide you. Any of these three will be enough for
me.

[snip]

> > In 3.4.1.2, I don't understand why you need two sub-object types. You could
> > certainly handle the encoding within the same sub-object so you are
> > presumably worried about distinguishing between an OSPF area ID and an IS-IS
> > area ID. I suppose that there is a faint chance that one AS is running two
> > IGPs at once and the administrator has decided to give the same ID to two
> > areas, one from each IGP. Is that what you're worried about?
> 
> Since the format of the area ID are different in the two routing protocols; as
well
> as we already have different TLV for OSPF and ISIS area-id in RSVP-TE in
RFC4920,
> we feel that this is a better encoding option.

OK. Leave it.

> > 3.4.1.2 gives [ISO10589] as a reference for the definition of an area ID. It
> > surprised me that we don't have an IETF reference for this. Can you check
> > with the chairs of the ISIS WG that this is the right reference.
> 
> [ISO10589] is also republished as RFC 1142 (historic). I can use that instead,
but
> even RFC5089 uses the [ISO] reference. Anyways I will shoot a mail to WG
chairs
> to get a confirmation.

Saw the email. Whatever they say will close this issue.

[snip]

> > Figure 3 is "interesting". Aren't AS interconnects always provided in Area
0,
> > or am I embarrassing myself?
> 
> It usually is, I have added text to re-iterate that the figure is for
illustrative
> purpose only and the usual convention is for AS interconnects to Area 0.
> Other option is to remove this example altogether.

Yeah, perhaps remove it, or replace it with an example of a multi-AS network?

Thanks again,
Adrian