IETF Logo Mail Archive

Re: [Pce] Chair's pre-adoption review of draft-leedhody-pce-vn-association-07

Young Lee <leeyoung@futurewei.com> Wed, 19 June 2019 14:12 UTC

Return-Path: <leeyoung@futurewei.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CB2DA1205D0; Wed, 19 Jun 2019 07:12:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.402
X-Spam-Level:
X-Spam-Status: No, score=0.402 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.999, HTML_COMMENT_SAVED_URL=1.391, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_HTML_ATTACH=0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=futurewei.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9pLNzk2gXvf2; Wed, 19 Jun 2019 07:12:26 -0700 (PDT)
Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-eopbgr770110.outbound.protection.outlook.com [40.107.77.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F13BB1205CC; Wed, 19 Jun 2019 07:12:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Futurewei.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V60EL5pLzTEnxI4AgNkvM3qtSO4Fv6bA5MG2jBuSSWE=; b=IMRbsZmSSb2xHINa4LPIsUiWt9KIK6PIyT73543f8EXhlbmQuWoXnmjEPLuo2njJmUUbdgFkjfaRx+WDPpPV0JiyBK/egxbK0voKT9KoTMREJfL8uE+zWS5nJpI+nIBHtpmU7fQpV28S3yg0umiDmdR37Brmy0UJ3BzPF3LrREo=
Received: from CH2PR13MB3383.namprd13.prod.outlook.com (52.132.244.145) by CH2PR13MB3480.namprd13.prod.outlook.com (52.132.245.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2008.9; Wed, 19 Jun 2019 14:12:24 +0000
Received: from CH2PR13MB3383.namprd13.prod.outlook.com ([fe80::f015:81e4:dfa9:f61]) by CH2PR13MB3383.namprd13.prod.outlook.com ([fe80::f015:81e4:dfa9:f61%2]) with mapi id 15.20.2008.007; Wed, 19 Jun 2019 14:12:24 +0000
From: Young Lee <leeyoung@futurewei.com>
To: "adrian@olddog.co.uk" <adrian@olddog.co.uk>, "draft-leedhody-pce-vn-association@ietf.org" <draft-leedhody-pce-vn-association@ietf.org>
CC: 'pce-chairs' <pce-chairs@ietf.org>, "pce@ietf.org" <pce@ietf.org>
Thread-Topic: Chair's pre-adoption review of draft-leedhody-pce-vn-association-07
Thread-Index: AdUmGfvljK613jfZQOCdMN67am3I5gAjnjXQ
Date: Wed, 19 Jun 2019 14:12:23 +0000
Message-ID: <CH2PR13MB3383FEACC632819ADA5B2A18CDE50@CH2PR13MB3383.namprd13.prod.outlook.com>
References: <000e01d5261a$6377f9f0$2a67edd0$@olddog.co.uk>
In-Reply-To: <000e01d5261a$6377f9f0$2a67edd0$@olddog.co.uk>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=leeyoung@futurewei.com;
x-originating-ip: [12.111.81.80]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 148762ec-60cd-484f-7c01-08d6f4c026ce
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(49563074)(7193020); SRVR:CH2PR13MB3480;
x-ms-traffictypediagnostic: CH2PR13MB3480:
x-ms-exchange-purlcount: 11
x-microsoft-antispam-prvs: <CH2PR13MB348043A4AFA649DE533668E5CDE50@CH2PR13MB3480.namprd13.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 0073BFEF03
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(366004)(376002)(346002)(39840400004)(136003)(189003)(15374003)(199004)(13464003)(7736002)(53936002)(73956011)(8676002)(25786009)(86362001)(99936001)(66066001)(6506007)(110136005)(53546011)(8936002)(81156014)(81166006)(74316002)(99286004)(4326008)(316002)(478600001)(54906003)(186003)(14454004)(102836004)(52536014)(6116002)(2501003)(76116006)(76176011)(229853002)(486006)(305945005)(3846002)(6246003)(6436002)(26005)(71190400001)(7696005)(66446008)(5024004)(2906002)(66556008)(64756008)(5660300002)(55016002)(9686003)(256004)(66946007)(68736007)(66476007)(446003)(11346002)(66576008)(33656002)(71200400001)(476003); DIR:OUT; SFP:1102; SCL:1; SRVR:CH2PR13MB3480; H:CH2PR13MB3383.namprd13.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: futurewei.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 6m8SddRsgFkR+J4ETsXCUMVUt3iMuKp9uWXrK49UCnEmPT2x0nFCkgYaPm6hyQbMuFHvmpjnB4YKhaBQEirVK+kJYSm6nlpd/s3QgU7qFraGnkF+ILF7M3uh2vO6rYwavlGfBJ8Vxga8Tcpk9U5eQzoAX4hZn2LCG1LCX9vSNKuc5u5uNGeKBP3DwJonvWXJM9U+w2CL2ms6GFjVgPBcm2oBwcvzmZc3KKXKidHHlwdqzG79N/FEvbFD7xcUTOyaj90rV4GgjqOnSMx0bMmJ55fcTBCRXX5uH7BBwquHJ3+hbpH4OqG4zzzkuBMKVkiDu+fzTSiLwzQ4/0FOKDqYjg+u7MoVuakjRZntN/pawIabrBC61m3QovP07mjmoSkFLTawI3Tw9rzMDT6SjMj7XskHViwmOi7t0Pj4RUQPr58=
Content-Type: multipart/mixed; boundary="_003_CH2PR13MB3383FEACC632819ADA5B2A18CDE50CH2PR13MB3383namp_"
MIME-Version: 1.0
X-OriginatorOrg: Futurewei.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 148762ec-60cd-484f-7c01-08d6f4c026ce
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jun 2019 14:12:24.0229 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0fee8ff2-a3b2-4018-9c75-3a1d5591fedc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ylee@futurewei.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR13MB3480
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/IqYCs38ajtdWXLBbN7IZS41kiO0>
Subject: Re: [Pce] Chair's pre-adoption review of draft-leedhody-pce-vn-association-07
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Jun 2019 14:12:31 -0000

Hi Adrian, 

Thanks for your review and paying attention to this draft. All your comments are agreed and as such the proposed revision has incorporated your comments. Please see the proposed revision and the diff file attached. If you have any question on the revision, please let us know.

I will upload the draft shortly. 

Thanks.
Young

-----Original Message-----
From: Adrian Farrel [mailto:adrian@olddog.co.uk] 
Sent: Tuesday, June 18, 2019 4:11 PM
To: draft-leedhody-pce-vn-association@ietf.org
Cc: 'pce-chairs' <pce-chairs@ietf.org>; pce@ietf.org
Subject: Chair's pre-adoption review of draft-leedhody-pce-vn-association-07

Hi,

Since you indicated that you thought your draft was ready for adoption by the working group, I have done a quick review. I realise that this is work in progress and does not need to be perfect or even complete at this stage, so I have tried to just pick out some points to tidy up the document so that an adoption poll will be a bit smoother.

Thanks,

Adrian

====

The Table of Contents seems to be out of date.

---

It would be really helpful if you could include an Implementation Status section consistent with the working group policy. If you have nothing to report then just simply report that you have nothing to report.

---

Section 3 has
   An LSP MUST belong to a single VNAG.

I think you probably mean...
   An LSP MUST NOT belong to more than one VNAG.

---

The figure at the top of page 6 seems to be about explaining VNs, but you probably don't need to do that in this document.

---

Section 4

   The VIRTUAL-NETWORK-TLV MUST be included in VNAG object.

I think the "VNAG object" is an Association Object with the Association Type set to "VNAG".

---

Section 6

Could you think about the implications of the VN name being in clear text.

v2.23.0 | Report a Bug | By Email