Re: [Pce] AD review of draft-ietf-pce-pcep-mib

"Adrian Farrel" <adrian@olddog.co.uk> Wed, 20 August 2014 09:42 UTC

Return-Path: <adrian@olddog.co.uk>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B681D1A0149 for <pce@ietfa.amsl.com>; Wed, 20 Aug 2014 02:42:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -99.2
X-Spam-Level:
X-Spam-Status: No, score=-99.2 tagged_above=-999 required=5 tests=[BAYES_50=0.8, RCVD_IN_DNSWL_NONE=-0.0001, USER_IN_WHITELIST=-100] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wvuJx1wmTtet for <pce@ietfa.amsl.com>; Wed, 20 Aug 2014 02:42:11 -0700 (PDT)
Received: from asmtp5.iomartmail.com (asmtp5.iomartmail.com [62.128.201.176]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 927951A0130 for <pce@ietf.org>; Wed, 20 Aug 2014 02:42:10 -0700 (PDT)
Received: from asmtp5.iomartmail.com (localhost.localdomain [127.0.0.1]) by asmtp5.iomartmail.com (8.13.8/8.13.8) with ESMTP id s7K9g9ii006847; Wed, 20 Aug 2014 10:42:09 +0100
Received: from 950129200 (dsl-sp-81-140-15-32.in-addr.broadbandscope.com [81.140.15.32]) (authenticated bits=0) by asmtp5.iomartmail.com (8.13.8/8.13.8) with ESMTP id s7K9g7of006819 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Wed, 20 Aug 2014 10:42:08 +0100
From: Adrian Farrel <adrian@olddog.co.uk>
To: 'Jonathan Hardwick' <Jonathan.Hardwick@metaswitch.com>
References: <000301cfb490$68af4140$3a0dc3c0$@olddog.co.uk> <09CE6C3BE5E1EA40B987BF5F25D8DDBAF4E68BE5@ENFICSMBX1.datcon.co.uk>
In-Reply-To: <09CE6C3BE5E1EA40B987BF5F25D8DDBAF4E68BE5@ENFICSMBX1.datcon.co.uk>
Date: Wed, 20 Aug 2014 10:42:05 +0100
Message-ID: <045f01cfbc5b$016f9750$044ec5f0$@olddog.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQJ7NPi7/TdXggDzWdlKjjGa/BHziQKL0PAPmm3kbPA=
Content-Language: en-gb
X-TM-AS-MML: disable
X-TM-AS-Product-Ver: IMSS-7.1.0.1576-7.5.0.1018-20894.006
X-TM-AS-Result: No--24.419-10.0-31-10
X-imss-scan-details: No--24.419-10.0-31-10
X-TMASE-MatchedRID: HLMPCFyIyBOnykMun0J1wlu4M/xm4KZeC/ExpXrHizwhvFjBsLEZNPhi 4LNMsvHZkyeevgS86MheEanKV7zGy92ykolHu1ZuSHCU59h5KrGBjLzL4do+VgDqzaYhcjeQjVN spaGN/MGvG5JK8CnON397Mq/1mwLlXRTdE9b6Is/BVprK8rvWX9MGD8JuBXZPf7FDYGpyXq16YV qRbpywi0yUJeFviHRqEIcbU2IJuqq7JfBr9Xl5Crrbxxduc6FPbv16+gil4jdp3/r/gb/Q5U1Dt 1c2KkZqwUtcXnfoCJlzlxk+amVX10q+i9GrWzgs8jbzfqNu/QQhpWQUitAWG+hRlIANR+BQYYeS cmM7WX/oQtCrGVdA0SvjloRZsXkgpHn0l5P4rnUD2WXLXdz+Aa6lKKQMji/xnPZnKmPE5JihuUh Elt2sPZ+4S6AnDN0hqiMcz9Yi4r0O5TlHtZKxbUg5Iem1vm3HKiVsyS+TJgeQ2TbICkFOdjcoKT 4beMG5IXuvUou2O0IX+T5/+efOjS4vJgF90VN+bMGKOuLn5FUpWss5kPUFdE2M/fhW4yS6S3rCf IMyHrHWBN2EiASEqfRpvA6+ECKDK0OC3/GwncG+dJWHbg4ITtF/wImPfa5N4KKCbqX/Ma8VjAea OyL90hKxKex4hpP+kEBULBETeomiT190luQ/K8AmcZEx8XHJXfZY2uc9ofbbHIduc3gt1RFlwJh VcSVOAWbLGmc+xKKQDsoz/7qfjGGN6M1vhJ4HXP5rFAucBUF9LQinZ4QefL6qvLNjDYTwzz3jeh zeneyrusVRy4an8bxAi7jPoeEQftwZ3X11IV0=
Archived-At: http://mailarchive.ietf.org/arch/msg/pce/OPH8pSRIjdzyeutJqs3Qq5bpMs4
Cc: draft-ietf-pce-pcep-mib.all@tools.ietf.org, pce@ietf.org
Subject: Re: [Pce] AD review of draft-ietf-pce-pcep-mib
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: adrian@olddog.co.uk
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Aug 2014 09:42:13 -0000

Jon,

Thanks for the work.

Very few responses from me.

> That previous point does cause me to wonder about "PCE capabilities".
> I can see that you have tried to limit this module to describing the
> features that are core to 5440, but I wonder whether that is wise.
> 
> For example, RFCs 5088 and 5089 define a set of PCE capabilities that
> may be advertised in the IGPs and are surely relevant to the model of
> a PCE that speaks PCEP. That information might usefully be seen in the
> module at the PCE, and also at the PCC so that an operator can check
> "why does that PCC keep sending these requests to the wrong PCE?"
> 
> Similarly, the Open Object can carry TLVs that indicate further
> capabilities. Obviously you can't just include all future capabilities
> TLVs since you don't know what they are (well, you know some, but that
> have already been defined, but you can't know the undefined ones). But
> you might want to to look at how those capabilities will be hooked in
> for future accessibility.
> 
> Of particular interest will be the OF-list TLV of RFC 5541.
> 
> >> The scope of the PCEP MIB is currently limited to objects that are core to
RFC
> 5440 only.
> -  The capabilities from RFC 5088/5089 belong in the PCE discovery MIB.
> -  The OFs in the OF-list TLV deserve their own MIB table, which could be
defined
> in a separate MIB if anyone wants it.
> -  There are lots of other PCEP RFCs that we could bring into the scope of
this
> document, but it is already quite large.
> 
> Our preference is to clarify the scope of this document, provide an
informational
> reference to the discovery MIB, and allow other documents to augment /
> supplement the tables we have defined. <<

OK. Sure.
So make sure you have the cross-pointer to the disco MIB module, and think about
how future modules might be able to extend/augment without high price.
For example, a TC that is the bit flags for capability is easily extended (if it
is in a separate module).

> ---
>
> I'm wondering under what circumstances the pcepEntityTable has more than
> one entry. You might describe that in 4.1 and also in the Description
> clause for the table.
> 
> That would tie in with explaining why you have an index of
> Unsigned32 (1..2147483647) which allows for quite a lot of entities!
> 
> >> There is one row in this table for each local PCEP entity, of which there
may be
> multiple.
> 
> One scenario is partitioning a physical router into multiple virtual routers,
each
> with its own PCC. Another scenario is managing a device which front-ends
> multiple PCE compute resources, each with a different set of capabilities that
are
> accessed via different IP addresses.
> 
> Although there clearly won't be billions, we feel there's no point in placing
an
> arbitrary upper limit on the number of local PCEP entities. Our proposal,
> therefore, is to remove the artificial restriction on the entity index range.
<<

OK, I have a bit of a hope that you are doing this because you have a need, not
because it looks like a cool idea! If your text above is just you scraping
around for reasons that might justify the structure you have documented, well,
then you know what you should do :-)

I am trying to compare the case of six physically diverse nodes each with their
own instance of the MIB module, and one physical node hosting 6 virtual
pcepEntities each as a separate entry in the pcepEntityTable.

In the first case, SNMP would use a different IP address to Get each entry in
each pcepEntityTable.

In the second case you are suggesting, I think, that there is one SNMP agent on
the physical node that maintains one copy of the pcepEntityTable, but that each
entry in the table is a separate virtual node. This, I suppose, saves you from
having to run a separate SNMP agent on each virtual node even though those
virtual nodes are separately addressable.

I have no experience of building virtual nodes in this way. I went back to 4750
to see how this is modelled in OSPF and found that it looks to me that in that
case you would run a separate agent for each router instance (of course how you
manage the code and executables -- and even the data -- is up to you, but the
structure of the MIB module is for a single agent per router instance). That is
clearly shown by the fact that ospfRouterId is a member of ospfGeneralGroup
(what you might call a global variable).

Because I have no experience in this, I am not going to require you to change
this structure, but I will ask you to explain how "One scenario is partitioning
a physical router into multiple virtual routers, each
with its own PCC" integrates with 4750.

Bottom line: if you intend that multiple local PC* instantiations can appear in
the same table, please make this a bit clearer in the text.

Anyway, I still think that Unsigned32 (1..2147483647) may be generous.

> Actually, I'm a bit confused about the indexing of the three tables.

OK, we can snip here. Given your use of the pcepEntityTable, the remaining
indexing makes sense. You will, however, need to add text to explain it.

Cheerio,
Adrian