[Pce] Intdir telechat review of draft-ietf-lsr-pce-discovery-security-support-12

Carlos Pignataro via Datatracker <noreply@ietf.org> Tue, 11 October 2022 14:06 UTC

MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Carlos Pignataro via Datatracker <noreply@ietf.org>
To: int-dir@ietf.org
Cc: draft-ietf-lsr-pce-discovery-security-support.all@ietf.org, last-call@ietf.org, lsr@ietf.org
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <166549721104.35846.9858835884158053058@ietfa.amsl.com>
Reply-To: Carlos Pignataro <cpignata@cisco.com>
Date: Tue, 11 Oct 2022 07:06:51 -0700
Resent-From: alias-bounces@ietf.org
Resent-To: dhruv.ietf@gmail.com, lsr@ietf.org, acee@cisco.com, aretana.ietf@gmail.com, bill.wu@huawei.com, diego.r.lopez@telefonica.com, chopps@chopps.org, pce@ietf.org, daniel@olddog.co.uk, maqiufang1@huawei.com, andrew-ietf@liquid.tech, yingzhen.ietf@gmail.com, jgs@juniper.net
Resent-Message-Id: <20221011140651.1CE91C159A3B@ietfa.amsl.com>
Resent-Date: Tue, 11 Oct 2022 07:06:51 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/Q82oF-2loguTkr8wMwjdBICQRQA>
Subject: [Pce] Intdir telechat review of draft-ietf-lsr-pce-discovery-security-support-12

Reviewer: Carlos Pignataro
Review result: Ready with Nits

This document defines a mechanism (flags and sub-TLV) to advertise via the PCE
Protocol security required within the IGP being used.

This is a very well written, clear, and sensible document. In my opinion, it is 
Ready.

Flagging some potential nits:

Abstract:
Old:
   capability.  Further, this document updates RFC 8231, and RFC 8306.
New:
   capability.  Further, this document updates RFC 8231 and RFC 8306.

Question:
The header and Section 4 say this updates RFCs 5088 and 5089; however, 
that is not mentioned in the Abstract.

Old:
   The YANG model for PCEP [I-D.ietf-pce-pcep-yang] supports PCEP
   security parameters (key, key chain and TLS).
New:
   The YANG model for PCEP [I-D.ietf-pce-pcep-yang] supports PCEP
   security parameters (key, key chain, and TLS).

Thanks!

Carlos.

[Pce] Intdir telechat review of draft-ietf-lsr-pc… Carlos Pignataro via Datatracker
Re: [Pce] Intdir telechat review of draft-ietf-ls… Dhruv Dhody
Re: [Pce] Intdir telechat review of draft-ietf-ls… Carlos Pignataro (cpignata)