Re: [Pce] Éric Vyncke's Discuss on draft-ietf-pce-pcep-stateful-pce-gmpls-21: (with DISCUSS and COMMENT)

Dhruv Dhody <dd@dhruvdhody.com> Thu, 08 June 2023 04:34 UTC

Return-Path: <dd@dhruvdhody.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A529EC151B1E for <pce@ietfa.amsl.com>; Wed, 7 Jun 2023 21:34:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.893
X-Spam-Level:
X-Spam-Status: No, score=-1.893 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=dhruvdhody-com.20221208.gappssmtp.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m3Vcm8rZpMMu for <pce@ietfa.amsl.com>; Wed, 7 Jun 2023 21:34:34 -0700 (PDT)
Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8D47FC15107B for <pce@ietf.org>; Wed, 7 Jun 2023 21:34:34 -0700 (PDT)
Received: by mail-yb1-xb2d.google.com with SMTP id 3f1490d57ef6-bacfcc7d1b2so268978276.2 for <pce@ietf.org>; Wed, 07 Jun 2023 21:34:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dhruvdhody-com.20221208.gappssmtp.com; s=20221208; t=1686198873; x=1688790873; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dOpJ0kh5LbJNWv6E9i0rAi0c83yCEyjEfjite3aIPpw=; b=aHChUx/G/giaX9q/gl8nuczg/YcbxvU8U8kI3jh4U4Oif/EFOFXNjR3pGnhql+bgp5 URYR4bRl6DZk0RuNtgsJ0OtKKpLAc7lOp9w7wYf5YkKQYIDo6CliZUilq1pXildRyIfD MKF9TLTzjX06Slfe9yIpFbEVtqCFdp4TcdHiLrKqvGRoUNeI7DTjHclc2S+XGdILJqEn r1q2ikSr+5ynPtay3qYpCWTlgEhTz4t/ZX1H3KXBowp4XW7ufwoaf0/+W95bGAUnVFP0 R4m0OOEgfKYlUJu2T+4JViCU0zxJQuPu1B5cry4GHVGvYWMkh0HgXmHnTq+tm2SPJorB qtwA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686198873; x=1688790873; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dOpJ0kh5LbJNWv6E9i0rAi0c83yCEyjEfjite3aIPpw=; b=N+FB73cZ7kBoNjS0hIIxdjAKZkgx+m4EEvSeRpPOFW+t+BgrroStObqq/oKzifceUt hy7AwaZSKusbyHqAK6vlucmpJ3ypMWgz4PCk+Zlw/DBT77X6Ej79NDbx3ioGVJSPqkwB 36yfQjpS3n8zEsKvbBOrwRCpXKte/+unhdfFe4mS3MQ4honTUvxXrD1fDIUduyjyC5l0 9vJqXw6BE5b16us4APOqSQJFpdAr4GUvkgwYBZgGXuFbLNH2JXCRvKo4fmLIQXPWoSGu HSxk4MVAUzxToD3idywxkToUW3i3DKNfqC1Lt0rFvudAYo4bIG1xMhQlz3UH2lpOQQA0 6hHQ==
X-Gm-Message-State: AC+VfDzaS4+uA9HLHvI3UT22k2iUnkFokaSwFFiJuB5mlmBwAM4/7/Ki 8U7zVmS4dzZjZOfyB5wRrpkr5/YLkPLQf7PCAjD7TA==
X-Google-Smtp-Source: ACHHUZ4vPXcLE54+BiDzxhT8QUN6uyepENS6EMVYQsPpLZLUyeKytqK76vHSHeO7BUZoBCembzIGU8BE3eylaC9zuxU=
X-Received: by 2002:a25:a86:0:b0:bb1:f129:7951 with SMTP id 128-20020a250a86000000b00bb1f1297951mr7185469ybk.18.1686198873533; Wed, 07 Jun 2023 21:34:33 -0700 (PDT)
MIME-Version: 1.0
References: <168617096502.34152.9514921594453573259@ietfa.amsl.com>
In-Reply-To: <168617096502.34152.9514921594453573259@ietfa.amsl.com>
From: Dhruv Dhody <dd@dhruvdhody.com>
Date: Thu, 08 Jun 2023 10:03:56 +0530
Message-ID: <CAP7zK5aweuKPAjgy93bRN+pMDLSj1=76XwQhCkP6f-_YF_cQpA@mail.gmail.com>
To: Éric Vyncke <evyncke@cisco.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-pce-pcep-stateful-pce-gmpls@ietf.org, pce-chairs@ietf.org, pce@ietf.org
Content-Type: multipart/alternative; boundary="000000000000e0d21b05fd96c428"
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/UNPBblV_qESbe9HirfIpNMk_xAo>
Subject: Re: [Pce] Éric Vyncke's Discuss on draft-ietf-pce-pcep-stateful-pce-gmpls-21: (with DISCUSS and COMMENT)
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Jun 2023 04:34:38 -0000

Hi,

On Thu, Jun 8, 2023 at 2:19 AM Éric Vyncke via Datatracker <noreply@ietf.org>
wrote:

> Éric Vyncke has entered the following ballot position for
> draft-ietf-pce-pcep-stateful-pce-gmpls-21: Discuss
>
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
>
>
> Please refer to
> https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/
> for more information about how to handle DISCUSS and COMMENT positions.
>
>
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-pce-pcep-stateful-pce-gmpls/
>
>
>
> ----------------------------------------------------------------------
> DISCUSS:
> ----------------------------------------------------------------------
>
> # Éric Vyncke, INT AD, comments for draft-ietf-shmoo-hackathon-07
>
> Thank you for the work put into this document. It is very specialised and
> above
> my expertise area.
>
> Please find below one blocking DISCUSS points (easy to address, do not
> panic
> ;-) ), two non-blocking COMMENT points.
>
> Special thanks to Dhruv Dhody for the shepherd's detailed write-up
> including
> the WG consensus *and* the justification of the intended status.
>
>
Thanks Éric :)


> I hope that this review helps to improve the document,
>
> Regards,
>
> -éric
>
> # DISCUSS
>
> As noted in https://www.ietf.org/blog/handling-iesg-ballot-positions/, a
> DISCUSS ballot is a request to have a discussion on the following topics:
>
> ## Mismatch in meta-data & the content
>
> While the meta-data is about "standard track" the I-D itself says
> "informational". The IETF Last Call has been done for "standard track", so
> a
> revised I-D is enough to address this DISCUSS.
>
>
>
Dhruv: Oops! In the last update -21, somehow the Intended Status changed. I
should have caught that! Apologies!
IMHO it is a case of an unintentional mistake. Authors would let me know if
that's not the case!



> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
>
> ## Section 6.2.1
>
> s/The TLV is extended with three flags to indicate/The specifcation add
> three
> flags to the flag field of this TLV to indicate/
>
>
Dhruv: Your suggestion makes a lot of sense! Thanks!



> ## Section 9.1
>
> Should the IANA be directed to use the MSB for this allocation ?
>
>
Dhruv: Hmm. The general practice in PCEP is to start allocation from LSB -
https://www.iana.org/assignments/pcep/pcep.xhtml#stateful-pce-capability-tlv-flag-field
https://www.iana.org/assignments/pcep/pcep.xhtml#sr-capability-flag-field
https://www.iana.org/assignments/pcep/pcep.xhtml#h-pce-capability-tlv-flag-field
https://www.iana.org/assignments/pcep/pcep.xhtml#pcecc-capability

IANA would follow the usual practice in the registry as well as confirm
with the authors/chairs/AD at the time of making allocation. But no harm in
making it explicit by - "IANA is requested to make allocations starting
from the least significant bit (31)."

Thanks!
Dhruv