[Pce] Genart last call review of draft-ietf-pce-pcep-stateful-pce-gmpls-21

Stewart Bryant via Datatracker <noreply@ietf.org> Fri, 02 June 2023 09:28 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: pce@ietf.org
Delivered-To: pce@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id C5199C151B23; Fri, 2 Jun 2023 02:28:03 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Stewart Bryant via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
Cc: draft-ietf-pce-pcep-stateful-pce-gmpls.all@ietf.org, last-call@ietf.org, pce@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 10.5.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <168569808379.18158.9765637710729436958@ietfa.amsl.com>
Reply-To: Stewart Bryant <stewart.bryant@gmail.com>
Date: Fri, 02 Jun 2023 02:28:03 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/aRw8WhmWJVyaQks4rBNwM5MjWlo>
Subject: [Pce] Genart last call review of draft-ietf-pce-pcep-stateful-pce-gmpls-21
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Jun 2023 09:28:03 -0000

Reviewer: Stewart Bryant
Review result: Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://wiki.ietf.org/en/group/gen/GenArtFAQ>.

Document: draft-ietf-pce-pcep-stateful-pce-gmpls-21
Reviewer: Stewart Bryant
Review Date: 2023-06-02
IETF LC End Date: 2023-05-29
IESG Telechat date: 2023-06-08

Summary:

I reviewed this from a GenArt perspective (a reader new to the area) and have
one request : that early in the document a few sentences be added (copied from
another text) clarifying the difference between stateless and stateful PCE.

This document is otherwise ready to pass to the RFC Editor team.

I note that id-nits picks up a number of errors regarding references (RFC 2119
language and technical references), but the ones I checked seem correct, so I
am not sure what is happening.

Major issues: None

Minor issues: The absence of an early description of stateful PCE as noted
above.

Nits/editorial comments:

   Further discussion of concept of a stateful PCE can be found in
SB> of the concept

   For passive stateful PCEs, Path Computation Request (PCReq)/ Path
   Computation Reply (PCRep) messages are used to request for path
   computation.
SB> grammar problem