[Pce] Shepherd Review of draft-ietf-pce-pcep-yang

julien.meuric@orange.com Thu, 16 May 2024 14:25 UTC

Return-Path: <julien.meuric@orange.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C7D62C1D6FA3; Thu, 16 May 2024 07:25:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.095
X-Spam-Level:
X-Spam-Status: No, score=-7.095 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=orange.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Kixhug2zgHFy; Thu, 16 May 2024 07:25:19 -0700 (PDT)
Received: from smtp-out.orange.com (smtp-out.orange.com [80.12.126.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 54FD9C1D6208; Thu, 16 May 2024 07:25:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.com; i=@orange.com; q=dns/txt; s=orange002; t=1715869518; x=1747405518; h=message-id:date:mime-version:subject:to:cc:from; bh=1XZ4EHVbrOtsmoBfBbVPsloeNnL+b9G1AgLesZKxVZw=; b=UzS+B/bqDbuCudIrp/WsrdXWjVwDlQnlMHHTE7hCuC1NMLZTTS9KQdDZ LwkNQnizEvCT/ggRE2Nzd5MH0qdgTSZ+Uh8u3+1nwUV8DwwbOQVI5hexw GnO12lJZlabnSyqS80L5k+fU0YCyo+DXTxBoZm2O1wRwVA2+QsGDhooip 5QJ7nI6smwqCF5gki5ISS3RMspUSBvVD7Jbb78Srqvey4PzE1UanYLYU9 bJPA7aaTfxzqpTgWDbeNR56uTAh5FQW1V0LmxNrnp5AGQ55fFoDdm00JL gq/V4uc8jwVcUX+AI5HqUdfToTkTKrK74hrAnIAiz7jVYbBcDV8vpVlKG g==;
Received: from unknown (HELO opfedv3rlp0h.nor.fr.ftgroup) ([x.x.x.x]) by smtp-out.orange.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2024 16:25:13 +0200
Received: from unknown (HELO OPE16NORMBX407.corporate.adroot.infra.ftgroup) ([x.x.x.x]) by opfedv3rlp0h.nor.fr.ftgroup with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 May 2024 16:25:14 +0200
Received: from [x.x.x.x] [x.x.x.x] by OPE16NORMBX407.corporate.adroot.infra.ftgroup [x.x.x.x] with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Thu, 16 May 2024 16:25:13 +0200
From: julien.meuric@orange.com
X-IronPort-AV: E=Sophos;i="6.08,164,1712613600"; d="p7s'346?scan'346,208,346";a="145413293"
Message-ID: <9ec9a72d-4709-4b77-8435-4f1ce413bf60@orange.com>
Date: Thu, 16 May 2024 16:25:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: draft-ietf-pce-pcep-yang@ietf.org
Content-Language: en-US, fr
Organization: Orange
Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg="sha-256"; boundary="------------ms000901070503070500080109"
X-Originating-IP: [10.115.26.51]
X-ClientProxiedBy: OPE16NORMBX403.corporate.adroot.infra.ftgroup (10.115.26.16) To OPE16NORMBX407.corporate.adroot.infra.ftgroup (10.115.27.16)
Message-ID-Hash: P6NSRHMLPNZSLATN4A4EKCRNVD4EVSRE
X-Message-ID-Hash: P6NSRHMLPNZSLATN4A4EKCRNVD4EVSRE
X-MailFrom: julien.meuric@orange.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-pce.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "pce@ietf.org" <pce@ietf.org>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [Pce] Shepherd Review of draft-ietf-pce-pcep-yang
List-Id: Path Computation Element <pce.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/af7NiFxzG5sVfQq8TDc5JmXWS3k>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Owner: <mailto:pce-owner@ietf.org>
List-Post: <mailto:pce@ietf.org>
List-Subscribe: <mailto:pce-join@ietf.org>
List-Unsubscribe: <mailto:pce-leave@ietf.org>

Dear authors of draft-ietf-pce-pcep-yang,

I've reviewed the aforementioned document to prepare its publication 
request. The I-D is almost ready to move forward and only has minor 
issues and nits that should be addressed before sending it to the IESG.

Minor issues:
- The introduction doesn't mention the ietf-pcep-stats module though 
it's defined in the body of the I-D; a brief additional sentence would 
be welcome.
- For SR, the leaf "msd-limit" (page 45) is a boolean that should be 
renamed to be understandable, e.g. into "no-msd-limit" or "ignore-msd".
- On page 46, in the H-PCE section, there's a "if Stateful GMPLS is 
enabled" left instead of "if H-PCE is enabled.
- Section 7.1 about TLS should be deeply summarized and rather point to 
the referenced document (pointer to be updated).
- On page 51, in the description of the hexadecimal case, I don't think 
the 2 long sentences about the rationale should be included there; if 
the authors consider it necessary, it may be included in the text body 
of the draft.
- On page 59, similar comment about the sync-timer description, which 
I'd shorten into the following:
           "The value of SyncTimer in seconds is used in the
            case of synchronized path computation request
            using the SVEC object. If after the expiration of
            the SyncTimer all the path computation requests
            have not been received, a protocol error is
            triggered and the PCE must cancel the whole set
            of path computation requests.
            Zero means that the PCEP entity does not use the
            SyncTimer."
- On page 69, about path key, the name of the leaf "pcc-original" feels 
odd, how about "originator-pcc" instead?

Nits:
- Page 11: s/system generated entity index/system-generated entity index
- P.11: s/the local entity is PCE it/the local entity is a PCE, it
- P.11: s/dead-timer in YANG is called DeadTimer in the protocol 
specification/DeadTimer in the protocol specification is called 
dead-timer in YANG/
- P.16: s/learn PCE in the network via IGP discovery/learn a PCE address 
in the network via the IGP discovery/
- P.28-30: There are several bullets points in the descriptions fields 
that would benefit from semicolons at each line end.
- P.40: s/maybe relevant/may be relevant/
- P.44: s/PCE triggered/PCE-triggered/  [twice]
- P.49: s/instance specific data/instance-specific data/
- P.105: s/this document also include/this document also includes/


Best regards,

Julien