Re: [Pce] Benjamin Kaduk's Discuss on draft-ietf-pce-stateful-hpce-13: (with DISCUSS and COMMENT)

Dhruv Dhody <dhruv.ietf@gmail.com> Thu, 26 September 2019 06:42 UTC

Return-Path: <dhruv.ietf@gmail.com>
X-Original-To: pce@ietfa.amsl.com
Delivered-To: pce@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6129C12080F; Wed, 25 Sep 2019 23:42:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sd4FZcshXV-5; Wed, 25 Sep 2019 23:42:34 -0700 (PDT)
Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3965B1200F6; Wed, 25 Sep 2019 23:42:34 -0700 (PDT)
Received: by mail-io1-xd2d.google.com with SMTP id a1so3613773ioc.6; Wed, 25 Sep 2019 23:42:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2uKoV7tyICeQJrtitD1fXshnYyreBh92p3Q4gAXvfgk=; b=VT52U6JEezB13nXP8n4/yATw1UxE5Wy1OKNQH+H7uB/whuBHQaenqCVBe98I/AfvRg 1sdFlDFd2otkyc4lvbXBfMkzvceaduP9keeftGQvJvuub1QqllHsfUn/YkpkOOcKmfvZ 2WHKD8M4aNCcV0w5+iaOQnoYqrr7Fajw8F3NasXFyq0AvQYr6EsE4aqt9XAbrhhX5TI6 20RR9lB3ck9Y0e7blVT/x0qQIqmy6Rwit/94Ku6w3ZjZY3cx0j6Kbtr5uMfm4nrblAMO 0cWpc8xxqX3+4/CZ4e0cFdoLHBdTQ6c2336NcsoXu4Ol0Q/KGqcUCTQx6546F/9lNEMp CVkw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2uKoV7tyICeQJrtitD1fXshnYyreBh92p3Q4gAXvfgk=; b=kkcHzpzL4CvjAj1zZHhKJiYZ2MNk9Ji4WoajSzxt3gLjojjI35jGplA7t0lKl7Orly TTRlsxJ9vWbKvdBygQ543jAWzhKVA8b45MXFkip50vpYy0oT9JnnM0CGZcVLU6JiXO4r g+7NfHtMftta+SNbFK1fdTs33b6eULVFbO6S1VIrzgftVUUqu6JWQNWGjNg0BbuJzmAR /qSrdOVjEI9ar2wTxHGumbvmUzLcb/trno9t0ehF+sgHjHWjUe+I6wa2gvmGHYUCgExI AbW0MURj2wETjODlEVBVuq6ihhd9R9c5Op0pUHY/apVN9xNQkNTkE/yYc4k+MELfCQhM NW5w==
X-Gm-Message-State: APjAAAWkIM7FbMEIpl39WX/ewELVVSRFQouGFqdRzfHBCgIgQrkf5Sqr xhA4JFOa/4Gx8NU9dNpwVzHdXfo2EY2wOWei3Hg=
X-Google-Smtp-Source: APXvYqzz1QCXnUost4GjcZ1jb3F9xEQJHELEFb/2CLGOrbG0HAVFa3wGrq7yXwhgP6Te8+T0GOV4JVEwYWzDskJHnco=
X-Received: by 2002:a5e:d502:: with SMTP id e2mr1978340iom.279.1569480153150; Wed, 25 Sep 2019 23:42:33 -0700 (PDT)
MIME-Version: 1.0
References: <156884459034.4565.10696493114905134845.idtracker@ietfa.amsl.com> <CAB75xn5wp6EvhCVExn9sz4ipbxT+1GpPbW_fX8GOea6zh=tBpw@mail.gmail.com> <20190925232548.GQ6424@kduck.mit.edu>
In-Reply-To: <20190925232548.GQ6424@kduck.mit.edu>
From: Dhruv Dhody <dhruv.ietf@gmail.com>
Date: Thu, 26 Sep 2019 12:11:56 +0530
Message-ID: <CAB75xn7XA4+b3+65SK8PhKUfQNX_Z3FRUOs+8u3Ekmv1XvXdYA@mail.gmail.com>
To: Benjamin Kaduk <kaduk@mit.edu>
Cc: The IESG <iesg@ietf.org>, draft-ietf-pce-stateful-hpce@ietf.org, Adrian Farrel <adrian@olddog.co.uk>, pce-chairs <pce-chairs@ietf.org>, pce@ietf.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/pce/q05i0SflNwqVeMllpmWA8gKh99Y>
Subject: Re: [Pce] Benjamin Kaduk's Discuss on draft-ietf-pce-stateful-hpce-13: (with DISCUSS and COMMENT)
X-BeenThere: pce@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Path Computation Element <pce.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pce>, <mailto:pce-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pce/>
List-Post: <mailto:pce@ietf.org>
List-Help: <mailto:pce-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pce>, <mailto:pce-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Sep 2019 06:42:37 -0000

Hi Ben,

Snipping to the final discuss that is still open -


> > > ----------------------------------------------------------------------
> > > DISCUSS:
> > > ----------------------------------------------------------------------
> > >
> > > I think this should be pretty easy to resolve, though I'm not sure what
> > > the right way to do so it.
> > >
> > > Section 3 says:
> > >
> > >    [I-D.ietf-pce-hierarchy-extensions] defines the H-PCE Capability TLV
> > >    that is used in the Open message to advertise the H-PCE capability.
> > >    [RFC8231] defines the Stateful PCE Capability TLV used in the Open
> > >    message to indicate stateful support.  The presence of both TLVs in
> > >    an Open message indicates the support for stateful H-PCE operations
> > >    as described in this document.
> > >
> > > There is no normative reference relationship (in either direction)
> > > between draft-ietf-pce-hierarchy-extension and this document; I think
> > > that the use of the capability TLV to imply both sets of functionality
> > > implies some sort of normative relationship; we wouldn't want version
> > > skew between documents to induce breaking changes.  In particular, an
> > > implementation that already supports RFC 8231 and is implementing the
> > > hierarchy extensions would need to know to look at this document *and
> > > implement it*, or would unknowingly be noncompliant with this document
> > > and fail to interoperate with a peer that is compliant with this
> > > document.
> > >
> >
> > How about we add normative text for this -
> >
> >    [I-D.ietf-pce-hierarchy-extensions] defines the H-PCE Capability TLV
> >    that is used in the Open message to advertise the H-PCE capability.
> >    [RFC8231] defines the Stateful PCE Capability TLV used in the Open
> >    message to indicate stateful support. To indicates the support for
> >    stateful H-PCE operations described in this document, a PCEP speaker
> >    MUST include both TLVs in an Open message. It is RECOMMENDED that any
> >    implementation that supports stateful operations [RFC8231] and H-PCE
> >    [I-D.ietf-pce-hierarchy-extensions] would also implements the
> >    stateful H-PCE operations as described in this document.
> >
> > This would be true in most deployments/implementations of C-PCE and
> > P-PCE that are also stateful!
>
> This does remove the problematic normative requirement on implementations
> of other documents, but I'm not sure if it does what's needed for the
> interactions across documents.  Specifically, what will happen if two peers
> both support/advertise stateful PCE and H-PCE but only one implements
> stateful HPCE? Will there be a clean error handling at runtime and
> degredation to one or the other, or will there be messy errors?  If the
> latter, then I don't think we can just have a RECOMMENDED relationship.
>

The assumption was that any implementation that claims to support
stateful and H-PCE on a particular session would also support Stateful
H-PCE and this document just describes the interaction between these
two features as an informational document.

But, lets take a case where PCC and P-PCE support stateful H-PCE but
the C-PCE does not. PCC would send stateful message to C-PCE and C-PCE
would not further propagate them.

I further did a mental exercise for PCC -> C-PCE -> P-PCE and assumed
all support stateful and H-PCE extension but what happens when any
PCEP speaker does not support stateful H-PCE but the peer assumes that
it does. On further PCEP message exchange, the messages may not get
further propagated and thus at worse would not lead to the stateful
H-PCE based 'parent' control of the LSP. This is something any peer
should be prepared for anyways.

The "clean" solution would be to add a new flag; but then we also need
to move this a standards track and loose the claim that this is just a
combination of existing protocol extensions.

Thanks!
Dhruv