Re: [Perc] Magnus Westerlund's Discuss on draft-ietf-perc-double-10: (with DISCUSS and COMMENT)

Richard Barnes <rlb@ipv.sx> Mon, 05 August 2019 14:48 UTC

Return-Path: <rlb@ipv.sx>
X-Original-To: perc@ietfa.amsl.com
Delivered-To: perc@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4A58C12028E for <perc@ietfa.amsl.com>; Mon, 5 Aug 2019 07:48:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.896
X-Spam-Level:
X-Spam-Status: No, score=-1.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=ipv-sx.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8WBzLAIqMmgQ for <perc@ietfa.amsl.com>; Mon, 5 Aug 2019 07:48:39 -0700 (PDT)
Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 84AF7120242 for <perc@ietf.org>; Mon, 5 Aug 2019 07:48:32 -0700 (PDT)
Received: by mail-oi1-x234.google.com with SMTP id u15so62242077oiv.0 for <perc@ietf.org>; Mon, 05 Aug 2019 07:48:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipv-sx.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MBHpEwX50lzvDvtJzHuYq5PgV3T4TAybrcAEjpW+kfk=; b=E7AJW8ptGDHVeJxVLQWI8kgySyH9G65XjHS5hOnOqv9tViIy6/IXFVeRtE5Ovx/BOq wE4a1ZQSAQafPypyRLprL2hR+5fV4f2DY2JpSLbuRfifV4aANg16UVnNkr/F/g4kM1fM +AvsZLtRAC/AOZ1ulqzBhxV6gGAm6rpJ+OETg33rDlslpNWMleIXkeIMKpuNFOOFOSk5 ITTczwc3H6aVGO4o0XLDa4TJ4mpJJSrB03DzyKMnF7fmPKw6zZ6d3WhF1JcD2mHttVUM sry+1fVvMXHYf6Vt/S9FT6J1DxT0wY1h9IMu0LEoB8Vo0eSmxbcF7Yhrwo3JaQMeToME vl5A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MBHpEwX50lzvDvtJzHuYq5PgV3T4TAybrcAEjpW+kfk=; b=IoxGFwjX6WGL+fvE4/5TSWwWROC8E0byBkc3Vkbwf3QKDwUIucuAegaaVttmjIis5W xWvqhFFc17mhZHdRF8nVOFpNsYNHT2Hxo2XPacwOM+LjCNVuHXoSIBniG68JykPD+aNV 3TVLlArAzx1Fz7I9tGUYuY2T3J4MqDi4XlZUaiDVxuI1GW87z1eJBCA7Rkm9pXeEq9kV khh6PFBwI5G7TwJlMIVY02PQfm4XCbdYXfGmJp7TU7RKItyQoSTuKfb9xbilgFEfipOe jXGui1aFN9ChhAGQKSVy+MvbA9TA+f6NfzcktaacqIXVbiLEhgQ6b/ARp1TZSzNmVNyz j9rA==
X-Gm-Message-State: APjAAAUARpDI7LbSZPSlxQ3uSZ3/Ts9Ngqx94CRK7V77VuOujmzXisKk PrQHtovlNxoZRmOUNUJGrHzPdIMwCaWQ20Qeylk=
X-Google-Smtp-Source: APXvYqy9f5VSr7ADcuDg0nwAhYo41PQ0pO1f65kMaKgR9dnLS7kD3PanCPGTktUEJG7HdVKYRwdqjrDKZpsiCjjEjfQ=
X-Received: by 2002:aca:f40a:: with SMTP id s10mr10931124oih.51.1565016511577; Mon, 05 Aug 2019 07:48:31 -0700 (PDT)
MIME-Version: 1.0
References: <155800082724.19580.16483563575859435866.idtracker@ietfa.amsl.com> <65737EA1-49AF-4EB9-AD1F-25157B3F010D@iii.ca> <HE1PR0701MB25220714DB8E5AE970E0FDFA95DA0@HE1PR0701MB2522.eurprd07.prod.outlook.com>
In-Reply-To: <HE1PR0701MB25220714DB8E5AE970E0FDFA95DA0@HE1PR0701MB2522.eurprd07.prod.outlook.com>
From: Richard Barnes <rlb@ipv.sx>
Date: Mon, 05 Aug 2019 10:47:33 -0400
Message-ID: <CAL02cgTf9sMonRFG1qi9pLxuK8ruvxUStdcju8JU_9+5Kty53w@mail.gmail.com>
To: Magnus Westerlund <magnus.westerlund@ericsson.com>
Cc: "fluffy@iii.ca" <fluffy@iii.ca>, "iesg@ietf.org" <iesg@ietf.org>, "perc-chairs@ietf.org" <perc-chairs@ietf.org>, "draft-ietf-perc-double@ietf.org" <draft-ietf-perc-double@ietf.org>, "suhasietf@gmail.com" <suhasietf@gmail.com>, "perc@ietf.org" <perc@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000003d936f058f5fcd7b"
Archived-At: <https://mailarchive.ietf.org/arch/msg/perc/oI6CqodKPEvWUlrTCYniJmRNioo>
Subject: Re: [Perc] Magnus Westerlund's Discuss on draft-ietf-perc-double-10: (with DISCUSS and COMMENT)
X-BeenThere: perc@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Privacy Enhanced RTP Conferencing <perc.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/perc>, <mailto:perc-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/perc/>
List-Post: <mailto:perc@ietf.org>
List-Help: <mailto:perc-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/perc>, <mailto:perc-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Aug 2019 14:48:42 -0000

Hey Magnus,

Sorry, should have responded on Point 1.  I think you're just mistaken on
that point.  Padding is included within the inner encryption.  The double
transform is an SRTP transform like any other; outside of the SRTP stack,
there is no "inner" or "outer", just the same old protect and unprotect.
So padding works the same as it does with any other SRTP transform.

Was there some text in the document that gave you the impression that
padding was not included under the inner encryption?  The only mention of
padding I see in the document is in the figure in Appendix A [1], where the
padding is correctly shown to be within the inner encryption.  Happy to
clarify if you have some suggestions for how.

--Richard

[1] https://tools.ietf.org/html/draft-ietf-perc-double-11#appendix-A

On Mon, Aug 5, 2019 at 2:32 AM Magnus Westerlund <
magnus.westerlund@ericsson.com> wrote:

> Hi,
>
> Sorry, I missed when this update was submitted, thanks for the reminder.
>
> The new version addresses most of my discuss, but missed to do anything
> about point 1 below.
>
> Otherwise it appears to address my discuss points. How do you want to
> resolve it?
>
> Cheers
>
> Magnus Westerlund
>
> > -----Original Message-----
> > From: Cullen Jennings <fluffy@iii.ca>
> > Sent: den 17 maj 2019 20:34
> > To: Magnus Westerlund <magnus.westerlund@ericsson.com>
> > Cc: The IESG <iesg@ietf.org>; perc-chairs@ietf.org; draft-ietf-perc-
> > double@ietf.org; suhasietf@gmail.com; perc@ietf.org
> > Subject: Re: [Perc] Magnus Westerlund's Discuss on
> draft-ietf-perc-double-
> > 10: (with DISCUSS and COMMENT)
> >
> > >
> > > 1. Section 5.1:
> > >
> > > To me it appears that one fundamental security flaw exists in the
> > > definition of the inner encryption. That is the fact that RTP padding
> > > is not included into the inner encrypted part. This prevents the
> > > application of RTP padding to prevent the potential privacy leakage
> > > that "Guidelines for the Use of Variable Bit Rate Audio with Secure
> > > RTP" (RFC 6562) documents. To prevent this type of information leakage
> > > and other privacy preserving operations based on applying RTP padding
> > > it would be necessary to include the RTP padding into the inner
> > > encrypted envelope. Appendix A figure indicates that is the case, but
> the
> > process description in 5.1 is not matching that.
> > >
> >
> > So my read of 5.1 is that does this. Clearly we need to make the text
> clear
> > that it does that - what part of the 5.1 makes you think the padding is
> > stripped from the  payload ?
> >
> > Perhaps to make it explicitly clear we should change
> >
> > "* Payload: The RTP payload of the original packet”
> >
> > to be
> >
> > "* Payload (including padding) The RTP payload (including passing) of the
> > original packet”
> >
> >
> >
> >
>
>