IETF Logo Mail Archive

Re: [pim] Rtgdir last call review of draft-ietf-pim-igmp-mld-proxy-yang-08

Hongji Zhao <hongji.zhao@ericsson.com> Thu, 15 December 2022 07:42 UTC

Return-Path: <hongji.zhao@ericsson.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 06BBAC14F725; Wed, 14 Dec 2022 23:42:26 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.1
X-Spam-Level:
X-Spam-Status: No, score=-7.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Lj5Uv7-5JmMl; Wed, 14 Dec 2022 23:42:21 -0800 (PST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2067.outbound.protection.outlook.com [40.107.22.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 93EE1C1516E7; Wed, 14 Dec 2022 23:42:18 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=etydTKDNyy81qoKC+8JnFOFCBvOBExERYflOOUKqvsLEXnCeuk0bk8UF49007obLMD/qv66pzIMBnroiC/KNdFgb90nnehmZ93dlMQQOWTfTpKyqM3z/nD74GXbDWMbZ0xd3fsgxkPXkU4QIWkZ01twhGj6533PO4LoFkIJROJMyLF5Bt5qNENYVCSCaW8gjR4lOIZBztL3WeHPqRKfmjeiWdxi0BqwxGPDkhf74Nbp4H9ZuJ13178EGily5gp3sxNXvN9j5U8j6NEp952eOE0OH0S4r3VqnNbrOWq2Su6iRB5xy9rMZwsSl4DyoVhpCBdYTJrh6nxHvA/q+iaUrHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JgGrUNXR4WJm2QRTKh8BsWE9bEXZyb47fQzjYxEfTqk=; b=oXMbNa6g7lHhBovp39aGxfIxJvqEITpcA4pPK6zXJXCmGQys/ylo9lc1EFDDjuud7iHyPpEjAgxZI7PQbBtwTrMTSa1yB9wK/aBdyoPQ8QdqZJWgEBEyJd8JMTJISefTpGzXifahbsbxe3BIfVawpDLDmioIOEQVjgB4tik2RYoBOnnmaCNEtorWzJ0ux1jNjUalj9SJYvLi0zYV3WFba0H3DPvjDCxZLgj7VGMJjU0mukZWQvadgcoKS2GVsdmcqYpB6kqZQY98+UMn76OO5IL5fk2WVW/K7D1FcxTvySUewOz9RX0BJAyOF6qUzmyq388VgEB2LB+RrvhwJeqHSw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JgGrUNXR4WJm2QRTKh8BsWE9bEXZyb47fQzjYxEfTqk=; b=O0zl36U5c2mg31gqgh4VZyulzcmwFhp4DQ6lxnec3PuGsRAYQhRgECXpNxK+YxfFBZKevcLS1MPUqWN/OO6sGJBtcqey/kL+JFJTU/H9QRRW+ASwhuE4GDgXYNA71mcWOtCDgMTJX7BmMEUHuJeTP6QAarviRxLUlXl8P5DzmMw=
Received: from AS2PR07MB8979.eurprd07.prod.outlook.com (2603:10a6:20b:556::7) by AM9PR07MB7154.eurprd07.prod.outlook.com (2603:10a6:20b:2cd::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Thu, 15 Dec 2022 07:42:15 +0000
Received: from AS2PR07MB8979.eurprd07.prod.outlook.com ([fe80::fda8:e5bb:89e4:3157]) by AS2PR07MB8979.eurprd07.prod.outlook.com ([fe80::fda8:e5bb:89e4:3157%9]) with mapi id 15.20.5880.019; Thu, 15 Dec 2022 07:42:15 +0000
From: Hongji Zhao <hongji.zhao@ericsson.com>
To: Susan Hares <shares@ndzh.com>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>
CC: "draft-ietf-pim-igmp-mld-proxy-yang.all@ietf.org" <draft-ietf-pim-igmp-mld-proxy-yang.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "pim@ietf.org" <pim@ietf.org>
Thread-Topic: Rtgdir last call review of draft-ietf-pim-igmp-mld-proxy-yang-08
Thread-Index: AQHZDjuxUpnNXzb1q0aYaICDwYgScK5ujY6w
Date: Thu, 15 Dec 2022 07:42:15 +0000
Message-ID: <AS2PR07MB897905A0431F21EA81B7C80996E19@AS2PR07MB8979.eurprd07.prod.outlook.com>
References: <167085774389.46516.11191563565611967392@ietfa.amsl.com>
In-Reply-To: <167085774389.46516.11191563565611967392@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ericsson.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: AS2PR07MB8979:EE_|AM9PR07MB7154:EE_
x-ms-office365-filtering-correlation-id: 8d674f83-bb64-4744-3ea0-08dade6fe2ba
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: LzmqMpc6acycrAXM+2h9fEMmECWx2je/2A+DWZlk/t+QtIfozHKrJ2bI9EGmxIUmAgWlt4rW4dWBDjX6eUNqOI39HcZ0KTgNtiyDaSPhyHVu5KyYsqtkxyd9sNCAGOkRCxMvxGkJcDpxkhFIshPuDfRbk71TZBomykkD2XnrgKpJFV6zgX13gN6gvKz5Xww09r86ChROlC00A/eVf1rLiV8nrOEfDEoKMVOevmqHVi+5zgY6iWIH5cbHhAqaMqZppadzuVo9ocUW8YAIEeaZbmHh05PAQ6tYgbKOYNcVhKT6R6UZpQarBd12K7l6hihl1wo6WazzQ0RWS5ckM5XqUmWFIV+Ldu7OCMmM1iOokgI0gSKWO356rtDDbOscvEPjdobBR/925/H5rSxK2B/Z4Ye6MLZR+4OSzGTxKWRZg6k5EjP7Munr8khTDBLSzkCAbJFPDwfVe6CmvCDA0dd+a877T7yCqwrDDF3vHGd5NtGdZZQR9jHxt62cPX7lZNArhNMYx55thUyry2tRhGg8L3br6e5X0gRDet8weWq/RhaaQTLLGrn5ScBbkrQjWdH1w9aDut3Wu8hVZNK2lunzbfpdW9ID66xjElX5PnSfNRuF/d7P7XrWb4kYUfiXEPJOSTaBmEjiJRD/Ewx/Cl3Lj28XdPpV8BFVX/SQxTb3kxQyKsNRIdI4X5ypEAJVLNnlgFkLvC4c7j2aUpYlnJjxCmiUvqOeO2KiqmUSuad1GAGTDWix2r1sqE7nPN+BdU/u
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS2PR07MB8979.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(366004)(376002)(346002)(396003)(136003)(451199015)(64756008)(8676002)(66476007)(66446008)(2906002)(66946007)(66556008)(4326008)(76116006)(478600001)(82960400001)(186003)(7696005)(26005)(53546011)(6506007)(44832011)(8936002)(5660300002)(52536014)(41300700001)(122000001)(83380400001)(38100700002)(55016003)(86362001)(33656002)(38070700005)(54906003)(316002)(9686003)(71200400001)(110136005); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: YCQVkkM96gDmrUAJQy6uuGJIrmm+ONA2IpPFEyc5jY/WPN0jS/n+tjhI8QPL+1sR8pfMU6w0KJrVCnlBqp7czaM6GLlNu/VGqqYkm2ExWrZzsXJcWuyZgUo3Kyaz6rAqg+xeu3ps1RsHwH0iPAIz07vZIW6wxxErVVXVOdklv9EzrCzeaXqzmyyil28I7FLeew5Uz1mJWA4CCWkUvsqqsHeMpv/XPZ9c/MKrAY0+I2JCW9d1R6CUuKbEBRRJ+fNf5AW+v5X9qbxLuGcJXVXcNNX29yFFRc1Q4dOD+p/W+7TYC9682Zw2rRiIga55umpHKaqHlNhP9IuZI7KVrbiCnGyBwKZCr3Ppz1TCw5KY+5BasPmA2PwW7IAQ8/p0QTxMgSPBH/9L0eNsolG8sjtvm+PJPicuLdzJTMvBGTfKa+7ORrAUBM8C41NkOeB78di9qa3zR7aw6olsxuw8m9nqOAMFN4mKjczEj9aWChewWZriPTK6MpcL5u0d1Tm79iuEmKUtghygh19+4FIPfumMcQRb83gIUR7ihYoh6656DFVOrCLo5q5PQWYdHHrT+/XVFYCXdL+zj934jVOjxqsJW50WR2dzV9HaDU5341C6H3gobVLPdL+UAJwlWoqztr5QtUCXvRj8guX9CaiM6M7Wp53RdSTttbOWRww95PHAdByFVYeqf1zC92T5d5SwwAQR9w1Ja58pHrI2yWv1rOdZKCujRPfCXbRoMpc4hViujj54krI0EdAfPff8nZSfOpc/WLhh8wstKZYBc8dQwH4qbJj5RlP1KpzrWdjL/abRFtf14O/nrhQEpfolbsqRaHLnveUTOGKODGDNv9aLMioxQTfGohyg+VC1cJWEUsTc//OZz6HBM9O8Y9VJkLZKdrE+HUeL/5P1wKWkVJ2Pyz7FbRkR27ZVQIiG684oTzoXa9CesJZ+P5vStFLnTIkFS8XPuHsfW/7oOWnkNX77MXzn9HNsDAw2UnvavLtXP9MPLeGxG5Mycts4IqYb4dJfP8N5dJVlRW4SnU2ZropEJwmO92oUCUq/RY1Nh/UtanugGytZ1khtCbuZ9JK/0Q/h1DO5k9swdiR0m1XHdchENFlnhPipKT9nR8wazskkP1ulSSOz3vbLdddO8+56J8abimBmRbKeog+6Gnkvso5KKVkXKGM434Ut1DGuG1b2ARdT9LpoWWK6NBWRU7MB+/6URKOrIQ16W8JWVIHrkgkY9sz6Ic9UUIBQhx3FCORrR4ILPD+BbivXPGSoC6X3MECm+5hvMN7UJb/ybJAa8ErlfXViscEeIrqZhfKQZMuAGO2T6Lx+cucwYbB5uwEi7PqwK4AOfHZ7V1lneiC3I7+7hxb5CMvmSXHoVba8wSpsLvp+d0I8IaiSnlhEs4Iw3SUdRqFW19iz/+LASQGGRCbDN+hskLLJps6E04BjEVHULFC7kYXfK4LXGU85V3CkMjhGjokfJC4VjSXI5O31SO6LaTO69b+ji4Ya+bisr+nexhkETFhIw6zfc4XVOWIwf5kJ33YzKsx46xZqk0zttM6RQbNJPSxgBFwK81kIAjNVOnfm12QBAH2DHdGSNFDpjLZxbNFZ
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AS2PR07MB8979.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d674f83-bb64-4744-3ea0-08dade6fe2ba
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2022 07:42:15.2470 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tnyLzKUBzieAm0HXpCh+NQ/R90eoOnLMXEXOX3o7lWKo51HiWaWTcAKV7luaciXELNob6IvQSPT25OojQTqkflUxV5vFUzRq0nRME3DjBhQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR07MB7154
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/34eJnG6Jl0HNI0QSt8DGc0oarCU>
Subject: Re: [pim] Rtgdir last call review of draft-ietf-pim-igmp-mld-proxy-yang-08
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Dec 2022 07:42:26 -0000

Hi Susan,

Thanks a lot for your comments.

"filter-mode" may be either INCLUDE or EXCLUDE. In INCLUDE mode, reception of packets sent to the specified multicast address is requested *only* from those IP source addresses listed in the
source-list parameter. In EXCLUDE mode, reception of packets sent to the given multicast address is requested from all IP source addresses *except* those listed in the source-list parameter [RFC 3376].

Generally there are more than one source-address for a group-address. Some source-addresses are include mode, and others are exclude mode.

For example, group-address  "233.252.0.23" has two source-addresses, which are 192.0.2.1 and 192.0.3.1. The 192.0.2.1 is include mode, and the 192.0.3.1 is in exclude mode.



BR/Hongji

-----Original Message-----
From: Susan Hares via Datatracker <noreply@ietf.org> 
Sent: 2022年12月12日 23:09
To: rtg-dir@ietf.org
Cc: draft-ietf-pim-igmp-mld-proxy-yang.all@ietf.org; last-call@ietf.org; pim@ietf.org
Subject: Rtgdir last call review of draft-ietf-pim-igmp-mld-proxy-yang-08

Reviewer: Susan Hares
Review result: Has Issues

Revew: Document is readable and matches Yang for 1.1. 
Status: 1 issue

Is it possible that deployments for the filter-mode be require both INCLUDE and EXCLUDE (see pages. 6, 7 and grouping state-group-attribute)? 

The text says "INCLUDE" or "EXCLUDE".  It would be good to know why the authors felt consider the "choice" statement where both "INCLUDE" and "EXCLUDE" would not be possible. 

Is this due to the normal situation for IGMP-proxy and MLD-Proxy in most deployed? 
What would happen if both were needed?  How can choice be part of an augmentation? 

Also, this review did not consider the automated tools review.

v2.23.0 | Report a Bug | By Email