[pim] Secdir last call review of draft-ietf-pim-bfd-p2mp-use-case-07
Russ Housley via Datatracker <noreply@ietf.org> Tue, 21 September 2021 16:17 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: pim@ietf.org
Delivered-To: pim@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 5D6953A07BC; Tue, 21 Sep 2021 09:17:15 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Russ Housley via Datatracker <noreply@ietf.org>
To: secdir@ietf.org
Cc: draft-ietf-pim-bfd-p2mp-use-case.all@ietf.org, last-call@ietf.org, pim@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.38.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <163224103532.4850.12172127983159243773@ietfa.amsl.com>
Reply-To: Russ Housley <housley@vigilsec.com>
Date: Tue, 21 Sep 2021 09:17:15 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/8JuMnSDxOBZQXmu5MQOD9Iv1oFE>
Subject: [pim] Secdir last call review of draft-ietf-pim-bfd-p2mp-use-case-07
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Sep 2021 16:17:16 -0000
Reviewer: Russ Housley Review result: Has Issues I reviewed this document as part of the Security Directorate's ongoing effort to review all IETF documents being processed by the IESG. These comments were written primarily for the benefit of the Security Area Directors. Document authors, document editors, and WG chairs should treat these comments just like any other IETF Last Call comments. Document: draft-ietf-pim-bfd-p2mp-use-case-07 Reviewer: Russ Housley Review Date: 2021-09-21 IETF LC End Date: 2021-09-28 IESG Telechat date: Unknown Summary: Has Issues Major Concerns: None Minor Concerns: General: All of the field names in this document use camel case, except one. I think the document would be easier to read if My Discriminator were to use the same convention. Also, HeadDiscriminator would be more descriptive. Section 2.1 says: The head MUST include the BFD Discriminator option in its Hello messages. This MUST statement cold me much more complete: The head MUST include the BFD Discriminator option in its Hello messages, and it MUST include a 4-byte My Discriminator with a value other than zero. Section 2.3: s/must set/MUST set/ Nits: Section 1, para 1 could be more clear and more forceful. I suggest: Faster convergence in the control plane minimizes the periods of traffic blackholing, transient routing loops, and other situations that may negatively affect service data flow. Faster convergence in the control plane is beneficial to unicast and multicast routing protocols. Section 1, para 2: s/DR is to act on behalf/DR acts on behalf/ Section 1, para 3: The first sentence is very unclear. I cannot offer an improvement because it is too hard to parse. Section 1, para 3: s/networks precisely/networks, and it precisely/ Section 1.1.1: s/familiarity/Familiarity/
- [pim] Secdir last call review of draft-ietf-pim-b… Russ Housley via Datatracker
- Re: [pim] Secdir last call review of draft-ietf-p… Greg Mirsky
- Re: [pim] [Last-Call] Secdir last call review of … Russ Housley
- Re: [pim] [Last-Call] Secdir last call review of … Greg Mirsky