[pim] Tsvart last call review of draft-ietf-pim-igmp-mld-extension-05
Wesley Eddy via Datatracker <noreply@ietf.org> Tue, 18 January 2022 19:47 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: pim@ietf.org
Delivered-To: pim@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id EBDBC3A136C; Tue, 18 Jan 2022 11:47:50 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Wesley Eddy via Datatracker <noreply@ietf.org>
To: tsv-art@ietf.org
Cc: draft-ietf-pim-igmp-mld-extension.all@ietf.org, last-call@ietf.org, pim@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.42.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <164253527090.10119.4991890550156865717@ietfa.amsl.com>
Reply-To: Wesley Eddy <wes@mti-systems.com>
Date: Tue, 18 Jan 2022 11:47:50 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/8UPINhshLHMjD-gymy4HnUGnQgA>
Subject: [pim] Tsvart last call review of draft-ietf-pim-igmp-mld-extension-05
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Jan 2022 19:47:51 -0000
Reviewer: Wesley Eddy Review result: Ready This document has been reviewed as part of the transport area review team's ongoing effort to review key IETF documents. These comments were written primarily for the transport area directors, but are copied to the document's authors and WG to allow them to address any issues raised and also to the IETF discussion list for information. When done at the time of IETF Last Call, the authors should consider this review as part of the last-call comments they receive. Please always CC tsv-art@ietf.org if you reply to or forward this review. I don't have any concerns with this document. The mechanisms described in the document could increase packet sizes significantly (if extensions are heavily used), but there is also already a clear warning about avoiding fragmentation. Specific strategies for limiting the size of packets can be left to specific implementations or cases of usage where this might matter (either by reducing the number of groups, or disabling extensions, or other means), so I don't think it needs anything more than what has already been stated in the document. One related thing that I worry a little bit about is whether a naïve strategy for avoiding "too big" packets might result instead in generating a larger number of smaller packets, that might be released without any rate or congestion control, however, I think that other separate guidelines for general rate limiting of ICMP and MLD handle this situation as well, and it's not specific to this document.
- [pim] Tsvart last call review of draft-ietf-pim-i… Wesley Eddy via Datatracker