Re: [pim] Last Call Expired: <draft-ietf-pim-assert-packing-08.txt>

Toerless Eckert <tte@cs.fau.de> Thu, 09 March 2023 18:14 UTC

Return-Path: <eckert@i4.informatik.uni-erlangen.de>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1CE62C151546; Thu, 9 Mar 2023 10:14:25 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.649
X-Spam-Level:
X-Spam-Status: No, score=-1.649 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vVnIDx3SY2qS; Thu, 9 Mar 2023 10:14:23 -0800 (PST)
Received: from faui40.informatik.uni-erlangen.de (faui40.informatik.uni-erlangen.de [IPv6:2001:638:a000:4134::ffff:40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 41AC6C15154A; Thu, 9 Mar 2023 10:14:21 -0800 (PST)
Received: from faui48e.informatik.uni-erlangen.de (faui48e.informatik.uni-erlangen.de [131.188.34.51]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by faui40.informatik.uni-erlangen.de (Postfix) with ESMTPS id 4PXclG0HDvznkjm; Thu, 9 Mar 2023 19:14:18 +0100 (CET)
Received: by faui48e.informatik.uni-erlangen.de (Postfix, from userid 10463) id 4PXclF6qpFzkvGf; Thu, 9 Mar 2023 19:14:17 +0100 (CET)
Date: Thu, 09 Mar 2023 19:14:17 +0100
From: Toerless Eckert <tte@cs.fau.de>
To: Alvaro Retana <aretana.ietf@gmail.com>
Cc: pim-chairs <pim-chairs@ietf.org>, draft-ietf-pim-assert-packing@ietf.org, Stig Venaas <stig@venaas.com>, pim@ietf.org
Message-ID: <ZAoh+VLNN/LtXKlz@faui48e.informatik.uni-erlangen.de>
References: <ZAk+V2f+vBZ6euTL@faui48e.informatik.uni-erlangen.de> <CAMMESsyqbgW-2tNfYVxFqK2ToAunekQ=Ung=4YsAHDc2p4jtPw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAMMESsyqbgW-2tNfYVxFqK2ToAunekQ=Ung=4YsAHDc2p4jtPw@mail.gmail.com>
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/LQTcZ6y7C2fjmKyO2wCMgi5pkcQ>
Subject: Re: [pim] Last Call Expired: <draft-ietf-pim-assert-packing-08.txt>
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Mar 2023 18:14:25 -0000

Thanks, Alvaro

Will definitely change the Reserved to 24 bits.

Would it help to avoid a lot of duplicate feedback on this issue if
i was doing another quick rev for this right now, or
does this just confuse the IESG review process ?

Btw:

I had actually overlooked stuff in rfc7761 and was under the misguided
impression that there was only 16 bit alignment in some fields.

So i just went back to investigate a bit more if we should still consider
"native" alignment up to 32 bits (aka: 32 bit address like IPv4 address
starts at 32 bit boundary) to be important enough, and i could not
find sufficient evidence to not be concerned about it anymore.
Interestingly enough it's less the CPU/instruction set capabilities to
do misaligned access - that has improved a lot since e.g.: 2010. But
it seems to actually be ongoing C language level expectations to
have "native" alignments.

Cheers
    Toerless

On Thu, Mar 09, 2023 at 03:25:14AM -0800, Alvaro Retana wrote:
> On March 8, 2023 at 9:03:06 PM, Toerless Eckert wrote:
> 
> Toerless:
> 
> Hi!
> 
> 
> > Hope this is ready for you to go to IESG!
> 
> I have issued by ballot and it should be placed in next week's IESG
> Telechat.  This should give us enough time to address any comments by
> IETF 116.
> 
> 
> ...
> > - I did remove "Count" from message headers and added a "Zero" field
> > to resolve the discuss with Stigs.
> 
> The only issue I have with this is that the packet format now looks as
> if the first Assert Record has a length of multiple of 32 + 16 bits --
> but they are are all 32-bit aligned.  The fix seems to be to make the
> Reserved field 24 bits long.
> 
> 
> Thanks!
> 
> Alvaro.

-- 
---
tte@cs.fau.de