Re: [pim] Hi Reshad, the issues about igmp snooping model are addressed. Thanks a lot! Re: [yang-doctors] Yangdoctors early review of draft-ietf-pim-igmp-mld-snooping-yang-03

"Reshad Rahman (rrahman)" <rrahman@cisco.com> Thu, 20 September 2018 12:26 UTC

Return-Path: <rrahman@cisco.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9358C130EB3; Thu, 20 Sep 2018 05:26:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.51
X-Spam-Level:
X-Spam-Status: No, score=-14.51 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L4ZFLVBv-mGx; Thu, 20 Sep 2018 05:26:03 -0700 (PDT)
Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 17F5B130ED1; Thu, 20 Sep 2018 05:26:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=36236; q=dns/txt; s=iport; t=1537446363; x=1538655963; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=d6mqd2rRMn40IUswCBjhYbSqhDRIa8u9Cp/XbqLhya0=; b=ha2XkLwsHO4T2xPbDbhEOUOFc1CC9++DU/TwO2dIi6crX9E+Yl5QN5n/ gYnuiI82EyOGnRDCsawZR52HWhTslaktA0m/RnHJFtDXgubIGZ6MJYoji LuWXiK8CuzgSvOc23mv0kSpSubotxkEbUSn1Gl/ntVupmJgRBy84nw2V3 0=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0ATAAAGkaNb/5xdJa1bGQEBAQEBAQEBAQEBAQcBAQEBAYFQgRF3ZX8oCoNpiBWMMIINlk6BegsshEACF4MpITQYAQMBAQIBAQJtKIU4AQEBAQMjVhACAQYCEQMBAQEhAwQDAgICMBQJCAIEDgWDIQGBHWSIGJtNgS6KGYpvF4FBP4E5H4FOfoUeFoJLMYIEIgKIRnSEKIVwiRwJApAiF48ilE4CERSBJR04gVVwFWUBgkEJgkSOB2+BFotAAYEdAQE
X-IronPort-AV: E=Sophos;i="5.53,398,1531785600"; d="scan'208,217";a="174211483"
Received: from rcdn-core-5.cisco.com ([173.37.93.156]) by alln-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Sep 2018 12:26:02 +0000
Received: from XCH-RCD-002.cisco.com (xch-rcd-002.cisco.com [173.37.102.12]) by rcdn-core-5.cisco.com (8.15.2/8.15.2) with ESMTPS id w8KCQ1v9003428 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 20 Sep 2018 12:26:01 GMT
Received: from xch-rcd-005.cisco.com (173.37.102.15) by XCH-RCD-002.cisco.com (173.37.102.12) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 20 Sep 2018 07:26:01 -0500
Received: from xch-rcd-005.cisco.com ([173.37.102.15]) by XCH-RCD-005.cisco.com ([173.37.102.15]) with mapi id 15.00.1395.000; Thu, 20 Sep 2018 07:26:01 -0500
From: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
To: Hongji Zhao <hongji.zhao@ericsson.com>
CC: "draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org" <draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org>, "pim@ietf.org" <pim@ietf.org>, YANG Doctors <yang-doctors@ietf.org>
Thread-Topic: Hi Reshad, the issues about igmp snooping model are addressed. Thanks a lot! Re: [yang-doctors] Yangdoctors early review of draft-ietf-pim-igmp-mld-snooping-yang-03
Thread-Index: AQHUS92c44q7s6TJkkCulHuCG78arKTvy2GAgAXfX4CAA4h1AA==
Date: Thu, 20 Sep 2018 12:26:00 +0000
Message-ID: <3FB4369B-3DF6-4BC5-9C9A-5A0C90E9BE62@cisco.com>
References: <VI1PR07MB41921D54D3B708744DFFE21796270@VI1PR07MB4192.eurprd07.prod.outlook.com> <D88D0793-9EE6-4D95-9F4B-C0B483C1F21C@cisco.com> <VI1PR07MB419207CA816246DAD95F455396040@VI1PR07MB4192.eurprd07.prod.outlook.com> <A383C3C0-E62B-48DB-95DF-A52968BE2FFF@cisco.com> <VI1PR07MB419228965CBBF4412CB6D0FC96190@VI1PR07MB4192.eurprd07.prod.outlook.com> <1CCA0ACC-A4D8-4EAD-B1C7-8CC7F38D34EF@cisco.com> <VI1PR07MB4192E3A060F6103856AE065D961D0@VI1PR07MB4192.eurprd07.prod.outlook.com>
In-Reply-To: <VI1PR07MB4192E3A060F6103856AE065D961D0@VI1PR07MB4192.eurprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.b.0.180311
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [161.44.212.58]
Content-Type: multipart/alternative; boundary="_000_3FB4369B3DF64BC59C9A5A0C90E9BE62ciscocom_"
MIME-Version: 1.0
X-Outbound-SMTP-Client: 173.37.102.12, xch-rcd-002.cisco.com
X-Outbound-Node: rcdn-core-5.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/Ljxz8Ga3ZZ1jfZEX-55qJ9zIU0k>
Subject: Re: [pim] Hi Reshad, the issues about igmp snooping model are addressed. Thanks a lot! Re: [yang-doctors] Yangdoctors early review of draft-ietf-pim-igmp-mld-snooping-yang-03
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Sep 2018 12:26:08 -0000

Hi Hongji,

It looks like those statistics are needed only for interfaces (not for PWs) , so you could keep them under augment of if:interface, or put those stats under bridge-mrouter-interface and l2vpn-mrouter-interface-ac in the snooping-instance. My preference is for the latter.

Regards,
Reshad.

From: Hongji Zhao <hongji.zhao@ericsson.com>
Date: Monday, September 17, 2018 at 10:28 PM
To: "Reshad Rahman (rrahman)" <rrahman@cisco.com>
Cc: "draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org" <draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org>, "pim@ietf.org" <pim@ietf.org>, YANG Doctors <yang-doctors@ietf.org>
Subject: RE: Hi Reshad, the issues about igmp snooping model are addressed. Thanks a lot! Re: [yang-doctors] Yangdoctors early review of draft-ietf-pim-igmp-mld-snooping-yang-03

Hi Reshad,

In augment /if:interfaces/if:interface, besides mrouter related data, there are still some statistics related with igmp-mld-snooping.
If take out the whole augmentation of if:interfaces, the statistics will be lost.  What do you think of that?

augment /if:interfaces/if:interface:
    +--rw igmp-mld-snooping
       +--ro statistics
          +--ro received
          |  +--ro query?                  yang:counter64
          |  +--ro membership-report-v1?   yang:counter64
          |  +--ro membership-report-v2?   yang:counter64
          |  +--ro membership-report-v3?   yang:counter64
          |  +--ro leave?                  yang:counter64
          |  +--ro non-member-leave?       yang:counter64
          |  +--ro pim?                    yang:counter64
          +--ro sent
             +--ro query?                  yang:counter64
             +--ro membership-report-v1?   yang:counter64
             +--ro membership-report-v2?   yang:counter64
             +--ro membership-report-v3?   yang:counter64
             +--ro leave?                  yang:counter64
             +--ro non-member-leave?       yang:counter64
             +--ro pim?                    yang:counter64

BR/Hongji
赵宏吉


From: Reshad Rahman (rrahman) <rrahman@cisco.com>
Sent: Friday, September 14, 2018 8:48 PM
To: Hongji Zhao <hongji.zhao@ericsson.com>
Cc: draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org; pim@ietf.org; YANG Doctors <yang-doctors@ietf.org>
Subject: Re: Hi Reshad, the issues about igmp snooping model are addressed. Thanks a lot! Re: [yang-doctors] Yangdoctors early review of draft-ietf-pim-igmp-mld-snooping-yang-03

Hi Hongji,

Yes I don’t see the purpose of augmenting if:interfaces, I believe all mrouter related data could be in l2vpn-instance or bridge. If this is not the case I’d like to understand why.

I have no further major comments, will do detailed review once this major comment is resolved.

Regards,
Reshad.

From: Hongji Zhao <hongji.zhao@ericsson.com<mailto:hongji.zhao@ericsson.com>>
Date: Thursday, September 13, 2018 at 11:47 PM
To: "Reshad Rahman (rrahman)" <rrahman@cisco.com<mailto:rrahman@cisco.com>>
Cc: "draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org<mailto:draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org>" <draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org<mailto:draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org>>, "pim@ietf.org<mailto:pim@ietf.org>" <pim@ietf.org<mailto:pim@ietf.org>>, YANG Doctors <yang-doctors@ietf.org<mailto:yang-doctors@ietf.org>>
Subject: RE: Hi Reshad, the issues about igmp snooping model are addressed. Thanks a lot! Re: [yang-doctors] Yangdoctors early review of draft-ietf-pim-igmp-mld-snooping-yang-03

Hi Reshad,

Do you mean it’s best to take out the whole augmentation of if:interfaces?

And besides it, do you have any other comments about the latest version of igmp snooping model?

Thanks a lot!

BR/Hongji
赵宏吉

From: Reshad Rahman (rrahman) <rrahman@cisco.com<mailto:rrahman@cisco.com>>
Sent: Friday, September 14, 2018 2:22 AM
To: Hongji Zhao <hongji.zhao@ericsson.com<mailto:hongji.zhao@ericsson.com>>
Cc: draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org<mailto:draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org>; pim@ietf.org<mailto:pim@ietf.org>; YANG Doctors <yang-doctors@ietf.org<mailto:yang-doctors@ietf.org>>
Subject: Re: Hi Reshad, the issues about igmp snooping model are addressed. Thanks a lot! Re: [yang-doctors] Yangdoctors early review of draft-ietf-pim-igmp-mld-snooping-yang-03

Hi Hongji,

Yes I believe it’s best to take out the augment of if:interfaces and have everything in the l2vpn-instance or bridge. Also, right now I believe  the model is inconsistent because PWs which can be used for mrouter-interface do not have any config outside of l2vpn-instance (but AC interfaces used as mrouter-interface do have mrouter config under if:interface ).

Regards,
Reshad.

From: Hongji Zhao <hongji.zhao@ericsson.com<mailto:hongji.zhao@ericsson.com>>
Date: Monday, September 10, 2018 at 10:18 PM
To: "Reshad Rahman (rrahman)" <rrahman@cisco.com<mailto:rrahman@cisco.com>>
Cc: "draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org<mailto:draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org>" <draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org<mailto:draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org>>, "pim@ietf.org<mailto:pim@ietf.org>" <pim@ietf.org<mailto:pim@ietf.org>>, YANG Doctors <yang-doctors@ietf.org<mailto:yang-doctors@ietf.org>>
Subject: RE: Hi Reshad, the issues about igmp snooping model are addressed. Thanks a lot! Re: [yang-doctors] Yangdoctors early review of draft-ietf-pim-igmp-mld-snooping-yang-03

Hi Reshad,

Thanks for your reply.

In IGMP Snooping, the mrouter interface (i.e. Multicast router interface)  is the interface which connects to the multicast router. So there may be more than one mrouter interfaces in a l2vpn-instance or BRIDGE.
As you say,  an interface refers to l2vpn-instance and l2vpn-instance has lists of ACs and PWs for the same mrouter-interface functionality.

Here is how to configure and show Internet Group Management Protocol (IGMP) snooping for IPv4 multicast traffic on the Cisco 7600 series routers.
Gi1/1,Gi2/1,Fa3/48 are all the mrouter interfaces in vlan 1.

Displaying Multicast Router Interfaces
When you enable IGMP snooping, the router automatically learns to which interface the multicast
routers are connected.
To display multicast router interfaces, perform this task:
This example shows how to display the multicast router interfaces in VLAN 1:
Router# show ip igmp snooping mrouter vlan 1
vlan ports
-----+----------------------------------------
1 Gi1/1,Gi2/1,Fa3/48,Router


In the current igmp snooping model, we can configure static-mrouter-interface and static-l2-multicast-group either under the igmp-snooping-instance or under the augment /if:interfaces/if:interface. The purpose is to provide the customer more than one way to configure static-mrouter-interface and static-l2-multicast-group.
Maybe it looks in a mess.
If removing the static-mrouter-interface and static-l2-multicast-group under augment /if:interfaces/if:interface is better, I can remove them.


BR/Hongji
赵宏吉