Re: [pim] [Last-Call] Opsdir last call review of draft-ietf-pim-drlb-13

Stig Venaas <stig@venaas.com> Wed, 11 December 2019 23:00 UTC

Return-Path: <stig@venaas.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CE119120832 for <pim@ietfa.amsl.com>; Wed, 11 Dec 2019 15:00:28 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=venaas-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5wUoybai4jWM for <pim@ietfa.amsl.com>; Wed, 11 Dec 2019 15:00:27 -0800 (PST)
Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B52D6120807 for <pim@ietf.org>; Wed, 11 Dec 2019 15:00:26 -0800 (PST)
Received: by mail-ed1-x52b.google.com with SMTP id cy15so81211edb.4 for <pim@ietf.org>; Wed, 11 Dec 2019 15:00:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=venaas-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R8frLuto9RVd4ozXSXbac4bwMROD34hPCIx8gv51+hE=; b=d6D4vENgau5OpMuoL6TxsdMLBJ4j820ZnB6sRqO2k8wR9VCZEfgi57WLYkbQIQ0bMN 7v6FlyZdX1KHHiXRrG2cRDQ7r5oMsoiFC6XF4TIbT+b/qlXQ8kBEBNryaoJ33PoUEw3f zRXBfPLumRi8qD1YKhHWZgfi+0tQsb3CzmoFWlG7crUuEkhPDmDsTIWjxaKT0WtCTubP iQuByA8GMhHts7n6PsLZ/bMjaJILIVa9z+bqwSGgCLGue5/kCzxD/dNBeU1HmIA5F4Sb pTUrVkzUDGaARuqqm2xDB8zZlMqLi9SvVjpLfhtEsWZ/kd1folwyyG1+FwpvCoJN3Avm 7xOQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R8frLuto9RVd4ozXSXbac4bwMROD34hPCIx8gv51+hE=; b=nPhoHm23EwBksBD0wCGLRjXXxFHdAx8HY5rUFu9SfeLkinFRs2T4BqR9h+LGNBkxAr HleiPtI9C/m6TZRJD8Q1rry2xJrKPqWLu3kQqHa4QY+L3qtUJ8z0Hk4DrRr0SuGs2Yqs Wwblxrr0SXEqz2Trd6O3B+VTd+vhKPmDKN3jZ4v2wC0Zn/yVAuNzDgL4O0OpHnZEFxa3 aS67aAZl1aDQy4a3OCyi4s/B5jQ/I0dVQUeTSnjWUAWiao3FxVIQ2SAlSZTMveXbKTs4 lHsWk10Bxd8ZTP4bAQuw8KARpE5ZwYIiw4PBuo3urd78eHA5xC/RWaz/nR0/kcKpfidc jWdQ==
X-Gm-Message-State: APjAAAVyrb6JPoaD7qeQvefVBGqlk1YqdwfSHXRgOAUr6cXgxJRyEcnn xeiTtSAuX17b7+54yuiVf9bgSlIKGjvsgruFQ+PAqQ==
X-Google-Smtp-Source: APXvYqw/yLOVaKTw56+D0Kt9bq2WoqzeLtanZA0ACvHczGKQKfhzdoznq++h5dPVXG/9ByMxi+8Fz6+RErxjQhTONV8=
X-Received: by 2002:a17:906:aad0:: with SMTP id kt16mr6106377ejb.223.1576105225274; Wed, 11 Dec 2019 15:00:25 -0800 (PST)
MIME-Version: 1.0
References: <157246378456.32588.13080368226769629725@ietfa.amsl.com>
In-Reply-To: <157246378456.32588.13080368226769629725@ietfa.amsl.com>
From: Stig Venaas <stig@venaas.com>
Date: Wed, 11 Dec 2019 15:00:14 -0800
Message-ID: <CAHANBtLJyhP896gRw4mo5V=HEtYqC+633GmRHK_Ps8nONKsHmw@mail.gmail.com>
To: Joe Clarke <jclarke@cisco.com>
Cc: ops-dir@ietf.org, last-call@ietf.org, pim@ietf.org, draft-ietf-pim-drlb.all@ietf.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/UmNYEkUOOdVABAolpPTCq1dZN6U>
Subject: Re: [pim] [Last-Call] Opsdir last call review of draft-ietf-pim-drlb-13
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Dec 2019 23:00:29 -0000

Hi

Thanks for your review. I addressed the nits in the latest version. I
could maybe have added the callout you suggested, but I omitted that.
I hope vendors/implementors will provide it though.

Stig

On Wed, Oct 30, 2019 at 12:30 PM Joe Clarke via Datatracker
<noreply@ietf.org> wrote:
>
> Reviewer: Joe Clarke
> Review result: Ready
>
> I was asked to review this document on behalf of the ops directorate.  This
> document describes a new protocol to do PIM DR load balancing.  In general, I
> think this document is ready.  I appreciate both the backwards compat and
> operator considerations sections.  In fact, as I read through this, I kept
> thinking, "I hope they talk about legacy vs. new routers on the same shared
> LAN".  One thing that might be good to add is a callout to vendors/implementors
> that they are explicit in which GDR for which group/source.  Thinking with a
> troubleshooting mind, this changes the paradigm in forwarding and knowing how
> that behaves will be critical.
>
> I also found three really small nits:
>
> Section 5.2.1:
>
> s/ordinal number of router X/ordinal number of Router X/
>
> ===
>
> Section 5.4:
>
> s/permissable/permissible/
>
> ===
>
> Section 5.8:
>
> s/take part in an load-balancing/take part in load-balancing/
>
> --
> last-call mailing list
> last-call@ietf.org
> https://www.ietf.org/mailman/listinfo/last-call