Re: [pim] Updates to draft-ietf-pim-igmp-mld-extension, WG input wanted

Aijun Wang <wangaijun@tsinghua.org.cn> Thu, 12 May 2022 12:04 UTC

Return-Path: <wangaijun@tsinghua.org.cn>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9032CC157B56 for <pim@ietfa.amsl.com>; Thu, 12 May 2022 05:04:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.894
X-Spam-Level:
X-Spam-Status: No, score=-1.894 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, MIME_QP_LONG_LINE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GDsRlOBeuOxr for <pim@ietfa.amsl.com>; Thu, 12 May 2022 05:04:09 -0700 (PDT)
Received: from mail-m17638.qiye.163.com (mail-m17638.qiye.163.com [59.111.176.38]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E2626C157B4C for <pim@ietf.org>; Thu, 12 May 2022 05:04:06 -0700 (PDT)
Received: from smtpclient.apple (unknown [221.223.97.226]) by mail-m17638.qiye.163.com (Hmail) with ESMTPA id E8FF01C01A8; Thu, 12 May 2022 20:04:03 +0800 (CST)
Content-Type: multipart/alternative; boundary="Apple-Mail-8A8477C6-196C-47B3-BA70-3032AA8A0012"
Content-Transfer-Encoding: 7bit
From: Aijun Wang <wangaijun@tsinghua.org.cn>
Mime-Version: 1.0 (1.0)
Date: Thu, 12 May 2022 20:04:03 +0800
Message-Id: <C3CD568B-BB5A-4658-90C8-EF021200349B@tsinghua.org.cn>
References: <CAHANBtJjNtipwPCVm5Vup1P+vU7p_RCMycKn-6K5Du58f1dT3g@mail.gmail.com>
Cc: pim@ietf.org
In-Reply-To: <CAHANBtJjNtipwPCVm5Vup1P+vU7p_RCMycKn-6K5Du58f1dT3g@mail.gmail.com>
To: Stig Venaas <stig@venaas.com>
X-Mailer: iPhone Mail (19E258)
X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUpMS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRkeGENWT0hKHxpPQ0 4YS01MVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktITUpVS1kG
X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6NEk6Hhw6Gj0*LkkWNQ9KLxAp MzEaCyNVSlVKTU5JSE5MS09PSUNMVTMWGhIXVQwaFRwaEhEOFTsPCBIVHBMOGlUUCRxVGBVFWVdZ EgtZQVlJSUpVSUlIVUJMVUlJTVlXWQgBWUFDQk5PNwY+
X-HM-Tid: 0a80b82796f3d993kuwse8ff01c01a8
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/gINJOfWrDHLQMiUmn14EdEBPjpE>
Subject: Re: [pim] Updates to draft-ietf-pim-igmp-mld-extension, WG input wanted
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 12 May 2022 12:04:13 -0000

Hi, Stig:

Is it useful to define the total length of “Extension TLV” at the beginning of the “Extension Format”?
As indicated in the https://datatracker.ietf.org/doc/html/draft-ietf-pim-igmp-mld-extension-07.txt#section-5

“The total length of the Extension MUST NOT exceed the remainder of
      the IP payload length.  For this validation, one only examines the
      content of the Extension Length fields.”

In the current format, to accomplish the validation, the implementation must walk through all the TLVs.

And, if such field exist, the former validation can also be easier, or just ignore it.

“There MUST NOT be any data in the IP payload after the last TLV.
      To check this, the parser needs to walk through each of the TLVs
      until there are less than four octets left in the IP payload.  If
      there are any octets left, validation fails.”


Aijun Wang
China Telecom

> On May 12, 2022, at 08:26, Stig Venaas <stig@venaas.com> wrote:
> 
> Dear pim WG
> 
> Based on the IESG evaluation of draft-ietf-pim-igmp-mld-extension I
> have made some larger changes, please see
> https://datatracker.ietf.org/doc/html/draft-ietf-pim-igmp-mld-extension-07.txt
> 
> There was a request to add experimental code-points. I've added 2, I
> think that should be sufficient. Different experiments can use the
> same code-points.
> 
> I was also asked to add a no-op TLV. This doesn't do much, but it
> might perhaps allow testing of implementations to see whether they are
> parsing TLVs correctly.
> 
> Finally, there were questions whether IETF Review is too strict for
> assignment of code-points. In my opinion we should be cautious with
> new extensions and IETF Review allows us to carefully review any
> extensions in the IETF. Alternatively we could for instance have
> relaxed it to just require a specification (this could be any
> document, not requiring review). Please let me know if you believe we
> should relax this.
> 
> Hoping to get input within two weeks (May 25th), so that we can move
> ahead with the publication, or revise as needed. Mike, let me know if
> we need to do anything else to get sufficient review.
> 
> Thanks,
> Stig
> 
> _______________________________________________
> pim mailing list
> pim@ietf.org
> https://www.ietf.org/mailman/listinfo/pim