IETF Logo Mail Archive

Re: [pim] Yangdoctors last call review of draft-ietf-pim-igmp-mld-snooping-yang-19

Hongji Zhao <hongji.zhao@ericsson.com> Thu, 30 September 2021 03:25 UTC

Return-Path: <hongji.zhao@ericsson.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C36523A101F; Wed, 29 Sep 2021 20:25:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.553
X-Spam-Level:
X-Spam-Status: No, score=-2.553 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.452, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FwpO0DQ0B5pN; Wed, 29 Sep 2021 20:25:17 -0700 (PDT)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70054.outbound.protection.outlook.com [40.107.7.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0176D3A1019; Wed, 29 Sep 2021 20:25:13 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dO7ywy1E0geTGdFqwOCHewhXR+Sm5N0+rSVel+cP/YLZVq6169hAVAKH8KCTIAYo05MNa3yV12vFUhFMoA0sDhX6qjZbAUOmwDh5ZfTLVxgt8doIl9TczYK62BSduuOKqVSc+nopISEq6GnCTfyvPiXuMzKenIGT/cjBf/GMyOLFf3Gyde4ywQqyULngNEZJvVOR0Gz+Ke+au5/pYGcDdXbiYbNxMJSCW0Rje/fMyZGbh4FsKJ1++x16GUQykv68La57Q5eQ3k3e7Jj4ustD6Hb9/OzgnBuVdSAirxEYa5BOonpi1xiNeHfACSZTshmkpBRFUf1tzvr7gyyIb9IKMg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MpaaYsemElZRyu8ZyOGoT22MFPmyUrkFtbz2dQvtl9Q=; b=YfXEWKLteLAyyJxTo/h0o9/0/uqyyjLa6gS+EJqvJa6SvRTN+XU1he0w+9jgfg05oorBrS2L54Kopuezg5oGYNoovjQjucUUDfwuJWVcXuTmyllPStw2Em7Lw0suVXvAzfApxjbw5BArBjlUOm/i/jk7wpdoqPo8svfuNKjSjm3IUD/kHPrOtK9e7fUb75e3oLK6nshQBKd4HAEtafV/J9VYcAcD4sDtzwGRiX4T21igpz/r3XrCNurUY1i3j5JUAMgS/4AwUsWHeaX5zhaTu7VbMCbClV59qyizYDGtgj4nVGeBgNfrGQlVA+0IfGK1X+v63JCEWXxOcChjHoYZbA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MpaaYsemElZRyu8ZyOGoT22MFPmyUrkFtbz2dQvtl9Q=; b=S3R1hzeIUSQYJ2X4AsrjZaR6Ghr/PQBAM2w8IXkA/gXP/uHn8vS2/ttbu0r3RnDiwgDrws1ivd8aTEwiOMpFd7/p60mm3q4wQxVhbyBUdkk/AbOREGBGhyKy+Franr8gBDD9opvNQbBg71XmpCzRmPfI3X28lyZtkd3MZqnIpTs=
Received: from DB6PR07MB4438.eurprd07.prod.outlook.com (2603:10a6:6:52::13) by DB7PR07MB6057.eurprd07.prod.outlook.com (2603:10a6:10:8e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.9; Thu, 30 Sep 2021 03:25:09 +0000
Received: from DB6PR07MB4438.eurprd07.prod.outlook.com ([fe80::3155:841d:12bb:362f]) by DB6PR07MB4438.eurprd07.prod.outlook.com ([fe80::3155:841d:12bb:362f%5]) with mapi id 15.20.4566.014; Thu, 30 Sep 2021 03:25:09 +0000
From: Hongji Zhao <hongji.zhao@ericsson.com>
To: Reshad Rahman <reshad@yahoo.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org" <draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "pim@ietf.org" <pim@ietf.org>
Thread-Topic: Yangdoctors last call review of draft-ietf-pim-igmp-mld-snooping-yang-19
Thread-Index: AQHXtaiGPQpz2dduN0ezKWEbZwsye6u76c3g
Date: Thu, 30 Sep 2021 03:25:08 +0000
Message-ID: <DB6PR07MB4438B044994F85E3BBA269EA96AA9@DB6PR07MB4438.eurprd07.prod.outlook.com>
References: <163297133399.7456.4753723321157921343@ietfa.amsl.com>
In-Reply-To: <163297133399.7456.4753723321157921343@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: yahoo.com; dkim=none (message not signed) header.d=none;yahoo.com; dmarc=none action=none header.from=ericsson.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8d641f7c-2307-4ffd-429c-08d983c1e7d1
x-ms-traffictypediagnostic: DB7PR07MB6057:
x-microsoft-antispam-prvs: <DB7PR07MB605754F1E7081B8B35DABF9C96AA9@DB7PR07MB6057.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Ucmr8de525wToJwKJvOQsusSayYokb8e3CiawdCY8RaBEQboimyh9fGhbHBu5I1wQXIX1xJ1uOW6oTdZ+sXFWc26/aL5ZQhC6oW3mTepemdouOouK7Jmo6vGOys9WsM9GXmXFBxFrBOFl7nXgEU2Y/GFXg0w6mYzL35k53jkXX/H6oVNmeeAXYxgTrZyB3U02OoNNEUOlRN8SJp+eJNw5jiht2LyVqpfWwYSirwCMjsnIWMWLf8T2KTcbM0TWiJEQvqA1//liJ+zK9/ufs2G8y60UHCYO0cNyf76GUKJiCa41dYoGWP6cG+FZuhsZhLr+rPIvd6ZeYmTIMmImNVlykxJP6BsoWoB9Sl9YOpdzfpeZxmXcUe15Gl0nRG4CPzYlDQgZO88Fty1/0lUFCHUaeO/yR9iQlOrTwCnKWLvuYpGot5bDPDx5RgB71+vnxUBFsSiHyIhY1GBJAzUIwO4bTsTHEWMHn74aL5ldv1EqK7ZQw6DexYLK9Yvx926WsS/e5Oc+zsTQlcOKgyG5rvcGy+M1ZkX+eTPehJpHMftDLAinSj2j1srQK7ZDDrfC0NLmz6Mfdpmpx+gFP2ts1MBbI4kc6v1sfz5F52WJqTrm9opRHzc9JGsb2MJM33PIYOATZS+LuYoM9zq18EssC2zp5ExJWjyrYAQ35VHQI+saFEU+f5hvnsM3U/VaLx/yKYweNHGXa1vZu2j1lTD+dSjRA==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR07MB4438.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(83380400001)(76116006)(66574015)(54906003)(52536014)(66476007)(66556008)(64756008)(66446008)(110136005)(4326008)(5660300002)(316002)(66946007)(26005)(38070700005)(53546011)(55016002)(71200400001)(6506007)(2906002)(8936002)(33656002)(86362001)(8676002)(186003)(38100700002)(7696005)(9686003)(508600001)(122000001)(44832011); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: SijhnPDkt218wPM5fNaLMRkC5rr3qAcOtN5dgfEgqwy3cg1xVhkWpdG3scZAlfhi5qMhl0RkKKPbWCSRnI57Z02s93PFTRBpxdwDwnK3tnpAybx4OEam0tYp7g066aZ2H2pA/YCuk35ZqkvtjcFGErfw+sjxwadXpURpnGKRbieFXRzv/VVnH3WMp6FookVsq8ALX0Ldx/pXc4p06uNT96l5cUNsm3fIclgxm6GjbaK/JjFG5eqf2JmApgXr2eoqvFT6zQJpYeKMC6IG82k90ozKOUO3wWFNOhiNu1uZQFVoSmZJ6yTYE8KB/SyfbHj19IGY086f1Wj3t6A3Fxh3b1ypIMoHIT+xpS2mO5G1FtcqGFoGMTJzo5GWIH2pOyRTlESqAks1ORXjg/7UELVP4HTBKeAyUB64Su0NQUEy3fJOjaZ0bGXMOe+PQxeYQM2Z3PC0V7z62U4ltCuK21AgxLWf427vpRe2MkP3aEzlZCUH37TfWBGddfcU1+ObHtCnjT1ICjmlLlaDVYNzi89GOJm8RyZIEDZZ4WvspNRcNS/FBiqsr4+ifg40pBQhqrBNgkfZVjWxXpqWUg3iKP+mlfNDHNpcu8U3jsXmyZM0W00gPeWRhw1AyPp0UH/4dUzma4jT2fTmApkMQbN7zzH9VSL05pC+5uCCX753Vbe0td8Lz8T2ZUDb2iZr+pnjJikBLbgxYuRyMvThJUeGDbpOgVJgldr5U8X+ie8OauZ3osqAddA/eWgoBZXFOOX/rWVewwES3etYicaAsFJ0KQQxBy/HRkR2vpSYQgWJjVIRKqgtt1agVITpezQCPKrgWZppzQVC5iUxJOKODkppFAn73MVFx89I4VfAKMVjXm1mwJE6JpG+znemaKXDVhNALc6vmzAv/TLnrsdshJ0GSzfTH0hx4E7tq+qcQTooWRzdZZMz4nh45rx07aTp7TNRELqVdJyi1zFehKGR7bUNGE/lbwAUOtg7+X5o7t2TgRmK9d+5uYBUov/0acxHnyVAx9u+4pIbUF2B1h/iuaBpdq4QcI1IvYaqnSgGMETe6ijg33+3OT4A5ufmNCZKRnxvzUrcd/nhowmpbuCJQjngDWADTb8AhuGrEJkc4stlvXfKt2RhWZldtokFmjde7FNTTEMKt48299ALPRHfRRbldLPZCjBLVy0VhOIfzgTcfsgbEn6mZUrJwdTXA1w5yPrnITiytQ4IIouwoW0Hm20O+J1fZILj5JbFH306GO2bLwF3jdXySMRBG7GFRwumncHJv35DSwsSf7afZ3wtsGel7NbK2B+bsBO+srOlUVegJtZGEcho880gNs13nTvbbeXngAqV
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB6PR07MB4438.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d641f7c-2307-4ffd-429c-08d983c1e7d1
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2021 03:25:08.9044 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rAuszXlG+1KWqvR3RHG/uiPC08Ied9XBQLTHe5zcyiNOMGdRCIO/5mQ99h+urKOWoez1Rr+8+Rxm/EPhOcZeCSVL3ghrhxzDuvTC4LdCNLM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR07MB6057
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/gh46lgbulrS29fQ0SAkbYEKQ5x8>
Subject: Re: [pim] Yangdoctors last call review of draft-ietf-pim-igmp-mld-snooping-yang-19
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Sep 2021 03:25:22 -0000

Hi Reshad,

Thanks a lot for your comments. We will discuss and address them ASAP.

BR/Hongji

-----Original Message-----
From: Reshad Rahman via Datatracker <noreply@ietf.org> 
Sent: 2021年9月30日 11:09
To: yang-doctors@ietf.org
Cc: draft-ietf-pim-igmp-mld-snooping-yang.all@ietf.org; last-call@ietf.org; pim@ietf.org
Subject: Yangdoctors last call review of draft-ietf-pim-igmp-mld-snooping-yang-19

Reviewer: Reshad Rahman
Review result: Ready with Nits

This is my 3rd review of the document. While I have focused on changes done since my last review, some comments apply to parts of the YANG model which hasn't changed recently.

Main comments
=============

- Feature immediate-leave mentions “fast leave” in the description. RFC3376 mentions fast leave but not immediate leave. Should the feature, and the leaf node which depends on it, be renamed to fast-leave?

- Leaf send-query, description says that it cooperates with parameter querier-source. I believe there should be enforcement that send-query can only be set if querier-source is also set (must statement)? Also querier-source in IGMP mentions VLAN, no such mention in MLD, is that correct?

Questions
========

- Feature static-l2-multicast-group. The description mentions L2 multicast static-group. Is it a static multicast group or a multicast static group? I believe it’s the former and the description should be changed?

- igmp-version and mld-version are both uint8 with a range (1..3 and 1..2). If we get a new version someday, the range will have to be changed. I don’t recall if this was brought up before. Another option is to use an identity. I realize we don’t spin out a new version frequently so this may not be an issue. And probably with a new version other changes would be needed anyway…

- Last-reporter is present under the group and also under each source entry. Is the one under the group the last host from all sources?

- Leaf node require-router-alert. What happens if it’s set to true and the IP hdr does not contain RA? Consider updating description and/or adding a reference.

Minor
=====

- Typo in bridge-router-interface: dynamicly.

- No need to mention the leaf name in description, e.g. in l2-service-type

- Leaf “host-address”, rename to “address” since the list is called host (no need to duplicate host).

Regards,
Reshad.

v2.23.0 | Report a Bug | By Email