[pim] Robert Wilton's No Objection on draft-ietf-pim-null-register-packing-15: (with COMMENT)
Robert Wilton via Datatracker <noreply@ietf.org> Thu, 09 March 2023 08:18 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: pim@ietf.org
Delivered-To: pim@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 05DA2C14CF01; Thu, 9 Mar 2023 00:18:02 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Robert Wilton via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-pim-null-register-packing@ietf.org, pim-chairs@ietf.org, pim@ietf.org, Mike McBride <mmcbride7@gmail.com>, aretana.ietf@gmail.com, mmcbride7@gmail.com
X-Test-IDTracker: no
X-IETF-IDTracker: 9.13.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Robert Wilton <rwilton@cisco.com>
Message-ID: <167834988201.30053.2862924426524497613@ietfa.amsl.com>
Date: Thu, 09 Mar 2023 00:18:02 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/i7_V5WZJU2v0xD-GIWI1WTuLrA0>
Subject: [pim] Robert Wilton's No Objection on draft-ietf-pim-null-register-packing-15: (with COMMENT)
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Mar 2023 08:18:02 -0000
Robert Wilton has entered the following ballot position for draft-ietf-pim-null-register-packing-15: No Objection When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ for more information about how to handle DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-pim-null-register-packing/ ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- Updated. Discuss cleared - thanks for addressing my discuss issue. Regards, Rob ---------- Previous comments: Minor level comments: (2) p 2, sec 2. Packed Null-Register Packing Capability 0 1 2 3 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ |PIM Ver| Type |P|6 5 4 3 2 1 0| Checksum | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Group Address (Encoded-Group format) | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Source Address (Encoded-Unicast format) | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ Figure 1: PIM Register-Stop message with Packing Capability option I found the description of the flag bits to be unclear: - Are the "6 5 .. 1 0", the flag bits? - Is 'P' the "Packed Capability" bit? If so, this diagram implies that it takes the value 7, but the text indicates that it hasn't been permanently assigned yet. (3) p 3, sec 3. PIM Packed Null-Register message format 0 1 2 3 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ |PIM Ver| Type |Subtype| FB | Checksum | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Group Address[1] (Encoded-Group format) | | Source Address[1] (Encoded-Unicast format) | . . . . . . . . . Group Address[N] . | Source Address[N] | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ Figure 2: PIM Packed Null-Register message format Unclear what FB means, "Flag Bits"? Also in section 4. Nit level comments: (4) p 4, sec 5. Protocol operation However, it is RECOMMENDED to stick to the packed format as long as the RP and DR have the feature enabled. As an editorial nit, I would suggest combining these two sentences together to make it clear what "the decision" is referring to. The same comment also applies to the pragraph below. Regards, Rob
- [pim] Robert Wilton's No Objection on draft-ietf-… Robert Wilton via Datatracker