Re: [pim] Intdir telechat review of draft-ietf-pim-igmp-mld-extension-05

Stig Venaas <stig@venaas.com> Fri, 21 January 2022 23:01 UTC

Return-Path: <stig@venaas.com>
X-Original-To: pim@ietfa.amsl.com
Delivered-To: pim@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C9B0A3A14DE for <pim@ietfa.amsl.com>; Fri, 21 Jan 2022 15:01:26 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=venaas-com.20210112.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uSJ4G5vHkYjb for <pim@ietfa.amsl.com>; Fri, 21 Jan 2022 15:01:25 -0800 (PST)
Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5146B3A14DA for <pim@ietf.org>; Fri, 21 Jan 2022 15:01:25 -0800 (PST)
Received: by mail-io1-xd32.google.com with SMTP id h23so12451112iol.11 for <pim@ietf.org>; Fri, 21 Jan 2022 15:01:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=venaas-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=S8a8eQ530KdGq1b7G8Dz0pb1qeJw/8YzpW+z9CXTQHk=; b=bqnnrLIkBTG6dro86EWFRN5up2QR3qPpwiJRHpV4b4wXhICI7Wj1FAnSZHuxrSCGLP pqc0XvK9fF3UGVtxrwSlBEJleN7O7+N5bwJlkeaBvoyH9YfO5/YFR9zRs1cYbGOqEa5Q ZxLx21SnR6AqV3msQSPNip6HvN53hDyzvV/zSp+VtdLOhpt6S9K0Mfv9xD3oagNJjENr VlS3ETbZItF8X5tjZ3l90z7nA+t6XgtEhbfyJdbQ3I/09dMeVIIfteacH6tYyKafoRW1 tEWR5cOn/P/X1RKfFdfhPiCeyvG6V1+ddkp9kM89inxC0gITL8cIpLpss6HwcvRSYpdz 4rCA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S8a8eQ530KdGq1b7G8Dz0pb1qeJw/8YzpW+z9CXTQHk=; b=6+ggaaqhmxkv22T0V5wWZ1MG+fqOr6wRCT8F8E+4q0B1mJ4Q8IJf63IDfoNQf//Wmw UTaT6CcaWNlQJ7XLBa5qv0Md4l1OqBsSlU6hiM6xE546aQo+duxmhhMHt7NZLzD8KM3Q dkZQ9BGN1fwTjqormOCBFnw+rbfkyO/pWmiFO4bK6xOKxVC7SWeiFX9vNwY3IZ+/BzIp JV/IEgDbLgQ6wfL7R7dgH0Wb4BEQNc23rF/qm8e79Kekcc0duSIROALgAjgEdRG7MjZB diZjN1Elq7lZu8/PjWZKrBOKZ5LEmU2sbjBXf5qYGf7Jh3p/yB3odKrGiJJU9wv87hU4 yZTw==
X-Gm-Message-State: AOAM531+iITHpm4+f/vz8/4yNuw+f7lOM4KuIsFnDnvnjmLK0D4aBm8V AbsoVTi3ny5m9hdi1Bpz8LpUGLaX5qpCt3x9hXOBiQ==
X-Google-Smtp-Source: ABdhPJzhXkBQ7Bw5lQ8JvzXpWAS+KHb7wfc5hlQzZ1ZEuZV91+QkClUnTneSUN7Vr0/bTwwP16ng11EQ77NEn0F4Mnw=
X-Received: by 2002:a02:9086:: with SMTP id x6mr415461jaf.235.1642806083590; Fri, 21 Jan 2022 15:01:23 -0800 (PST)
MIME-Version: 1.0
References: <164269629720.6538.7760538444195255480@ietfa.amsl.com>
In-Reply-To: <164269629720.6538.7760538444195255480@ietfa.amsl.com>
From: Stig Venaas <stig@venaas.com>
Date: Fri, 21 Jan 2022 15:01:12 -0800
Message-ID: <CAHANBtJx+DLRPQitwSDtEgs7=C55bBEtoYHqNKaTd6ZTam0JGA@mail.gmail.com>
To: Tommy Pauly <tpauly@apple.com>
Cc: int-dir@ietf.org, last-call@ietf.org, draft-ietf-pim-igmp-mld-extension.all@ietf.org, pim@ietf.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/pim/lnZ8SZ26VN_sHL_hn2S56fkztIE>
Subject: Re: [pim] Intdir telechat review of draft-ietf-pim-igmp-mld-extension-05
X-BeenThere: pim@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Protocol Independent Multicast <pim.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/pim>, <mailto:pim-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/pim/>
List-Post: <mailto:pim@ietf.org>
List-Help: <mailto:pim-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/pim>, <mailto:pim-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Jan 2022 23:01:27 -0000

Hi Tommy

Appreciate the review, I posted revision 06 now. I fixed the
capitalization of SHOULD, and I made the two editorial changes you
suggested. They
do indeed look better.

I read RFC 9170 and found it interesting. I do see the issue with
ossification. It is something we should think about for our protocols
in general,
but I don't think we should add it at this point. It requires some
thought and discussion in the working group, I would rather leave that
for later,
perhaps considering this for multicast protocols such as pim, igmp and
mld in general.

Thanks,
Stig

On Thu, Jan 20, 2022 at 8:31 AM Tommy Pauly via Datatracker
<noreply@ietf.org> wrote:
>
> Reviewer: Tommy Pauly
> Review result: Ready with Issues
>
> Thanks for writing this concise and clear document. The addition of TLV
> extensions seems useful.
>
> I don't see any major issues, but there are a few minor ones.
>
> Like the genart reviewer, I believe this "should" ought to be normative:
>
> "When this extension mechanism is used, the number of Group Records in each
> Report message should be kept small enough that the entire message, including
> any extension TLVs can fit within the network MTU."
>
> In Section 4, I suggest rewording this and fixing capitalization:
>
> "To check this, one will need to walk through each of The TLVs until there are
> less than four octets left in the IP payload."
>
> to:
>
> "To check this, the parser needs to walk through each of the TLVs until there
> are less than four octets left in the IP payload."
>
> In Section 5, I suggest rewording this:
>
> "IGMP and MLD implementations, host implementations in particular, rarely
> change, and it is expected to take a long time for them to support this
> extension mechanism."
>
> to:
>
> "IGMP and MLD implementations (particularly implementations on hosts) rarely
> change, and the adoption process of this extension mechanism is expected to be
> slow."
>
> I also suggest that you consider giving guidance for preventing this new
> extension point from ossifying, given the slow rate of change. Please see the
> discussion in RFC 9170. For example, if you cannot guarantee active use and
> change, you may want to suggest synthetic use of the extension point
> ("greasing" by endpoints sending unknown type values every now and then to make
> sure receivers correctly handle unknown types).
>
>
> _______________________________________________
> pim mailing list
> pim@ietf.org
> https://www.ietf.org/mailman/listinfo/pim