Re: [Ppm] Seeking WG consensus on DAP changes for httpdir review

Christopher Patton <cpatton@cloudflare.com> Wed, 17 January 2024 16:03 UTC

Return-Path: <cpatton@cloudflare.com>
X-Original-To: ppm@ietfa.amsl.com
Delivered-To: ppm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4D17CC14F74E for <ppm@ietfa.amsl.com>; Wed, 17 Jan 2024 08:03:03 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.104
X-Spam-Level:
X-Spam-Status: No, score=-2.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cloudflare.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Iw7k4_rmcDAX for <ppm@ietfa.amsl.com>; Wed, 17 Jan 2024 08:02:59 -0800 (PST)
Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 90261C14F70F for <ppm@ietf.org>; Wed, 17 Jan 2024 08:02:59 -0800 (PST)
Received: by mail-qt1-x82e.google.com with SMTP id d75a77b69052e-4299f424e55so40075061cf.1 for <ppm@ietf.org>; Wed, 17 Jan 2024 08:02:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1705507378; x=1706112178; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OmaOGdt3Bw0nhtaopC8tiZsEgGVzZYYRpfOgzWGLuyM=; b=Q4dC768DVa86Fs6xko3bZQuJ3BFgRMhhXITS2bLe5+00woACKcGAbwCV6xru/vMjrt pjvJZ9TrcCYilvvtnQjN6KzIfZXjY9q+TvCKe2QEK6Mx5zeFtcfr7OIpm7OHgfZ9fnZz VLswZRCFzaIUTQrVmQTzX830dwWVQzmKbPYpGZoFyU8+o5Xn5iZohaOFhWhYrKSb/ROY zXqc0QcSD0bOVq1ppu78C0hsfyvgHsfpQsaofCUqWLH2CRuhSHH50icOyHk3WuoKAspK Mx0dbAOxtPXb/PnEJCgQKRPWRzep0DjO+Mqm01xPN7Fk4zAycRa6SzHP3BmLL6sgXf6j YG1g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705507378; x=1706112178; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OmaOGdt3Bw0nhtaopC8tiZsEgGVzZYYRpfOgzWGLuyM=; b=tRwXe6RN49X6NieqOh1V5lkBhRq8mPPS9/z9MvQGTmCiJkhBfFHCeAhxtRNev49Su8 fo7ZMUUAQXdt4Hhh1rjcPhC46UJF4W1qApBthrUXawwJhLefDW3GcA16FvZwGdhtLKla PjBklvOMrtoTL0f/meDKjvIHp6RGRZATC6SEqSnMbsUl70JVFNI9i3c050t8fqI+Jpvm Z/ZYhN7YYDjz7X71/csQgI2d+GTNjURJlEZ3kfKO1ZwC06aSv+5FMOsJKrs00Bte2vvm PRNsAfzr+gt5euVYLfvulePLSE83jdBB8BPvMs/eEkp69GwAW96qSOb0oFnysUFf+tWF 5btA==
X-Gm-Message-State: AOJu0YxmPdW4SFiRKw+oXWSgL07rtTvnRLo6GiM7PMjIm52RRMlXAdEI gDcWkGDJ6oy81grt2gwugSpeCiO+wJBI2ohU3XBpeV/3xaFYMS1wp81J6Ee1
X-Google-Smtp-Source: AGHT+IGpwwXTy++yqF5JT3LL0e23F5Ms1+SNqrHL6GXxI9QiKghqxd2noIyGQlyyOofQht1iFdApWdcdgq0iOlNDMKQ=
X-Received: by 2002:ac8:4e4a:0:b0:42a:1173:5e8a with SMTP id e10-20020ac84e4a000000b0042a11735e8amr911913qtw.32.1705507378573; Wed, 17 Jan 2024 08:02:58 -0800 (PST)
MIME-Version: 1.0
References: <CACsY-OdvMD36rVM2WN+SuLyB15kgsO75dpGQgdC+BrzVeh5+RA@mail.gmail.com>
In-Reply-To: <CACsY-OdvMD36rVM2WN+SuLyB15kgsO75dpGQgdC+BrzVeh5+RA@mail.gmail.com>
From: Christopher Patton <cpatton@cloudflare.com>
Date: Wed, 17 Jan 2024 08:02:47 -0800
Message-ID: <CAG2Zi2127Ej7VtRhjs4oNur03p1EXnZdAU+5qSH01cuOxFtobg@mail.gmail.com>
To: Tim Geoghegan <timgeog+ietf@gmail.com>
Cc: ppm <ppm@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000764f02060f266145"
Archived-At: <https://mailarchive.ietf.org/arch/msg/ppm/PNTU54WszIcJXrAsYnocGi3ye5g>
Subject: Re: [Ppm] Seeking WG consensus on DAP changes for httpdir review
X-BeenThere: ppm@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Privacy Preserving Measurement technologies <ppm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ppm>, <mailto:ppm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ppm/>
List-Post: <mailto:ppm@ietf.org>
List-Help: <mailto:ppm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ppm>, <mailto:ppm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jan 2024 16:03:03 -0000

Hi Tim, thanks for leading this!



> # Upload request path and method
>
> Currently, report uploads consist of a PUT request to
> {leader}/tasks/{task-id}/reports. This isn't quite right because there's no
> GETtable resource that results from this. I have a PR up ([3]) which
> addresses this by hoisting the report ID into the request path and removes
> it from the request body. Another, simpler choice would be to change the
> request method to POST, note that the request is idempotent and change
> nothing else.
>
> See the linked PR for some discussion of the tradeoffs. At the moment, I'd
> say the consensus is leaning toward changing the method to POST but other
> opinions are welcome!
>

I think your first suggestion is a little tidier as it aligns with the rest
of the API, but a question: Does this add the requirement that the report
be GETtable?

Assuming it does not add any new requirements: I'd slightly favor PUT;
otherwise, I'd favor POST. In any case, POST is less invasive of a change,
so I'm fine changing to POST on that basis.


# RFC 6570 URI templates
>
> DAP defines a very simple syntax for URI templates in [4]. RFC 6570 ([5])
> defines a rich syntax for URI templates that is more than sufficient for
> DAP's needs but includes many features we wouldn't use. What we've got
> works fine so I am inclined to stick with it, but we could choose to use
> RFC 6570, too. At the moment, the consensus leans toward not doing this.
>
> Note that besides establishing consensus in favor of doing this, **we also
> would need a volunteer to make the DAP changes to adopt RFC 6570**.
>

I'm agnostic. I'd be happy to review the change if someone wants to make it.



> # Greater resource URI flexibility
>
> It was also suggested that instead of having DAP mandate specific URI
> templates, we could instead require aggregators to expose a JSON document
> which would contain URI templates, allowing individual implementations or
> deployments to use different request paths. This is akin to the directory
> resource in ACME ([6]). Personally I don't think this is necessary, and
> wouldn't want to introduce an extra HTTP roundtrip into interactions like
> report uploads. But the WG, especially members with more experience
> deploying HTTP servers than I have, should get a chance to weigh in. Once
> again, **a volunteer would be needed to design the new resource and write
> the new protocol text**. At the moment, I'd say the consensus is not to do
> this.
>

I also don't think this is needed.

Chris P.