[quicwg/base-drafts] Issue: Incorrect offset in sample (#3279)
slightlyfloating <notifications@github.com> Mon, 02 December 2019 19:12 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 120D312004E for <quic-issues@ietfa.amsl.com>; Mon, 2 Dec 2019 11:12:22 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.381
X-Spam-Level:
X-Spam-Status: No, score=-6.381 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id piaWmdBs4osY for <quic-issues@ietfa.amsl.com>; Mon, 2 Dec 2019 11:12:20 -0800 (PST)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BBA0C120018 for <quic-issues@ietf.org>; Mon, 2 Dec 2019 11:12:20 -0800 (PST)
Received: from github-lowworker-6349a71.ac4-iad.github.net (github-lowworker-6349a71.ac4-iad.github.net [10.52.18.20]) by smtp.github.com (Postfix) with ESMTP id DE5C9520DBC for <quic-issues@ietf.org>; Mon, 2 Dec 2019 11:12:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1575313939; bh=jkBSbo3C9cC5SfynLZGWJIEczL1b6zzLhJGNbgb0Hv8=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=gLwCYZiloA27JXevsKUdMmn1PB91od2tzBIGIlycLEoT+3Kxpc1LHtim5jorMdFAa fWeaAhrJeA7cF+a4vxUPQTh3YhDR3xWr6S/VvFQie5kTeQXhWynoMThFZ/mcJmVaZ+ hIpTYeUidyk2rokpMmYJQ+QPtMcacq3W683IKuwE=
Date: Mon, 02 Dec 2019 11:12:19 -0800
From: slightlyfloating <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4ACFFFEGEFXPBQMKF36KKJHEVBNHHB7LMNSM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3279@github.com>
Subject: [quicwg/base-drafts] Issue: Incorrect offset in sample (#3279)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5de56213cf909_591e3fc37a0cd9601588bf"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: slightlyfloating
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/1SF5f_tdJpWduWh-8v55Ym-MqFE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Dec 2019 19:12:22 -0000
I believe the sample given in https://tools.ietf.org/html/draft-ietf-quic-tls-24#appendix-A.2 contains an incorrect offset to the packet number field, Considering the 22-byte long header given in the sample c3 ff000017 08 8394c8f03e515708 00 00 449e 00000002 I think the following line header[17..20] ^= mask[1..4] is supposed to read: header[18..21] ^= mask[1..4] as the 4-byte packet number (0x00000002) actually start at offset 18 (0-based) of the header. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/3279
- [quicwg/base-drafts] Issue: Incorrect offset in s… slightlyfloating
- Re: [quicwg/base-drafts] Issue: Incorrect offset … Martin Thomson